You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During the SDK release phase, we often receive review comments on public APIs that require the service team to modify the original specification and regenerate the SDK. This frequently leads to multiple rounds of back-and-forth discussions. It would be beneficial to revisit these cases and determine:
Whether the issue can be addressed on the emitter side, or
Whether the emitter or TCGC should report errors or diagnostics earlier.
Review Comment
This is a case where the AI flags duplicated models generated, which is unexpected. The _1 suffix is auto-generated to resolve a name collision between two distinct models mapped to the same TypeSpec name, which is a sign of duplicated or ambiguously-named models in the spec.
Background
During the SDK release phase, we often receive review comments on public APIs that require the service team to modify the original specification and regenerate the SDK. This frequently leads to multiple rounds of back-and-forth discussions. It would be beneficial to revisit these cases and determine:
Review Comment
This is a case where the AI flags duplicated models generated, which is unexpected. The _1 suffix is auto-generated to resolve a name collision between two distinct models mapped to the same TypeSpec name, which is a sign of duplicated or ambiguously-named models in the spec.
Suggestion
It depends on if we need to generate all models as the same namespace