[eslint] Migrate rules to TypeScript

Rule that were migrated:
no-it-screenshot-only-or-repeat
no-screenshot-test-outside-perf-panel
prefer-url-string
static-custom-event-names

Bug: 397586315
Change-Id: I7e9cc01e01663906ce301a9f2f7021e22305c665
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6450703
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>

Author: Lightning00Blade

scripts/eslint_rules/lib/no-it-screenshot-only-or-repeat.js renamed to scripts/eslint_rules/lib/no-it-screenshot-only-or-repeat.ts

@@ -2,43 +2,46 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-'use strict';
-/**
- * @type {import('eslint').Rule.RuleModule}
- */
-module.exports = {
+import {createRule} from './tsUtils.ts';
+
+type MessageIds = `itScreenshot-${'only'|'repeat'}`;
+
+const BANNED_IT_EXTENSIONS = new Set(['only', 'repeat']);
+
+export default createRule<[], MessageIds>({
+  name: 'no-it-screenshot-only-or-repeat',
   meta: {
     type: 'problem',
-
     docs: {
       description: 'ensure no itScreenshot.only or itScreenshot.repeat calls',
       category: 'Possible Errors',
     },
     messages: {
-      // Formatted like this to make it easily to dynamically look up the
-      // message based on the invalid property name.
       'itScreenshot-only': 'Focused screenshot tests are not allowed.',
       'itScreenshot-repeat': 'Repeated screenshot tests are not allowed.',
     },
-    fixable: 'code',
-    schema: []  // no options
+    schema: [],  // no options
   },
+  defaultOptions: [],
   create: function(context) {
-    const BANNED_IT_EXTENSIONS = new Set(['only', 'repeat']);
     return {
-      'CallExpression[callee.type="MemberExpression"][callee.object.name="itScreenshot"]'(node) {
+      CallExpression(node): void {
+        if (node.callee.type !== 'MemberExpression' || node.callee.object.type !== 'Identifier' ||
+            node.callee.object.name !== 'itScreenshot' || node.callee.property.type !== 'Identifier') {
+          return;
+        }
+
         const calleePropertyName = node.callee.property.name;
         if (!BANNED_IT_EXTENSIONS.has(calleePropertyName)) {
           return;
         }
-        const errorMessageId = `itScreenshot-${calleePropertyName}`;
 
-        // We report the node.callee.property as the bad node so that in an editor
-        // only the ".only" / ".repeat" part is highlighted as an error, else it is very
-        // distracting when you're working on debugging a test and the entire
-        // body of the test is highlighted as an error.
+        // Construct the message ID dynamically and assert its type
+        const errorMessageId = `itScreenshot-${calleePropertyName}` as MessageIds;
+
+        // Report the specific property (.only or .repeat) as the error location
         context.report({node: node.callee.property, messageId: errorMessageId});
-      }
+      },
     };
-  }
-};
+  },
+});

scripts/eslint_rules/lib/no-screenshot-test-outside-perf-panel.js

@@ -0,0 +1,77 @@
+// Copyright 2023 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import * as path from 'path';
+
+import {createRule} from './tsUtils.ts';
+
+const PERFORMANCE_PANEL_INTERACTION_TESTS_PATH = path.join(
+    // @ts-expect-error
+    import.meta.dirname,
+    '..',
+    '..',
+    '..',
+    'test',
+    'interactions',
+    'panels',
+    'performance',
+);
+const UI_COMPONENTS_PATH = path.join(
+    // @ts-expect-error
+    import.meta.dirname,
+    '..',
+    '..',
+    '..',
+    'test',
+    'interactions',
+    'ui',
+    'components',
+);
+
+export default createRule({
+  name: 'no-screenshot-test-outside-perf-panel',
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'Bans writing screenshot tests outside the directory for the Performance Panel interaction tests.',
+      category: 'Possible Errors',
+    },
+    messages: {
+      invalidScreenshotTest:
+          'It is banned to write screenshot tests outside the directory of the Performance Panel interaction tests or UI components tests.',
+    },
+    schema: [],  // no options
+  },
+  defaultOptions: [],
+  create: function(context) {
+    const filename: string = context.filename;
+    const absoluteFileName: string = path.resolve(filename);
+
+    if (absoluteFileName.includes(PERFORMANCE_PANEL_INTERACTION_TESTS_PATH) ||
+        absoluteFileName.includes(UI_COMPONENTS_PATH)) {
+      return {};
+    }
+
+    return {
+      CallExpression(node) {
+        if (node.callee.type === 'Identifier' && node.callee.name === 'itScreenshot') {
+          context.report({
+            node,
+            messageId: 'invalidScreenshotTest',
+          });
+        }
+      },
+
+      MemberExpression(node) {
+        if (node.object.type === 'Identifier' && node.object.name === 'itScreenshot' &&
+            node.property.type === 'Identifier' && (node.property.name === 'skip' || node.property.name === 'only')) {
+          context.report({
+            node,
+            messageId: 'invalidScreenshotTest',
+          });
+        }
+      },
+    };
+  },
+});