IconImage dispose itself without dispose the underlying SKBitmap object

[zhuxb711]

Just set _bitmap into null

FaviconFetcher/FaviconFetcher/Classes/IconImage.cs

Line 72 in 4d02448

_bitmap = null;

If concerning dispose the _bitmap will affect ToSKBitmap().
I suggest to change ToSKBitmap() to:

public SKBitmap ToSKBitmap()
{
    return _bitmap.Copy();
}

or

// Developer should be responsible for disposing an 'Underlying' object which might cause some problems
public SKBitmap GetUnderlyingSKBitmap()
{
    return _bitmap;
}

[kiddailey]

Nice catch, thank you! Would it be simpler to just properly dispose the SKBitmap properly?

Returning a copy of the bitmap could increase memory usage if I'm understanding correctly.

[zhuxb711]

Yes sure, just dispose the underlying _bitmap is ok for this case. SKBitmap should be disposed when IconImage disposing

[zhuxb711]

Will this be fixed in the next release?