From d9d4887d4a7ee8c98d41a1819379032c33cb0067 Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Fri, 12 Dec 2025 16:39:53 -0600 Subject: [PATCH 1/7] Add apm-sdks-benchmarks to CI --- .gitlab-ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index e5738260aa3..0bff96f9558 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -4,12 +4,17 @@ include: - local: ".gitlab/macrobenchmarks.yml" - local: ".gitlab/exploration-tests.yml" - local: ".gitlab/ci-visibility-tests.yml" + - project: 'DataDog/apm-reliability/apm-sdks-benchmarks' + file: '.gitlab/ci-java-spring-petclinic.yml' + ref: 'sarahchen6/compare-with-latest-shared-commit' stages: - build - publish - shared-pipeline - benchmarks + - java-spring-petclinic-tests + - java-spring-petclinic-macrobenchmarks - macrobenchmarks - tests - exploration-tests From 732aefdb28028163bd0c5de8c60c67574a77ab31 Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Fri, 12 Dec 2025 17:02:51 -0600 Subject: [PATCH 2/7] Add thresholds file --- .gitlab/thresholds/java-spring-petclinic.yml | 36 ++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 .gitlab/thresholds/java-spring-petclinic.yml diff --git a/.gitlab/thresholds/java-spring-petclinic.yml b/.gitlab/thresholds/java-spring-petclinic.yml new file mode 100644 index 00000000000..9064e7bd352 --- /dev/null +++ b/.gitlab/thresholds/java-spring-petclinic.yml @@ -0,0 +1,36 @@ +# Thresholds set based on guidance in https://datadoghq.atlassian.net/wiki/x/LgI1LgE#How-to-choose-thresholds-for-pre-release-gates%3F + +experiments: + - name: Run SLO breach check + steps: + - name: SLO breach check + run: fail_on_breach + # https://datadoghq.atlassian.net/wiki/x/LgI1LgE#How-to-choose-a-warning-range-for-pre-release-gates%3F + warning_range: 10 + # File spec + # https://datadoghq.atlassian.net/wiki/x/LgI1LgE#Specification + # Measurements + # https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario + scenarios: + # Note that thresholds there are chosen based the confidence interval with a 10% adjustment. + + # Standard macrobenchmarks + # https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=normal_operation%2Fonly-tracing&trendsType=scenario + - name: normal_operation/only-tracing + thresholds: + - agg_http_req_duration_p50 < 2.6 ms + - agg_http_req_duration_p99 < 8.5 ms + # https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=normal_operation%2Fotel-latest&trendsType=scenario + - name: normal_operation/otel-latest + thresholds: + - agg_http_req_duration_p50 < 2.5 ms + - agg_http_req_duration_p99 < 10 ms + + # https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=high_load%2Fonly-tracing&trendsType=scenario + - name: high_load/only-tracing + thresholds: + - throughput > 1100.0 op/s + # https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=high_load%2Fotel-latest&trendsType=scenario + - name: high_load/otel-latest + thresholds: + - throughput > 1100.0 op/s From 0beddad3001739ff08efe00778c727dd9cf38356 Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Fri, 12 Dec 2025 17:10:19 -0600 Subject: [PATCH 3/7] Empty commit to run benchmarks again From 961090742d827e1574663076274c18a51daf9107 Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Fri, 12 Dec 2025 17:20:11 -0600 Subject: [PATCH 4/7] Empty commit to run benchmarks again From 4fc38a519507cfa2a47c887903dca1ca959b27ce Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Fri, 12 Dec 2025 17:31:04 -0600 Subject: [PATCH 5/7] Empty commit to run benchmarks again From bb85a00c8b998620ad799883d9904d7140a44611 Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Fri, 12 Dec 2025 17:53:16 -0600 Subject: [PATCH 6/7] Empty commit to run benchmarks again From e6573d03d1870483d78de3dd0cf10deb11d1c3d9 Mon Sep 17 00:00:00 2001 From: Sarah Chen Date: Fri, 12 Dec 2025 17:58:20 -0600 Subject: [PATCH 7/7] Empty commit to run benchmarks again