diff --git a/eslint.config.mjs b/eslint.config.mjs index c5a2a2bbe..35bb7ea5c 100644 --- a/eslint.config.mjs +++ b/eslint.config.mjs @@ -97,6 +97,11 @@ export default tseslint.config( rules: { ...recommendedTypeScriptWarnings, "no-restricted-syntax": ["error", noUnboundRxjsOperatorRule], + // GSA/sam-ui-elements#585: promoted to errors once the codebase reached + // zero warnings for these two rules (unused declarations/imports/params + // and never-reassigned `let` bindings are fully cleaned up). + "prefer-const": "error", + "@typescript-eslint/no-unused-vars": "error", }, }, { diff --git a/src/formly/components/autocomplete/autocomplete.component.ts b/src/formly/components/autocomplete/autocomplete.component.ts index 157ebc61a..f35a861ab 100755 --- a/src/formly/components/autocomplete/autocomplete.component.ts +++ b/src/formly/components/autocomplete/autocomplete.component.ts @@ -4,7 +4,7 @@ import { ViewChild, ChangeDetectorRef, } from "@angular/core"; -import { SamAutocompleteComponent, AutocompleteService } from "../../../ui-kit"; +import { SamAutocompleteComponent } from "../../../ui-kit"; import { AbstractSamFormly } from "../../sam-formly"; diff --git a/src/formly/components/autocomplete/test.service.ts b/src/formly/components/autocomplete/test.service.ts index 661f96cf3..d1ae84e63 100755 --- a/src/formly/components/autocomplete/test.service.ts +++ b/src/formly/components/autocomplete/test.service.ts @@ -8,6 +8,7 @@ export class TestAutocompleteService implements AutocompleteService { public setFetchMethod() {} public fetch(val: string): Observable { + void val; return of([ { key: "MD", value: "Maryland", category: "Places" }, { key: "VA", value: "Virginia", category: "Places" }, diff --git a/src/ui-kit/components/accordion/accordion.spec.ts b/src/ui-kit/components/accordion/accordion.spec.ts index 9748953e9..048de3d5f 100755 --- a/src/ui-kit/components/accordion/accordion.spec.ts +++ b/src/ui-kit/components/accordion/accordion.spec.ts @@ -1,7 +1,6 @@ import { waitForAsync, ComponentFixtureAutoDetect, - ComponentFixture, TestBed, } from "@angular/core/testing"; import { Component } from "@angular/core"; @@ -67,11 +66,10 @@ describe("The Sam Accordion component", () => { describe("isolated tests", () => { let component: SamAccordionComponent; let sectionComponent: SamAccordionSection; - let sectionComponent2: SamAccordionSection; beforeEach(() => { component = new SamAccordionComponent(); sectionComponent = new SamAccordionSection(component); - sectionComponent2 = new SamAccordionSection(component); + new SamAccordionSection(component); }); // section it('should check for "name" prop and throw error', () => { @@ -79,7 +77,7 @@ describe("The Sam Accordion component", () => { sectionComponent.ngOnInit(); // shouldn't get here expect(false).toBe(true); - } catch (e) { + } catch { expect(true).toBe(true); } }); diff --git a/src/ui-kit/components/actions/action-button/action-button.component.ts b/src/ui-kit/components/actions/action-button/action-button.component.ts index 2f12fb74a..cdf0aca3b 100755 --- a/src/ui-kit/components/actions/action-button/action-button.component.ts +++ b/src/ui-kit/components/actions/action-button/action-button.component.ts @@ -1,4 +1,4 @@ -import { Component, Input, Output, EventEmitter, OnInit } from "@angular/core"; +import { Component, Input, Output, EventEmitter } from "@angular/core"; import { SamActionInterface } from "../action-interface"; @Component({ diff --git a/src/ui-kit/components/actions/actions-dropdown/actions-dropdown.component.ts b/src/ui-kit/components/actions/actions-dropdown/actions-dropdown.component.ts index e55bb8246..2a9b72dfa 100755 --- a/src/ui-kit/components/actions/actions-dropdown/actions-dropdown.component.ts +++ b/src/ui-kit/components/actions/actions-dropdown/actions-dropdown.component.ts @@ -4,7 +4,6 @@ import { Output, EventEmitter, ViewChild, - ElementRef, ViewChildren, } from "@angular/core"; @@ -55,7 +54,8 @@ export class SamActionsDropdownComponent { showActions = false; focusIndex = -1; - hideActions(event) { + hideActions(event: Event) { + void event; return (this.showActions = false); } @@ -88,7 +88,7 @@ export class SamActionsDropdownComponent { } setFocusOnFirstItem() { - this.actionsList.changes.subscribe((t) => { + this.actionsList.changes.subscribe(() => { this.ngForRendered(); }); } diff --git a/src/ui-kit/components/alert-footer/alert-footer.service.ts b/src/ui-kit/components/alert-footer/alert-footer.service.ts index 4a06beffe..32c147aee 100755 --- a/src/ui-kit/components/alert-footer/alert-footer.service.ts +++ b/src/ui-kit/components/alert-footer/alert-footer.service.ts @@ -1,4 +1,4 @@ -import { Component, Injectable } from "@angular/core"; +import { Injectable } from "@angular/core"; import { AlertType } from "../../types"; @Injectable() export class SamAlertFooterService { diff --git a/src/ui-kit/components/alert-footer/alert-footer.spec.ts b/src/ui-kit/components/alert-footer/alert-footer.spec.ts index 688bfa2f4..c90f5acb6 100755 --- a/src/ui-kit/components/alert-footer/alert-footer.spec.ts +++ b/src/ui-kit/components/alert-footer/alert-footer.spec.ts @@ -1,6 +1,4 @@ import { TestBed, inject } from "@angular/core/testing"; -import { Observable } from "rxjs"; -import { By } from "@angular/platform-browser"; // Load the implementations that should be tested import { SamAlertFooterComponent, SamAlertFooterService } from "./index"; @@ -8,11 +6,10 @@ import { SamAlertComponent } from "../alert/alert.component"; describe("The AlertFooter component", () => { describe("isolated tests", () => { - let component: SamAlertFooterComponent; let service: SamAlertFooterService; beforeEach(() => { service = new SamAlertFooterService(); - component = new SamAlertFooterComponent(service); + new SamAlertFooterComponent(service); service.registerFooterAlert({ description: "hello", title: "alert title", diff --git a/src/ui-kit/components/alert/alert.spec.ts b/src/ui-kit/components/alert/alert.spec.ts index 967b1c0f1..88460c49f 100755 --- a/src/ui-kit/components/alert/alert.spec.ts +++ b/src/ui-kit/components/alert/alert.spec.ts @@ -1,7 +1,6 @@ import { TestBed } from "@angular/core/testing"; import { RouterTestingModule } from "@angular/router/testing"; import { By } from "@angular/platform-browser"; -import { SimpleChanges } from "@angular/core"; // Load the implementations that should be tested import { SamAlertComponent } from "./alert.component"; diff --git a/src/ui-kit/components/banner/banner.spec.ts b/src/ui-kit/components/banner/banner.spec.ts index 327277aab..916e708df 100755 --- a/src/ui-kit/components/banner/banner.spec.ts +++ b/src/ui-kit/components/banner/banner.spec.ts @@ -1,5 +1,4 @@ import { TestBed } from "@angular/core/testing"; -import { By } from "@angular/platform-browser"; // Load the implementations that should be tested import { SamBannerComponent } from "./banner.component"; diff --git a/src/ui-kit/components/breadcrumbs/breadcrumbs.component.ts b/src/ui-kit/components/breadcrumbs/breadcrumbs.component.ts index 5ac80beaf..c8305ffc8 100755 --- a/src/ui-kit/components/breadcrumbs/breadcrumbs.component.ts +++ b/src/ui-kit/components/breadcrumbs/breadcrumbs.component.ts @@ -1,5 +1,4 @@ import { Component, Input, Output, EventEmitter } from "@angular/core"; -import { NavigationEnd, UrlSegment } from "@angular/router"; import { IBreadcrumb } from "../../types"; @Component({ diff --git a/src/ui-kit/components/breadcrumbs/breadcrumbs.spec.ts b/src/ui-kit/components/breadcrumbs/breadcrumbs.spec.ts index 74e229176..ba1ed52d9 100755 --- a/src/ui-kit/components/breadcrumbs/breadcrumbs.spec.ts +++ b/src/ui-kit/components/breadcrumbs/breadcrumbs.spec.ts @@ -1,8 +1,6 @@ import { TestBed } from "@angular/core/testing"; import { By } from "@angular/platform-browser"; import { RouterTestingModule } from "@angular/router/testing"; -import { Observable, Subject } from "rxjs"; -import { ActivatedRoute } from "@angular/router"; // Load the implementations that should be tested import { SamBreadcrumbsComponent } from "./breadcrumbs.component"; diff --git a/src/ui-kit/components/comments/comment/comment.component.ts b/src/ui-kit/components/comments/comment/comment.component.ts index a7bcd2a35..59e38881f 100755 --- a/src/ui-kit/components/comments/comment/comment.component.ts +++ b/src/ui-kit/components/comments/comment/comment.component.ts @@ -21,7 +21,7 @@ export class SamCommentComponent { */ @Output() delete: EventEmitter = new EventEmitter(); - emitClick(comment: Event) { + emitClick() { this.delete.emit(this.comment); } } diff --git a/src/ui-kit/components/comments/comment/comment.spec.ts b/src/ui-kit/components/comments/comment/comment.spec.ts index d4eb5205b..1229b4099 100755 --- a/src/ui-kit/components/comments/comment/comment.spec.ts +++ b/src/ui-kit/components/comments/comment/comment.spec.ts @@ -1,5 +1,4 @@ import { TestBed } from "@angular/core/testing"; -import { CommonModule } from "@angular/common"; import moment from "moment"; import { By } from "@angular/platform-browser"; diff --git a/src/ui-kit/components/comments/comments.component.ts b/src/ui-kit/components/comments/comments.component.ts index f8e94fe75..85725502e 100755 --- a/src/ui-kit/components/comments/comments.component.ts +++ b/src/ui-kit/components/comments/comments.component.ts @@ -2,17 +2,11 @@ import { Component, Input, OnInit, - Optional, ViewChild, ElementRef, OnDestroy, } from "@angular/core"; -import { - FormBuilder, - FormGroup, - Validators, - ControlValueAccessor, -} from "@angular/forms"; +import { FormBuilder, FormGroup, Validators } from "@angular/forms"; import { Observable, Subscription, Subject, of, fromEvent } from "rxjs"; import { flatMap, catchError, merge } from "rxjs/operators"; @@ -103,7 +97,7 @@ export class SamCommentsComponent implements OnInit, OnDestroy { // Map DOM events to actions this.getCommentsStream = this.showButtonStream.pipe( - flatMap((event) => { + flatMap(() => { return this.commentsService .getComments() .pipe(catchError((error) => of(error))); @@ -111,7 +105,7 @@ export class SamCommentsComponent implements OnInit, OnDestroy { ); this.collapseCommentsStream = this.hideCommentsStream.pipe( - flatMap((event) => { + flatMap(() => { return this.commentsService .getInitialState() .pipe(catchError((error) => of(error))); diff --git a/src/ui-kit/components/comments/comments.module.ts b/src/ui-kit/components/comments/comments.module.ts index 3a9f6ee75..cf87eff67 100755 --- a/src/ui-kit/components/comments/comments.module.ts +++ b/src/ui-kit/components/comments/comments.module.ts @@ -4,7 +4,6 @@ import { FormsModule, ReactiveFormsModule } from "@angular/forms"; import { SamCommentsComponent } from "./comments.component"; import { SamCommentComponent } from "./comment"; -import { CommentsService } from "./comments.service"; import { SamPipesModule } from "../../pipes"; import { SamTextAreaModule } from "../../form-controls/textarea"; diff --git a/src/ui-kit/components/comments/comments.service.ts b/src/ui-kit/components/comments/comments.service.ts index 057777de1..952a4f643 100755 --- a/src/ui-kit/components/comments/comments.service.ts +++ b/src/ui-kit/components/comments/comments.service.ts @@ -12,6 +12,7 @@ export class CommentsService { } isCommentDeletable(comment: Comment): boolean { + void comment; return true; } @@ -23,11 +24,13 @@ export class CommentsService { return of(this._comments); } - postComment(_: any): Observable { + postComment(comment: Comment): Observable { + void comment; return of(this._comments); } deleteComment(comment: Comment): Observable { + void comment; return of(this._comments); } diff --git a/src/ui-kit/components/comments/comments.spec.ts b/src/ui-kit/components/comments/comments.spec.ts index f46c3baeb..181b4a082 100755 --- a/src/ui-kit/components/comments/comments.spec.ts +++ b/src/ui-kit/components/comments/comments.spec.ts @@ -9,7 +9,6 @@ import { CommentsService, Comment, } from "./"; -import { SamPipesModule } from "../../pipes"; import { Observable, of, throwError } from "rxjs"; @@ -88,7 +87,7 @@ export class CommentsDemoService implements CommentsService { return this._disabled; } - isCommentDeletable(comment: Comment): boolean { + isCommentDeletable(): boolean { return true; } @@ -126,11 +125,10 @@ export class CommentsDemoService implements CommentsService { describe("The Sam Comments component", () => { describe("isolated tests", () => { - let component: SamCommentsComponent; let service: CommentsService; beforeEach(() => { service = new CommentsService(); - component = new SamCommentsComponent(service, undefined); + new SamCommentsComponent(service, undefined); }); // service it("service should tell us if commenting is disabled", () => { diff --git a/src/ui-kit/components/data-table/data-source.sample.spec.ts b/src/ui-kit/components/data-table/data-source.sample.spec.ts index 5918b45c6..e27374e08 100755 --- a/src/ui-kit/components/data-table/data-source.sample.spec.ts +++ b/src/ui-kit/components/data-table/data-source.sample.spec.ts @@ -2,7 +2,6 @@ import { SamSortable, SamSortDirective } from "./"; import { merge } from "rxjs"; import { map } from "rxjs/operators"; import { DataSource } from "@angular/cdk/collections"; -import { fromEvent } from "rxjs"; import { RECORDS } from "./data.sample.spec"; import { BehaviorSubject } from "rxjs"; /* tslint:disable */ diff --git a/src/ui-kit/components/data-table/data-table.component.ts b/src/ui-kit/components/data-table/data-table.component.ts index db6509d1e..1d1faef6c 100755 --- a/src/ui-kit/components/data-table/data-table.component.ts +++ b/src/ui-kit/components/data-table/data-table.component.ts @@ -6,15 +6,10 @@ import { Input, OnChanges, } from "@angular/core"; -import { - CdkTable, - STICKY_POSITIONING_LISTENER, - CDK_TABLE, -} from "@angular/cdk/table"; +import { CdkTable, CDK_TABLE } from "@angular/cdk/table"; import { _DisposeViewRepeaterStrategy, - _RecycleViewRepeaterStrategy, _VIEW_REPEATER_STRATEGY, } from "@angular/cdk/collections"; @@ -83,9 +78,3 @@ export class SamDataTableComponent } } } -function Directive(arg0: { - selector: string; - providers: { provide: any; useClass: any }[]; -}) { - throw new Error("Function not implemented."); -} diff --git a/src/ui-kit/components/download/download.spec.ts b/src/ui-kit/components/download/download.spec.ts index 66778492c..361746653 100755 --- a/src/ui-kit/components/download/download.spec.ts +++ b/src/ui-kit/components/download/download.spec.ts @@ -1,7 +1,6 @@ import { TestBed, ComponentFixture } from "@angular/core/testing"; import { By } from "@angular/platform-browser"; import { BrowserAnimationsModule } from "@angular/platform-browser/animations"; -import { DebugElement } from "@angular/core"; import { AccessType, ExpansionType } from "../../types"; import { SamDownloadComponent } from "./download.component"; diff --git a/src/ui-kit/components/footer-next/footer-nav-item.component.ts b/src/ui-kit/components/footer-next/footer-nav-item.component.ts index 26d27d1f4..5d916ba3e 100755 --- a/src/ui-kit/components/footer-next/footer-nav-item.component.ts +++ b/src/ui-kit/components/footer-next/footer-nav-item.component.ts @@ -1,4 +1,4 @@ -import { Component, Host } from "@angular/core"; +import { Component } from "@angular/core"; @Component({ selector: "sam-footer-nav-item", diff --git a/src/ui-kit/components/header-next/header.component.ts b/src/ui-kit/components/header-next/header.component.ts index 133038a52..764b1b1ec 100755 --- a/src/ui-kit/components/header-next/header.component.ts +++ b/src/ui-kit/components/header-next/header.component.ts @@ -31,7 +31,7 @@ export class SamHeaderNextComponent { // we know the user's viewport has been resized to be larger. // Let's make the page state consistent by deactivating the mobile nav. @HostListener("window:resize", ["$event"]) - onBrowserResize(event) { + onBrowserResize() { if ( this.mobileNavActive && this.closeNavBtn.nativeElement.getBoundingClientRect().width === 0 diff --git a/src/ui-kit/components/header/header.component.spec.ts b/src/ui-kit/components/header/header.component.spec.ts index 1ea7223fa..9e8e8ad67 100755 --- a/src/ui-kit/components/header/header.component.spec.ts +++ b/src/ui-kit/components/header/header.component.spec.ts @@ -21,7 +21,6 @@ describe("The Sam Header component", () => { }); describe("rendered test", () => { - let component: SamHeaderComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -31,7 +30,6 @@ describe("The Sam Header component", () => { declarations: [SamHeaderComponent], }); fixture = TestBed.createComponent(SamHeaderComponent); - component = fixture.componentInstance; }); it("should compile", function () { diff --git a/src/ui-kit/components/history/history.spec.ts b/src/ui-kit/components/history/history.spec.ts index e8965842b..155e71909 100755 --- a/src/ui-kit/components/history/history.spec.ts +++ b/src/ui-kit/components/history/history.spec.ts @@ -1,4 +1,4 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { By } from "@angular/platform-browser"; import { RouterTestingModule } from "@angular/router/testing"; diff --git a/src/ui-kit/components/image/image.component.ts b/src/ui-kit/components/image/image.component.ts index 625f04c90..d34bc250f 100755 --- a/src/ui-kit/components/image/image.component.ts +++ b/src/ui-kit/components/image/image.component.ts @@ -74,7 +74,7 @@ export class SamImageComponent implements OnInit { this.editModeSubscription = this.editButtonStream .pipe(merge(this.cancelButtonStream), merge(this.saveButtonStream)) .subscribe( - (event) => { + () => { if (this.editable) { this.toggleEdit(); } @@ -85,7 +85,7 @@ export class SamImageComponent implements OnInit { ); this.cancelButtonSubscription = this.cancelButtonStream.subscribe( - (event) => { + () => { this.tmpValue = undefined; this.tmpSrc = undefined; }, @@ -95,7 +95,7 @@ export class SamImageComponent implements OnInit { ); this.saveButtonSubscription = this.saveButtonStream.subscribe( - (event) => { + () => { if (this.isImageTemporary()) { this.value = this.tmpValue; this.src = this.tmpSrc; diff --git a/src/ui-kit/components/multiselect-dropdown/multiselect-dropdown.spec.ts b/src/ui-kit/components/multiselect-dropdown/multiselect-dropdown.spec.ts index e24fea318..25ca77274 100755 --- a/src/ui-kit/components/multiselect-dropdown/multiselect-dropdown.spec.ts +++ b/src/ui-kit/components/multiselect-dropdown/multiselect-dropdown.spec.ts @@ -1,7 +1,6 @@ import { TestBed } from "@angular/core/testing"; import { SamMultiSelectDropdownComponent } from "./multiselect-dropdown.component"; -import { SamUIKitModule } from "../../index"; import { SamFormControlsModule } from "../../form-controls"; import { SamFormService } from "../../form-service"; diff --git a/src/ui-kit/components/page-title/page-title.component.ts b/src/ui-kit/components/page-title/page-title.component.ts index a846a29e8..5bf13d67c 100755 --- a/src/ui-kit/components/page-title/page-title.component.ts +++ b/src/ui-kit/components/page-title/page-title.component.ts @@ -1,4 +1,4 @@ -import { Component, Input, HostBinding } from "@angular/core"; +import { Component, Input } from "@angular/core"; @Component({ selector: "sam-page-title", diff --git a/src/ui-kit/components/pagination/pagination.spec.ts b/src/ui-kit/components/pagination/pagination.spec.ts index eb522de3a..afbeddcfe 100755 --- a/src/ui-kit/components/pagination/pagination.spec.ts +++ b/src/ui-kit/components/pagination/pagination.spec.ts @@ -1,4 +1,4 @@ -import { TestBed, waitForAsync, fakeAsync, tick } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { By } from "@angular/platform-browser"; diff --git a/src/ui-kit/components/point-of-contact/point-of-contact.spec.ts b/src/ui-kit/components/point-of-contact/point-of-contact.spec.ts index 5621939c0..b5a3c6d5f 100755 --- a/src/ui-kit/components/point-of-contact/point-of-contact.spec.ts +++ b/src/ui-kit/components/point-of-contact/point-of-contact.spec.ts @@ -1,4 +1,4 @@ -import { TestBed, waitForAsync, fakeAsync, tick } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { By } from "@angular/platform-browser"; diff --git a/src/ui-kit/components/sidenav/menu-item/menu-item.spec.ts b/src/ui-kit/components/sidenav/menu-item/menu-item.spec.ts index 97fccf3bd..c4a08a7ba 100755 --- a/src/ui-kit/components/sidenav/menu-item/menu-item.spec.ts +++ b/src/ui-kit/components/sidenav/menu-item/menu-item.spec.ts @@ -1,12 +1,8 @@ -import { TestBed, ComponentFixture } from "@angular/core/testing"; -import { By } from "@angular/platform-browser"; -import { EventEmitter, ElementRef, Injectable } from "@angular/core"; -import { Observable } from "rxjs"; +import { TestBed } from "@angular/core/testing"; import { SamMenuItemComponent } from "./"; import { SamSidenavModule } from "../"; import { SidenavService } from "../services"; -import { SamUIKitModule } from "../../../index"; import { data } from "../services/testdata"; @@ -43,7 +39,6 @@ describe("The Sam MenuItem component", () => { }); }); describe("rendered tests", () => { - let component: SamMenuItemComponent; let fixture: any; beforeEach(() => { @@ -52,7 +47,6 @@ describe("The Sam MenuItem component", () => { }); fixture = TestBed.createComponent(SamMenuItemComponent); - component = fixture.componentInstance; }); it("should compile", function () { diff --git a/src/ui-kit/components/sidenav/services/sidenav.service.ts b/src/ui-kit/components/sidenav/services/sidenav.service.ts index d2c56a1de..80dbdf42b 100755 --- a/src/ui-kit/components/sidenav/services/sidenav.service.ts +++ b/src/ui-kit/components/sidenav/services/sidenav.service.ts @@ -1,5 +1,4 @@ import { Injectable } from "@angular/core"; -import { Observable } from "rxjs"; @Injectable() export class SidenavService { diff --git a/src/ui-kit/components/sidenav/sidenav/sidenav.spec.ts b/src/ui-kit/components/sidenav/sidenav/sidenav.spec.ts index 8785152c0..37e921526 100755 --- a/src/ui-kit/components/sidenav/sidenav/sidenav.spec.ts +++ b/src/ui-kit/components/sidenav/sidenav/sidenav.spec.ts @@ -1,11 +1,8 @@ -import { TestBed, ComponentFixture } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { By } from "@angular/platform-browser"; -import { EventEmitter, ElementRef, Injectable } from "@angular/core"; -import { Observable } from "rxjs"; import { SamSidenavModule, SamSidenavComponent } from "./"; import { SidenavService } from "../services"; -import { SamUIKitModule } from "../../../index"; import { data } from "../services/testdata"; diff --git a/src/ui-kit/components/spinner/spinner.spec.ts b/src/ui-kit/components/spinner/spinner.spec.ts index a701c2451..f7adcc0b5 100755 --- a/src/ui-kit/components/spinner/spinner.spec.ts +++ b/src/ui-kit/components/spinner/spinner.spec.ts @@ -2,16 +2,12 @@ import { TestBed } from "@angular/core/testing"; import { SamSpinnerComponent } from "./spinner.component"; describe("The Sam Spinner", () => { - let component: SamSpinnerComponent; - let fixture: any; - beforeEach(() => { TestBed.configureTestingModule({ declarations: [SamSpinnerComponent], }); - fixture = TestBed.createComponent(SamSpinnerComponent); - component = fixture.componentInstance; + TestBed.createComponent(SamSpinnerComponent); }); it("should compile", function () { diff --git a/src/ui-kit/directives/click-outside/click-outside.spec.ts b/src/ui-kit/directives/click-outside/click-outside.spec.ts index 990a7e5c1..883e5d64b 100755 --- a/src/ui-kit/directives/click-outside/click-outside.spec.ts +++ b/src/ui-kit/directives/click-outside/click-outside.spec.ts @@ -1,10 +1,4 @@ -import { - TestBed, - waitForAsync, - fakeAsync, - tick, - ComponentFixture, -} from "@angular/core/testing"; +import { TestBed, ComponentFixture } from "@angular/core/testing"; import { Component, Output, ViewChild, EventEmitter } from "@angular/core"; import { By } from "@angular/platform-browser"; @@ -29,7 +23,6 @@ class TestComponent { } } describe("The Sam Click Outside directive", () => { - let directive: SamClickOutsideDirective; let component: TestComponent; let fixture: ComponentFixture; @@ -41,9 +34,6 @@ describe("The Sam Click Outside directive", () => { fixture = TestBed.createComponent(TestComponent); component = fixture.componentInstance; fixture.detectChanges(); - directive = fixture.debugElement - .query(By.directive(SamClickOutsideDirective)) - .injector.get(SamClickOutsideDirective); }); it("should compile", () => { diff --git a/src/ui-kit/directives/drag-drop/drag-drop.directive.ts b/src/ui-kit/directives/drag-drop/drag-drop.directive.ts index 2b93c18c1..8d2ad27ee 100755 --- a/src/ui-kit/directives/drag-drop/drag-drop.directive.ts +++ b/src/ui-kit/directives/drag-drop/drag-drop.directive.ts @@ -89,7 +89,8 @@ export class SamDragDropDirective { } @HostListener("dragleave", ["$event"]) - public onElementDragend(event) { + public onElementDragend(event: DragEvent) { + void event; this._updateDragState(DragState.NotDragging); } diff --git a/src/ui-kit/directives/external-link/external-link.spec.ts b/src/ui-kit/directives/external-link/external-link.spec.ts index d2db093c5..54966a5d9 100755 --- a/src/ui-kit/directives/external-link/external-link.spec.ts +++ b/src/ui-kit/directives/external-link/external-link.spec.ts @@ -1,18 +1,6 @@ -import { - TestBed, - waitForAsync, - fakeAsync, - tick, - ComponentFixture, -} from "@angular/core/testing"; - -import { - Component, - Output, - ViewChild, - EventEmitter, - DebugElement, -} from "@angular/core"; +import { TestBed, ComponentFixture } from "@angular/core/testing"; + +import { Component } from "@angular/core"; import { By } from "@angular/platform-browser"; // Load the implementations that should be tested @@ -34,8 +22,6 @@ import { SamExternalLinkDirective } from "./external-link.directive"; class TestComponent {} describe("Sam External Link Directive", () => { - let directive: SamExternalLinkDirective; - let component: TestComponent; let fixture: ComponentFixture; function findIcons(el) { @@ -48,7 +34,6 @@ describe("Sam External Link Directive", () => { }); fixture = TestBed.createComponent(TestComponent); - component = fixture.componentInstance; fixture.detectChanges(); }); diff --git a/src/ui-kit/directives/focus/focus.spec.ts b/src/ui-kit/directives/focus/focus.spec.ts index b68ca6ee6..45d51809e 100755 --- a/src/ui-kit/directives/focus/focus.spec.ts +++ b/src/ui-kit/directives/focus/focus.spec.ts @@ -1,10 +1,4 @@ -import { - TestBed, - waitForAsync, - fakeAsync, - tick, - ComponentFixture, -} from "@angular/core/testing"; +import { TestBed, ComponentFixture } from "@angular/core/testing"; import { Component, Output, ViewChild, EventEmitter } from "@angular/core"; import { By } from "@angular/platform-browser"; @@ -30,7 +24,6 @@ class TestComponent { } } describe("The Sam Focus directive", () => { - let directive: SamFocusDirective; let component: TestComponent; let fixture: ComponentFixture; @@ -42,9 +35,6 @@ describe("The Sam Focus directive", () => { fixture = TestBed.createComponent(TestComponent); component = fixture.componentInstance; fixture.detectChanges(); - directive = fixture.debugElement - .query(By.directive(SamFocusDirective)) - .injector.get(SamFocusDirective); }); it("should compile", () => { diff --git a/src/ui-kit/directives/sticky/sticky.component.ts b/src/ui-kit/directives/sticky/sticky.component.ts index bca86f1a2..2e7551698 100755 --- a/src/ui-kit/directives/sticky/sticky.component.ts +++ b/src/ui-kit/directives/sticky/sticky.component.ts @@ -40,7 +40,8 @@ export class SamStickyComponent implements OnInit, AfterViewChecked { private elemWidth: number; @HostListener("window:resize", ["$event"]) - resize(event: Event): void { + resize(event?: Event) { + void event; // Set element to initial styles // to help finding the initial element width this.el.nativeElement.style.position = "static"; @@ -51,7 +52,8 @@ export class SamStickyComponent implements OnInit, AfterViewChecked { } @HostListener("window:scroll", ["$event"]) - scroll(event: Event): void { + scroll(event?: Event) { + void event; this.makeSticky(); } diff --git a/src/ui-kit/directives/sticky/sticky.spec.ts b/src/ui-kit/directives/sticky/sticky.spec.ts index 4ddc7fbc0..aafe6358f 100755 --- a/src/ui-kit/directives/sticky/sticky.spec.ts +++ b/src/ui-kit/directives/sticky/sticky.spec.ts @@ -1,10 +1,4 @@ -import { - TestBed, - waitForAsync, - fakeAsync, - tick, - ComponentFixture, -} from "@angular/core/testing"; +import { TestBed, ComponentFixture } from "@angular/core/testing"; import { Component, ViewChild } from "@angular/core"; import { By } from "@angular/platform-browser"; @@ -38,7 +32,6 @@ class TestComponent { describe("The Sam Sticky directive", () => { let directive: SamStickyComponent; - let component: TestComponent; let fixture: ComponentFixture; beforeEach(() => { @@ -47,7 +40,6 @@ describe("The Sam Sticky directive", () => { }); fixture = TestBed.createComponent(TestComponent); - component = fixture.componentInstance; fixture.detectChanges(); directive = fixture.debugElement .query(By.directive(SamStickyComponent)) diff --git a/src/ui-kit/directives/tab-outside/taboutside.spec.ts b/src/ui-kit/directives/tab-outside/taboutside.spec.ts index b917474ab..902653751 100755 --- a/src/ui-kit/directives/tab-outside/taboutside.spec.ts +++ b/src/ui-kit/directives/tab-outside/taboutside.spec.ts @@ -1,10 +1,4 @@ -import { - TestBed, - waitForAsync, - fakeAsync, - tick, - ComponentFixture, -} from "@angular/core/testing"; +import { TestBed, ComponentFixture } from "@angular/core/testing"; import { Component, Output, ViewChild, EventEmitter } from "@angular/core"; import { By } from "@angular/platform-browser"; diff --git a/src/ui-kit/elements/button/button.spec.ts b/src/ui-kit/elements/button/button.spec.ts index ab1810a63..1d36c27c9 100755 --- a/src/ui-kit/elements/button/button.spec.ts +++ b/src/ui-kit/elements/button/button.spec.ts @@ -1,4 +1,4 @@ -import { TestBed, waitForAsync, ComponentFixture } from "@angular/core/testing"; +import { TestBed, ComponentFixture } from "@angular/core/testing"; import { By } from "@angular/platform-browser"; diff --git a/src/ui-kit/experimental/alert/alert.component.ts b/src/ui-kit/experimental/alert/alert.component.ts index 1e8a74888..e1346510d 100755 --- a/src/ui-kit/experimental/alert/alert.component.ts +++ b/src/ui-kit/experimental/alert/alert.component.ts @@ -1,4 +1,4 @@ -import { Component, Input, Output, EventEmitter, OnInit } from "@angular/core"; +import { Component, Input, OnInit } from "@angular/core"; import { faExclamationCircle, faInfoCircle, diff --git a/src/ui-kit/experimental/aria/abstract-combobox/abstract-combobox.ts b/src/ui-kit/experimental/aria/abstract-combobox/abstract-combobox.ts index 3689a0866..6debe88ce 100755 --- a/src/ui-kit/experimental/aria/abstract-combobox/abstract-combobox.ts +++ b/src/ui-kit/experimental/aria/abstract-combobox/abstract-combobox.ts @@ -1,6 +1,5 @@ import { AbstractCell } from "../abstract-grid/abstract-cell"; import { EventDispatcher } from "../utils/events"; -import { AbstractGrid } from "../abstract-grid/abstract-grid"; interface AbstractPopup { onClick: (callback: Function, context: object) => void; @@ -49,7 +48,6 @@ export class AbstractCombobox { } private _setAriaValues() { - const inputId = this._input.id; const popupId = this._popup.node.id; const activeCell = this._popup.getSelected().node.id; this._input.setAttribute("aria-autocomplete", "list"); @@ -73,11 +71,11 @@ export class AbstractCombobox { this._handleKeydown(e); }); - this._input.addEventListener("focus", (e) => { + this._input.addEventListener("focus", () => { this._popup.getSelected().addToTabOrder(); }); - this._input.addEventListener("blur", (e) => { + this._input.addEventListener("blur", () => { this._popup.getSelected().removeFromTabOrder(); }); } @@ -116,7 +114,7 @@ export class AbstractCombobox { } private _setupPopupEvents(): void { - this._popup.onClick(function handleClick(e) { + this._popup.onClick(function handleClick() { this._onChange(); }, this); } diff --git a/src/ui-kit/experimental/aria/abstract-grid/abstract-grid.ts b/src/ui-kit/experimental/aria/abstract-grid/abstract-grid.ts index c6b3e95cc..ce7dcd77a 100755 --- a/src/ui-kit/experimental/aria/abstract-grid/abstract-grid.ts +++ b/src/ui-kit/experimental/aria/abstract-grid/abstract-grid.ts @@ -92,7 +92,7 @@ export class AbstractGrid { subtree: true, }; - const cb = (mutations) => { + const cb = () => { this._rows = []; this.focused = undefined; this._main(element); @@ -144,7 +144,7 @@ export class AbstractGrid { this._dispatcher.disconnect("click", this._handleCellClick); - const [cb, ctx] = this._onClickHandler; + const [cb] = this._onClickHandler; if (cb) { this._dispatcher.disconnect("click", cb); } diff --git a/src/ui-kit/experimental/aria/utils/events.ts b/src/ui-kit/experimental/aria/utils/events.ts index ffff1f806..3be3e56d7 100755 --- a/src/ui-kit/experimental/aria/utils/events.ts +++ b/src/ui-kit/experimental/aria/utils/events.ts @@ -30,7 +30,7 @@ export class EventDispatcher { const name1 = callback.name; this._listeners[event] = this._listeners[event].filter((listener) => { - const [cb, context] = listener; + const [cb] = listener; const name2 = cb.name; if (name2 && name1 !== name2) { return listener; @@ -72,7 +72,7 @@ export class EventDispatcher { const name1 = callback.name; return this._listeners[event].reduce((bool, ls) => { - const [cb, ctx] = ls; + const [cb] = ls; const name2 = cb.name; if (name1 && name2 && name1 === name2) { diff --git a/src/ui-kit/experimental/date-range-v2/date-range-v2.component.spec.ts b/src/ui-kit/experimental/date-range-v2/date-range-v2.component.spec.ts index c1399c7ec..e865d9da2 100755 --- a/src/ui-kit/experimental/date-range-v2/date-range-v2.component.spec.ts +++ b/src/ui-kit/experimental/date-range-v2/date-range-v2.component.spec.ts @@ -1,12 +1,10 @@ -import { waitForAsync, ComponentFixture, TestBed } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; -import { NgModule } from "@angular/core"; import { SamWrapperModule } from "../../../ui-kit/wrappers"; import { SamDateRangeV2Component } from "./date-range-v2.component"; import { DatepickerComponent } from "./datepicker/picker.component"; import { SamInputMaskModule } from "../../experimental/input-mask"; import { FormsModule, ReactiveFormsModule } from "@angular/forms"; -import { ChangeDetectorRef, Renderer2, ElementRef } from "@angular/core"; import { SamFormService } from "../../../ui-kit/form-service"; import { CommonModule } from "@angular/common"; diff --git a/src/ui-kit/experimental/date-range-v2/date-range-v2.component.ts b/src/ui-kit/experimental/date-range-v2/date-range-v2.component.ts index 5ba4b7451..6ef22cef8 100755 --- a/src/ui-kit/experimental/date-range-v2/date-range-v2.component.ts +++ b/src/ui-kit/experimental/date-range-v2/date-range-v2.component.ts @@ -1,12 +1,4 @@ -import { - Component, - OnInit, - Input, - Output, - EventEmitter, - forwardRef, - ViewChild, -} from "@angular/core"; +import { Component, OnInit, Input, forwardRef, ViewChild } from "@angular/core"; import { ControlValueAccessor, @@ -98,7 +90,7 @@ export class SamDateRangeV2Component implements OnInit, ControlValueAccessor { this.onChange(this.model); this.onTouched(); } - onChange: any = (c) => undefined; + onChange: any = () => undefined; onTouched: any = () => undefined; ngOnInit() { diff --git a/src/ui-kit/experimental/date-range-v2/datepicker/calendar.spec.ts b/src/ui-kit/experimental/date-range-v2/datepicker/calendar.spec.ts index 671ae7ff4..d1e1baedf 100755 --- a/src/ui-kit/experimental/date-range-v2/datepicker/calendar.spec.ts +++ b/src/ui-kit/experimental/date-range-v2/datepicker/calendar.spec.ts @@ -1,6 +1,4 @@ -import { TestBed } from "@angular/core/testing"; import { Calendar } from "./calendar"; -import { By } from "@angular/platform-browser"; describe("The calendar class", () => { describe("isolated tests", () => { diff --git a/src/ui-kit/experimental/hierarchical/autocomplete/autocomplete.component.ts b/src/ui-kit/experimental/hierarchical/autocomplete/autocomplete.component.ts index caf358cd0..035f39a95 100755 --- a/src/ui-kit/experimental/hierarchical/autocomplete/autocomplete.component.ts +++ b/src/ui-kit/experimental/hierarchical/autocomplete/autocomplete.component.ts @@ -6,11 +6,7 @@ import { ElementRef, forwardRef, } from "@angular/core"; -import { - NG_VALUE_ACCESSOR, - ControlValueAccessor, - FormControl, -} from "@angular/forms"; +import { NG_VALUE_ACCESSOR, ControlValueAccessor } from "@angular/forms"; import { SamHiercarchicalServiceInterface } from "../hierarchical-interface"; import { KeyHelper, KEYS } from "../../../utilities/key-helper/key-helper"; import { @@ -117,7 +113,7 @@ export class SamHierarchicalAutocompleteComponent implements ControlValueAccesso /** * Stored Event for ControlValueAccessor */ - private propogateChange: (_: any) => void = (_: any) => null; + private propogateChange: (_val: any) => void = () => null; @Input() public disabled: boolean; @@ -144,7 +140,8 @@ export class SamHierarchicalAutocompleteComponent implements ControlValueAccesso * * @param event */ - checkForFocus(event): void { + checkForFocus(event?: Event): void { + void event; this.focusRemoved(); this.showResults = false; } @@ -263,7 +260,7 @@ export class SamHierarchicalAutocompleteComponent implements ControlValueAccesso if (this.inputValue.length !== 0) { let foundItem = false; if (this.results) { - for (var i = 0; i < this.results.length && !foundItem; i++) { + for (let i = 0; i < this.results.length && !foundItem; i++) { const item = this.results[i]; foundItem = item[this.configuration.primaryTextField] === this.inputValue; @@ -271,7 +268,7 @@ export class SamHierarchicalAutocompleteComponent implements ControlValueAccesso } if (this.model.getItems().length > 0 && !foundItem) { for ( - var i = 0; + let i = 0; i < this.model.getItems().length && !foundItem; i++ ) { diff --git a/src/ui-kit/experimental/hierarchical/hierarchical-test-service.spec.ts b/src/ui-kit/experimental/hierarchical/hierarchical-test-service.spec.ts index 85dff6872..389b0e017 100755 --- a/src/ui-kit/experimental/hierarchical/hierarchical-test-service.spec.ts +++ b/src/ui-kit/experimental/hierarchical/hierarchical-test-service.spec.ts @@ -63,8 +63,11 @@ export class HierarchicalDataService implements SamHiercarchicalServiceInterface const itemIncrease = 15; const temp = this.getSortedData(this.loadedData, item.sort); const data = of(temp); - let itemsOb: Observable; - itemsOb = this.filterItemsByAllFields(item, itemsOb, data); + const itemsOb: Observable = this.filterItemsByAllFields( + item, + undefined, + data + ); const items: object[] = this.itemsListOutofObservable(itemsOb); const totalItemCount = items.length; diff --git a/src/ui-kit/experimental/hierarchical/hierarchical-tree-grid/hierarchical-tree-grid.component.spec.ts b/src/ui-kit/experimental/hierarchical/hierarchical-tree-grid/hierarchical-tree-grid.component.spec.ts index b7b89cc6a..8aa1d329f 100755 --- a/src/ui-kit/experimental/hierarchical/hierarchical-tree-grid/hierarchical-tree-grid.component.spec.ts +++ b/src/ui-kit/experimental/hierarchical/hierarchical-tree-grid/hierarchical-tree-grid.component.spec.ts @@ -1,10 +1,6 @@ import { ComponentFixture, TestBed } from "@angular/core/testing"; -import { By } from "@angular/platform-browser"; import { CdkTableModule } from "@angular/cdk/table"; -import { - SamDataTableModule, - SamSortDirective, -} from "../../../components/data-table"; +import { SamDataTableModule } from "../../../components/data-table"; import { SamHierarchicalTreeGridComponent } from "./hierarchical-tree-grid.component"; import { SamHierarchicalTreeGridConfiguration } from "../models/SamHierarchicalTreeGridConfiguration"; diff --git a/src/ui-kit/experimental/hierarchical/hierarchical-tree-header/hierarchical-tree-header.component.ts b/src/ui-kit/experimental/hierarchical/hierarchical-tree-header/hierarchical-tree-header.component.ts index a7cd79cb0..1a342c0be 100755 --- a/src/ui-kit/experimental/hierarchical/hierarchical-tree-header/hierarchical-tree-header.component.ts +++ b/src/ui-kit/experimental/hierarchical/hierarchical-tree-header/hierarchical-tree-header.component.ts @@ -86,7 +86,8 @@ export class SamHierarchicalTreeHeaderComponent { * emits the breadcrumb selected for a given item * @param ev */ - onLevelChange(ev: Event): void { + onLevelChange(ev?: Event): void { + void ev; this.selectBreadcrumb.emit(this.selectModel); } diff --git a/src/ui-kit/experimental/hierarchical/hierarchical-tree/hierarchical-tree.component.spec.ts b/src/ui-kit/experimental/hierarchical/hierarchical-tree/hierarchical-tree.component.spec.ts index 761764ce9..ef3efd944 100755 --- a/src/ui-kit/experimental/hierarchical/hierarchical-tree/hierarchical-tree.component.spec.ts +++ b/src/ui-kit/experimental/hierarchical/hierarchical-tree/hierarchical-tree.component.spec.ts @@ -1,5 +1,4 @@ import { - waitForAsync, ComponentFixture, TestBed, tick, diff --git a/src/ui-kit/experimental/hierarchical/hierarchical-tree/hierarchical-tree.component.ts b/src/ui-kit/experimental/hierarchical/hierarchical-tree/hierarchical-tree.component.ts index fa51683a5..5503f7950 100755 --- a/src/ui-kit/experimental/hierarchical/hierarchical-tree/hierarchical-tree.component.ts +++ b/src/ui-kit/experimental/hierarchical/hierarchical-tree/hierarchical-tree.component.ts @@ -121,7 +121,7 @@ export class SamHierarchicalTreeComponent implements OnInit { this.getResults(); }); - this.scrolled.subscribe((scroll) => { + this.scrolled.subscribe(() => { this.getResults(true); }); } diff --git a/src/ui-kit/experimental/hierarchical/hierarchical/hierarchical.component.ts b/src/ui-kit/experimental/hierarchical/hierarchical/hierarchical.component.ts index e306e6c96..e028b5b72 100755 --- a/src/ui-kit/experimental/hierarchical/hierarchical/hierarchical.component.ts +++ b/src/ui-kit/experimental/hierarchical/hierarchical/hierarchical.component.ts @@ -8,11 +8,7 @@ import { AfterViewChecked, ChangeDetectorRef, } from "@angular/core"; -import { - NG_VALUE_ACCESSOR, - ControlValueAccessor, - FormControl, -} from "@angular/forms"; +import { NG_VALUE_ACCESSOR, ControlValueAccessor } from "@angular/forms"; import { SamHiercarchicalServiceInterface } from "../hierarchical-interface"; import { HierarchicalTreeSelectedItemModel, @@ -64,7 +60,7 @@ export class SamHierarchicalComponent /** * Stored Event for ControlValueAccessor */ - public propogateChange: (_: any) => void = (_: any) => null; + public propogateChange: (_val: any) => void = () => null; public disabled: boolean; diff --git a/src/ui-kit/experimental/hierarchical/selected-result/selected-result.component.ts b/src/ui-kit/experimental/hierarchical/selected-result/selected-result.component.ts index 9e75e0421..ab9f4d09b 100755 --- a/src/ui-kit/experimental/hierarchical/selected-result/selected-result.component.ts +++ b/src/ui-kit/experimental/hierarchical/selected-result/selected-result.component.ts @@ -1,11 +1,7 @@ import { Component, Input, TemplateRef, forwardRef } from "@angular/core"; import { HierarchicalTreeSelectedItemModel } from "../hierarchical-tree-selectedItem.model"; import { SelectedResultConfiguration } from "../models/SamHierarchicalSelectedResultConfiguration"; -import { - NG_VALUE_ACCESSOR, - ControlValueAccessor, - FormControl, -} from "@angular/forms"; +import { NG_VALUE_ACCESSOR, ControlValueAccessor } from "@angular/forms"; const Hierarchical_SelectedResult_VALUE_ACCESSOR: any = { provide: NG_VALUE_ACCESSOR, useExisting: forwardRef(() => SamHierarchicalSelectedResultComponent), @@ -44,7 +40,7 @@ export class SamHierarchicalSelectedResultComponent implements ControlValueAcces /** * Stored Event for ControlValueAccessor */ - private propogateChange: (_: any) => void = (_: any) => null; + private propogateChange: (_val: any) => void = () => null; @Input() public disabled: boolean; diff --git a/src/ui-kit/experimental/icon/icon.component.ts b/src/ui-kit/experimental/icon/icon.component.ts index 5f50545cc..84cd0e983 100755 --- a/src/ui-kit/experimental/icon/icon.component.ts +++ b/src/ui-kit/experimental/icon/icon.component.ts @@ -1,13 +1,7 @@ import { Input, Component } from "@angular/core"; import { - Icon, - Styles, - PullProp, IconProp, SizeProp, - FlipProp, - FaSymbol, - Transform, RotateProp, } from "@fortawesome/fontawesome-svg-core"; diff --git a/src/ui-kit/experimental/input-mask/input-mask.component.ts b/src/ui-kit/experimental/input-mask/input-mask.component.ts index 4d78e4dbb..aeef746ab 100755 --- a/src/ui-kit/experimental/input-mask/input-mask.component.ts +++ b/src/ui-kit/experimental/input-mask/input-mask.component.ts @@ -9,7 +9,7 @@ import { OnInit, OnChanges, } from "@angular/core"; -import { ControlValueAccessor, NG_VALUE_ACCESSOR } from "@angular/forms"; +import { NG_VALUE_ACCESSOR } from "@angular/forms"; import { SamFormControl } from "../../form-controls/sam-form-control"; import { SamFormService } from "../../form-service"; diff --git a/src/ui-kit/experimental/input-mask/input-mask.spec.ts b/src/ui-kit/experimental/input-mask/input-mask.spec.ts index 8fea8d48f..449b5be5c 100755 --- a/src/ui-kit/experimental/input-mask/input-mask.spec.ts +++ b/src/ui-kit/experimental/input-mask/input-mask.spec.ts @@ -1,15 +1,9 @@ -import { TestBed } from "@angular/core/testing"; -import { FormsModule } from "@angular/forms"; - // Load the implementations that should be tested import { SamInputMaskComponent } from "./input-mask.component"; import { SamFormService } from "../../form-service"; -import { SamWrapperModule } from "../../wrappers"; -import { ChangeDetectorRef } from "@angular/core"; describe("The Sam Input Mask component", () => { let component: SamInputMaskComponent; - let cdr: ChangeDetectorRef; // provide our implementations or mocks to the dependency injector beforeEach(() => { diff --git a/src/ui-kit/experimental/listbox/listbox.component.ts b/src/ui-kit/experimental/listbox/listbox.component.ts index d058f35d3..3a82b0014 100755 --- a/src/ui-kit/experimental/listbox/listbox.component.ts +++ b/src/ui-kit/experimental/listbox/listbox.component.ts @@ -120,7 +120,7 @@ export class SamListBoxComponent implements ControlValueAccessor, OnInit { * value is before another value */ private _ordering: any = {}; - onChange: any = (c) => undefined; + onChange: any = () => undefined; onTouched: any = () => undefined; private disabled: boolean; get value() { diff --git a/src/ui-kit/experimental/patterns/layout/architecture/update/reducer.ts b/src/ui-kit/experimental/patterns/layout/architecture/update/reducer.ts index beb3bcb62..8f47a04c4 100755 --- a/src/ui-kit/experimental/patterns/layout/architecture/update/reducer.ts +++ b/src/ui-kit/experimental/patterns/layout/architecture/update/reducer.ts @@ -1,4 +1,4 @@ -import { DataStoreEvent, DataStore } from "../store"; +import { DataStoreEvent } from "../store"; import { modelType } from "../model"; export const layoutEvents = { diff --git a/src/ui-kit/experimental/patterns/layout/components/actionbar.component.ts b/src/ui-kit/experimental/patterns/layout/components/actionbar.component.ts index 1a55129ae..8a291d9f1 100755 --- a/src/ui-kit/experimental/patterns/layout/components/actionbar.component.ts +++ b/src/ui-kit/experimental/patterns/layout/components/actionbar.component.ts @@ -40,7 +40,8 @@ export class SamActionBarComponent implements AfterContentInit { } } - private _onPageChange(event) { + private _onPageChange(event?: unknown) { + void event; const pg = { pageSize: this.pagination.pageSize, currentPage: this.pagination.currentPage, @@ -51,7 +52,8 @@ export class SamActionBarComponent implements AfterContentInit { this._service.model.properties["pagination"].setValue(pg); } - private _onUnitsChange(size) { + private _onUnitsChange(size?: unknown) { + void size; const pg = { pageSize: this.pagination.pageSize, currentPage: this.pagination.currentPage, diff --git a/src/ui-kit/experimental/patterns/layout/components/main.component.ts b/src/ui-kit/experimental/patterns/layout/components/main.component.ts index 652153969..6e2609f9b 100755 --- a/src/ui-kit/experimental/patterns/layout/components/main.component.ts +++ b/src/ui-kit/experimental/patterns/layout/components/main.component.ts @@ -27,7 +27,7 @@ export class SamMainComponent implements AfterContentInit { public ngAfterContentInit() { if (this.drawer) { - this.drawer.clear.subscribe((evt) => this._clearDrawer()); + this.drawer.clear.subscribe(() => this._clearDrawer()); } } diff --git a/src/ui-kit/experimental/picker/picker.ts b/src/ui-kit/experimental/picker/picker.ts index c44e5f06a..5a3666cc5 100755 --- a/src/ui-kit/experimental/picker/picker.ts +++ b/src/ui-kit/experimental/picker/picker.ts @@ -5,9 +5,6 @@ import { AfterViewInit, Output, EventEmitter, - forwardRef, - ViewChild, - Directive, Input, } from "@angular/core"; @@ -48,7 +45,8 @@ export class SamPickerComponent implements AfterViewInit { this.combobox.clearInput(); } - private _onChange(e) { + private _onChange(e?: unknown) { + void e; this.selected = this.combobox.selected; this.onChange.emit(this.selected); } diff --git a/src/ui-kit/experimental/picker/popover.ts b/src/ui-kit/experimental/picker/popover.ts index edf51709b..e3eb51664 100755 --- a/src/ui-kit/experimental/picker/popover.ts +++ b/src/ui-kit/experimental/picker/popover.ts @@ -2,7 +2,6 @@ import { Component, forwardRef, AfterViewInit, - ViewChild, ElementRef, } from "@angular/core"; import { diff --git a/src/ui-kit/experimental/search/search.component.ts b/src/ui-kit/experimental/search/search.component.ts index b5a585656..584b516f2 100755 --- a/src/ui-kit/experimental/search/search.component.ts +++ b/src/ui-kit/experimental/search/search.component.ts @@ -5,19 +5,16 @@ import { EventEmitter, ElementRef, ViewChild, - AfterViewInit, OnInit, OnChanges, } from "@angular/core"; import { trigger, - state, style, animate, transition, query, - animateChild, keyframes, stagger, } from "@angular/animations"; diff --git a/src/ui-kit/experimental/segment/segment.component.ts b/src/ui-kit/experimental/segment/segment.component.ts index b01d16b95..abbe2eddb 100755 --- a/src/ui-kit/experimental/segment/segment.component.ts +++ b/src/ui-kit/experimental/segment/segment.component.ts @@ -1,4 +1,4 @@ -import { Component, Input } from "@angular/core"; +import { Component } from "@angular/core"; @Component({ selector: "sam-segment", diff --git a/src/ui-kit/experimental/sideNavigationToolbar/sideNavigationToolbar/sideNavigationToolbar.component.ts b/src/ui-kit/experimental/sideNavigationToolbar/sideNavigationToolbar/sideNavigationToolbar.component.ts index eafffb3e1..35ae776b5 100755 --- a/src/ui-kit/experimental/sideNavigationToolbar/sideNavigationToolbar/sideNavigationToolbar.component.ts +++ b/src/ui-kit/experimental/sideNavigationToolbar/sideNavigationToolbar/sideNavigationToolbar.component.ts @@ -1,8 +1,5 @@ import { Component, - Input, - TemplateRef, - ViewChild, ContentChildren, QueryList, AfterContentInit, diff --git a/src/ui-kit/experimental/tabs/tab-header.ts b/src/ui-kit/experimental/tabs/tab-header.ts index d72134709..cbd020f94 100755 --- a/src/ui-kit/experimental/tabs/tab-header.ts +++ b/src/ui-kit/experimental/tabs/tab-header.ts @@ -16,7 +16,6 @@ import { ContentChildren, Output, EventEmitter, - Optional, AfterContentChecked, AfterContentInit, OnDestroy, @@ -360,9 +359,9 @@ export class MdTabHeader // The view length is the visible width of the tab labels. const viewLength = this._tabListContainer.nativeElement.offsetWidth; - let labelBeforePos: number, labelAfterPos: number; - labelBeforePos = selectedLabel.getOffsetLeft(); - labelAfterPos = labelBeforePos + selectedLabel.getOffsetWidth(); + const labelBeforePos: number = selectedLabel.getOffsetLeft(); + const labelAfterPos: number = + labelBeforePos + selectedLabel.getOffsetWidth(); const beforeVisiblePos = this.scrollDistance; const afterVisiblePos = this.scrollDistance + viewLength; diff --git a/src/ui-kit/experimental/title/title.component.ts b/src/ui-kit/experimental/title/title.component.ts index 67d33f73b..16f91f2a9 100755 --- a/src/ui-kit/experimental/title/title.component.ts +++ b/src/ui-kit/experimental/title/title.component.ts @@ -1,7 +1,6 @@ import { Component, Input, - ElementRef, TemplateRef, Renderer2, ViewChild, diff --git a/src/ui-kit/experimental/video-player/video-player.component.ts b/src/ui-kit/experimental/video-player/video-player.component.ts index 879bd035a..a8500cd7e 100755 --- a/src/ui-kit/experimental/video-player/video-player.component.ts +++ b/src/ui-kit/experimental/video-player/video-player.component.ts @@ -1,11 +1,9 @@ import { Component, Input, - OnInit, ContentChildren, QueryList, ElementRef, - forwardRef, Renderer2, Output, EventEmitter, @@ -13,9 +11,8 @@ import { AfterViewInit, OnDestroy, } from "@angular/core"; -import GLOBAL_STRINGS from "accessible-html5-video-player/js/strings.js"; import * as InitPxVideo from "accessible-html5-video-player/js/px-video.js"; -declare var InitPxVideo: any; +declare let InitPxVideo: any; // NOTE: Add px-video.js and strings.js files to your application .angular-cli.json script tag @@ -94,7 +91,8 @@ export class SamVideoPlayerComponent this.setElementAttribute(videoEl, "role", "presentation"); } - onToggleFullScreen(event) { + onToggleFullScreen(event?: Event) { + void event; const isFullScreen = document["fullscreen"]; this.onFullScreenChange.emit(isFullScreen); } diff --git a/src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.component.ts b/src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.component.ts index 4cd2922a6..386878c2a 100755 --- a/src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.component.ts +++ b/src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.component.ts @@ -13,7 +13,6 @@ import { } from "@angular/core"; import { animate, - state, style, transition, trigger, @@ -506,7 +505,7 @@ export class SamAutocompleteMultiselectComponent if (this.searchText) { let foundItem = false; if (Array.isArray(this.list)) { - for (var i = 0; i < this.list.length; i++) { + for (let i = 0; i < this.list.length; i++) { const item = this.list[i]; if (item) { if (item[this.keyValueConfig.valueProperty] === this.searchText) { @@ -523,7 +522,7 @@ export class SamAutocompleteMultiselectComponent if (this.value) { if (!foundItem) { - for (var i = 0; i < this.value.length; i++) { + for (let i = 0; i < this.value.length; i++) { const tempItem = this.value[i]; if ( tempItem[this.keyValueConfig.valueProperty] === this.searchText @@ -687,7 +686,6 @@ export class SamAutocompleteMultiselectComponent public getSelectedContentWidth(element: HTMLElement): Array { const elementChildren = element.parentElement.children; - const width = 0; const elementsWidths = []; // Cannot use forEach here since children is not a Javascript array // and its data structure does not provide forEach on its @@ -769,7 +767,7 @@ export class SamAutocompleteMultiselectComponent context.sortByCategory(context.cache.get(searchString)) ); }, - (err) => { + () => { context.displaySpinner = false; const errorObject = { cannotBeSelected: true, @@ -1077,7 +1075,8 @@ export class SamAutocompleteMultiselectComponent this.textArea.nativeElement.blur(); } - public checkForFocus(event) { + public checkForFocus(event?: Event) { + void event; this.clearSearch(); this.list = []; } @@ -1145,7 +1144,7 @@ export class SamAutocompleteMultiselectComponent this.isDisabled = isDisabled; } - private onChangeCallback: (_: any) => void = (_: any) => null; + private onChangeCallback: (_: any) => void = () => null; private onTouchedCallback: () => void = () => null; } diff --git a/src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.spec.ts b/src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.spec.ts index 0a68dbdd6..6691e5d27 100755 --- a/src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.spec.ts +++ b/src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.spec.ts @@ -133,7 +133,7 @@ describe("The Sam Autocomplete Multiselect Component", () => { }); it("should support controlValueAccessor", () => { - component.registerOnChange((_val) => undefined); + component.registerOnChange(() => undefined); component.registerOnTouched(() => undefined); component.setDisabledState(false); }); diff --git a/src/ui-kit/form-controls/autocomplete/autocomplete.component.ts b/src/ui-kit/form-controls/autocomplete/autocomplete.component.ts index 58355b888..4cb3b3d24 100644 --- a/src/ui-kit/form-controls/autocomplete/autocomplete.component.ts +++ b/src/ui-kit/form-controls/autocomplete/autocomplete.component.ts @@ -19,7 +19,7 @@ import { ControlValueAccessor, FormControl, } from "@angular/forms"; -import { Observable, Subject, of } from "rxjs"; +import { Observable, Subject } from "rxjs"; import { AutocompleteConfig } from "../../types"; import { AutocompleteService } from "./autocomplete.service"; import { SamFormService } from "../../form-service"; @@ -260,7 +260,7 @@ export class SamAutocompleteComponent public keyEvents: Subject = new Subject(); public onTouchedCallback: () => void = () => null; - public propogateChange: (_: any) => void = (_: any) => null; + public propogateChange: (_val: any) => void = () => null; constructor( @Optional() public autocompleteService: AutocompleteService, @@ -311,7 +311,8 @@ export class SamAutocompleteComponent this.endOfList = false; } - requestError(err) { + requestError(err?: unknown) { + void err; this.results = ["An error occurred. Try a different value."]; const errorobj = {}; errorobj[this.config.keyValueConfig.keyProperty] = "Error"; @@ -786,7 +787,8 @@ export class SamAutocompleteComponent } } - checkForFocus(event) { + checkForFocus(event?: Event) { + void event; if ( !this.allowAny && this.selectedInputValue !== this.inputValue && @@ -847,9 +849,8 @@ export class SamAutocompleteComponent filterKeyValuePairs(subStr: string, keyValuePairs: any): any { const lowerSubStr = subStr.toLowerCase(); - const categories = []; let currentCategory = ""; - const reducedArr = keyValuePairs.reduce((prev, curr, index, arr) => { + const reducedArr = keyValuePairs.reduce((prev, curr) => { if ( curr[this.config.keyValueConfig.keyProperty] .toLowerCase() diff --git a/src/ui-kit/form-controls/autocomplete/autocomplete.service.ts b/src/ui-kit/form-controls/autocomplete/autocomplete.service.ts index 19c6aa9c4..e1d520d2e 100755 --- a/src/ui-kit/form-controls/autocomplete/autocomplete.service.ts +++ b/src/ui-kit/form-controls/autocomplete/autocomplete.service.ts @@ -4,11 +4,19 @@ import { map } from "rxjs/operators"; @Injectable() export class AutocompleteService { - setFetchMethod(_?: any): any { + setFetchMethod(fn?: (...args: unknown[]) => unknown): any { + void fn; return; } - fetch(val: string, pageEnd: boolean, serviceOptions?: any): Observable { + fetch( + val?: string, + pageEnd?: boolean, + serviceOptions?: unknown + ): Observable { + void val; + void pageEnd; + void serviceOptions; return of([]).pipe(map((o) => o)); } } diff --git a/src/ui-kit/form-controls/autocomplete/autocomplete.spec.ts b/src/ui-kit/form-controls/autocomplete/autocomplete.spec.ts index 7d4e7f64b..9fe157255 100755 --- a/src/ui-kit/form-controls/autocomplete/autocomplete.spec.ts +++ b/src/ui-kit/form-controls/autocomplete/autocomplete.spec.ts @@ -332,7 +332,7 @@ describe("The Sam Autocomplete Component", () => { }); it("Should work as a form control", () => { - component.registerOnChange((_val) => {}); + component.registerOnChange(() => {}); component.registerOnTouched(() => {}); fixture.detectChanges(); component.setDisabledState(true); diff --git a/src/ui-kit/form-controls/checkbox/checkbox.component.ts b/src/ui-kit/form-controls/checkbox/checkbox.component.ts index 57ead9798..aa3d97df9 100755 --- a/src/ui-kit/form-controls/checkbox/checkbox.component.ts +++ b/src/ui-kit/form-controls/checkbox/checkbox.component.ts @@ -102,7 +102,7 @@ export class SamCheckboxComponent implements ControlValueAccessor, OnInit { */ private _ordering: any = {}; - onChange: any = (c) => undefined; + onChange: any = () => undefined; onTouched: any = () => undefined; diff --git a/src/ui-kit/form-controls/checkbox/index.ts b/src/ui-kit/form-controls/checkbox/index.ts index d4e819e54..bbe22de2d 100755 --- a/src/ui-kit/form-controls/checkbox/index.ts +++ b/src/ui-kit/form-controls/checkbox/index.ts @@ -3,7 +3,6 @@ import { CommonModule } from "@angular/common"; import { SamCheckboxComponent } from "./checkbox.component"; import { SamWrapperModule } from "../../wrappers"; -import { OptionsType } from "../../types"; @NgModule({ imports: [CommonModule, SamWrapperModule], diff --git a/src/ui-kit/form-controls/date-range/date-range.component.ts b/src/ui-kit/form-controls/date-range/date-range.component.ts index 28bc95cfc..d0c5bf749 100755 --- a/src/ui-kit/form-controls/date-range/date-range.component.ts +++ b/src/ui-kit/form-controls/date-range/date-range.component.ts @@ -134,12 +134,6 @@ export class SamDateRangeComponent private endDateValue; public static dateRangeValidation(c: AbstractControl) { - const error = { - dateRangeError: { - message: "", - }, - }; - if (c.value && c.value.startDate && c.value.endDate) { return SamDateRangeComponent.validateStartAndEnd(c); } diff --git a/src/ui-kit/form-controls/date-range/date-range.spec.ts b/src/ui-kit/form-controls/date-range/date-range.spec.ts index d5743f1d4..ad33ed9cf 100755 --- a/src/ui-kit/form-controls/date-range/date-range.spec.ts +++ b/src/ui-kit/form-controls/date-range/date-range.spec.ts @@ -222,7 +222,7 @@ describe("The Sam Date Range component", () => { component.onChange(); component.onTouched(); component.registerOnTouched(() => undefined); - component.registerOnChange((_) => undefined); + component.registerOnChange(() => undefined); component.setDisabledState(false); component.writeValue(undefined); component.focusHandler(); diff --git a/src/ui-kit/form-controls/date-time/date-time.component.ts b/src/ui-kit/form-controls/date-time/date-time.component.ts index 7dac2f794..9173bdf15 100755 --- a/src/ui-kit/form-controls/date-time/date-time.component.ts +++ b/src/ui-kit/form-controls/date-time/date-time.component.ts @@ -2,8 +2,6 @@ import { Component, Input, ViewChild, - Output, - EventEmitter, OnInit, forwardRef, OnChanges, diff --git a/src/ui-kit/form-controls/date/date.component.ts b/src/ui-kit/form-controls/date/date.component.ts index f2393b376..6114139ad 100755 --- a/src/ui-kit/form-controls/date/date.component.ts +++ b/src/ui-kit/form-controls/date/date.component.ts @@ -17,7 +17,6 @@ import { NG_VALUE_ACCESSOR, ControlValueAccessor, FormControl, - Validators, ValidatorFn, AbstractControl, } from "@angular/forms"; @@ -314,7 +313,8 @@ export class SamDateComponent } } - onMonthBlur(event) { + onMonthBlur(event?: Event) { + void event; this.isMonthBlur = true; if (this.month.nativeElement.value === "0") { this.month.nativeElement.value = ""; @@ -379,7 +379,8 @@ export class SamDateComponent return parseInt(possibleNum, 10); } - onDayBlur(event) { + onDayBlur(event?: Event) { + void event; this.isDayBlur = true; if (this.day.nativeElement.value === "0") { this.day.nativeElement.value = ""; @@ -457,7 +458,8 @@ export class SamDateComponent return month === 2 ? 2 : three; } - onYearBlur(event) { + onYearBlur(event?: Event) { + void event; this.isYearBlur = true; if (this.year.nativeElement.value === "0") { this.year.nativeElement.value = ""; @@ -621,7 +623,8 @@ export class SamDateComponent ); } - triggerTouch(ev) { + triggerTouch(ev?: Event) { + void ev; this.isYearTouched = true; this.touchHandler(); this.onTouched(); diff --git a/src/ui-kit/form-controls/date/date.spec.ts b/src/ui-kit/form-controls/date/date.spec.ts index 0625a0a26..c6ae7534e 100755 --- a/src/ui-kit/form-controls/date/date.spec.ts +++ b/src/ui-kit/form-controls/date/date.spec.ts @@ -157,7 +157,7 @@ describe("The Sam Date component", () => { try { component.ngOnInit(); fail(); - } catch (e) { + } catch { expect(true).toBe(true); } }); diff --git a/src/ui-kit/form-controls/number/number.spec.ts b/src/ui-kit/form-controls/number/number.spec.ts index 1f86a2a15..535d15f19 100755 --- a/src/ui-kit/form-controls/number/number.spec.ts +++ b/src/ui-kit/form-controls/number/number.spec.ts @@ -16,7 +16,7 @@ describe("The Sam Number component", () => { }); it("should implement controlvalueaccessor", () => { - component.registerOnChange((_) => undefined); + component.registerOnChange(() => undefined); component.registerOnTouched(() => undefined); component.onChange(); component.onTouched(); diff --git a/src/ui-kit/form-controls/radiobutton/radiobutton.component.ts b/src/ui-kit/form-controls/radiobutton/radiobutton.component.ts index 3bccae159..ef394af17 100755 --- a/src/ui-kit/form-controls/radiobutton/radiobutton.component.ts +++ b/src/ui-kit/form-controls/radiobutton/radiobutton.component.ts @@ -11,14 +11,7 @@ import { } from "@angular/core"; import { FieldsetWrapper } from "../../wrappers/fieldset-wrapper"; import { OptionsType } from "../../types"; -import { - NG_VALUE_ACCESSOR, - ControlValueAccessor, - FormControl, - Validators, - ValidatorFn, -} from "@angular/forms"; -import { SamFormService } from "../../form-service"; +import { NG_VALUE_ACCESSOR, FormControl } from "@angular/forms"; /** * The component is a set of checkboxes compliant with diff --git a/src/ui-kit/form-controls/radiobutton/radiobutton.spec.ts b/src/ui-kit/form-controls/radiobutton/radiobutton.spec.ts index f839ddc70..bb03547fc 100755 --- a/src/ui-kit/form-controls/radiobutton/radiobutton.spec.ts +++ b/src/ui-kit/form-controls/radiobutton/radiobutton.spec.ts @@ -26,7 +26,7 @@ describe("The Sam Radio Buttons component", () => { try { component.ngOnInit(); fail(); - } catch (e) { + } catch { expect(true).toBe(true); } }); diff --git a/src/ui-kit/form-controls/sam-form-control/sam-form-control.ts b/src/ui-kit/form-controls/sam-form-control/sam-form-control.ts index 13b865a55..66a81579b 100755 --- a/src/ui-kit/form-controls/sam-form-control/sam-form-control.ts +++ b/src/ui-kit/form-controls/sam-form-control/sam-form-control.ts @@ -179,11 +179,11 @@ export class SamFormControl private setValidationMethod() { if (!this.useFormService) { this.control.statusChanges.subscribe( - (_: any) => { + () => { this.wrapper.formatErrors(this.control); this.cdr.detectChanges(); }, - (err: any) => console.error("Error occurred") + () => console.error("Error occurred") ); } else { this.samFormService.formEventsUpdated$.subscribe( @@ -202,7 +202,7 @@ export class SamFormControl this.wrapper.clearError(); } }, - (err: any) => console.error("Error occured") + () => console.error("Error occured") ); } } diff --git a/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete-search/autocomplete-search.component.spec.ts b/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete-search/autocomplete-search.component.spec.ts index 1f4ede3de..988073a6c 100755 --- a/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete-search/autocomplete-search.component.spec.ts +++ b/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete-search/autocomplete-search.component.spec.ts @@ -100,7 +100,6 @@ describe("SamAutocompleteComponent", () => { fixture.detectChanges(); tick(); fixture.detectChanges(); - const list = fixture.debugElement.query(By.css(".sds-autocomplete")); })); it.skip("Should have results with input and free text search on", fakeAsync(() => { @@ -410,7 +409,6 @@ describe("SamAutocompleteComponent", () => { fixture.detectChanges(); tick(); fixture.detectChanges(); - const list = fixture.debugElement.query(By.css(".sds-autocomplete")); const event = { key: "Enter", target: { value: "id" }, diff --git a/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete-search/autocomplete-search.component.ts b/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete-search/autocomplete-search.component.ts index 19990d730..b65f53b13 100755 --- a/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete-search/autocomplete-search.component.ts +++ b/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete-search/autocomplete-search.component.ts @@ -144,7 +144,7 @@ export class SAMSDSAutocompleteSearchComponent implements ControlValueAccessor { /** * Stored Event for ControlValueAccessor */ - public propogateChange: (_: any) => void = (_: any) => null; + public propogateChange: (_val: any) => void = () => null; @Input() public disabled: boolean; @@ -201,7 +201,8 @@ export class SAMSDSAutocompleteSearchComponent implements ControlValueAccessor { * * @param event */ - checkForFocus(event): void { + checkForFocus(event?: Event): void { + void event; if (this.configuration) { if ( this.configuration.isTagModeEnabled || @@ -226,7 +227,8 @@ export class SAMSDSAutocompleteSearchComponent implements ControlValueAccessor { } } - clickOutSide(event): void { + clickOutSide(event?: Event): void { + void event; this.focusRemoved(); this.showResults = false; } @@ -286,7 +288,8 @@ export class SAMSDSAutocompleteSearchComponent implements ControlValueAccessor { } } - onkeypress(ev) { + onkeypress(ev?: KeyboardEvent) { + void ev; return this.configuration.inputReadOnly ? false : true; } textChange(event) { @@ -466,9 +469,10 @@ export class SAMSDSAutocompleteSearchComponent implements ControlValueAccessor { */ private scrollToSelectedItem() { if (this.highlightedIndex >= 0) { - let selectedChild; const dom = this.resultsListElement.nativeElement; - selectedChild = dom.querySelector(".sds-autocomplete__item--highlighted"); + const selectedChild = dom.querySelector( + ".sds-autocomplete__item--highlighted" + ); if (selectedChild) { selectedChild.scrollIntoView({ behavior: "smooth", @@ -510,14 +514,14 @@ export class SAMSDSAutocompleteSearchComponent implements ControlValueAccessor { if (this.inputValue.length !== 0) { let foundItem = false; if (this.results) { - for (var i = 0; i < this.results.length && !foundItem; i++) { + for (let i = 0; i < this.results.length && !foundItem; i++) { const item = this.results[i]; foundItem = item[this.configuration.primaryTextField] === this.inputValue; } } if (this.model.items.length > 0 && !foundItem) { - for (var i = 0; i < this.model.items.length && !foundItem; i++) { + for (let i = 0; i < this.model.items.length && !foundItem; i++) { const item = this.model.items[i]; foundItem = item[this.configuration.primaryTextField] === this.inputValue; diff --git a/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete/autocomplete.component.spec.ts b/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete/autocomplete.component.spec.ts index 8edbf94ee..b4c6875a4 100755 --- a/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete/autocomplete.component.spec.ts +++ b/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete/autocomplete.component.spec.ts @@ -1,11 +1,5 @@ /* tslint:disable */ -import { - waitForAsync, - ComponentFixture, - TestBed, - fakeAsync, - tick, -} from "@angular/core/testing"; +import { waitForAsync, ComponentFixture, TestBed } from "@angular/core/testing"; import { SAMSDSAutocompleteComponent } from "./autocomplete.component"; import { AutoCompleteSampleDataService } from "../autocomplete-search/autocomplete-seach-test-service.spec"; import { SAMSDSAutocompletelConfiguration } from "./models/SDSAutocompletelConfiguration.model"; diff --git a/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete/autocomplete.component.ts b/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete/autocomplete.component.ts index f9cf1dac2..b32af978a 100755 --- a/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete/autocomplete.component.ts +++ b/src/ui-kit/form-controls/sam-sds-autocomplete/autocomplete/autocomplete.component.ts @@ -3,14 +3,9 @@ import { Input, ViewChild, TemplateRef, - ElementRef, forwardRef, } from "@angular/core"; -import { - NG_VALUE_ACCESSOR, - ControlValueAccessor, - FormControl, -} from "@angular/forms"; +import { NG_VALUE_ACCESSOR, ControlValueAccessor } from "@angular/forms"; import { SAMSDSSelectedItemModel } from "../selected-result/models/sds-selectedItem.model"; import { SAMSDSAutocompleteServiceInterface } from "../autocomplete-search/models/SAMSDSAutocompleteServiceInterface"; import { SAMSDSAutocompletelConfiguration } from "./models/SDSAutocompletelConfiguration.model"; @@ -86,7 +81,9 @@ export class SAMSDSAutocompleteComponent implements ControlValueAccessor { /** * Stored Event for ControlValueAccessor */ - public onChange = (_: any) => {}; + public onChange = (val: unknown) => { + void val; + }; // ControlValueAccessor (and Formly) is trying to update the value of the FormControl (our custom component) programatically // If there is a value we will just overwrite items @@ -111,7 +108,8 @@ export class SAMSDSAutocompleteComponent implements ControlValueAccessor { } // Method that is fired when the child component event notifies us that the items array has been modified within the child component - updateItems($event) { + updateItems($event?: unknown) { + void $event; this.updateModel(); } diff --git a/src/ui-kit/form-controls/sam-sds-autocomplete/selected-result/selected-result.component.ts b/src/ui-kit/form-controls/sam-sds-autocomplete/selected-result/selected-result.component.ts index 43655d445..0d133b57f 100755 --- a/src/ui-kit/form-controls/sam-sds-autocomplete/selected-result/selected-result.component.ts +++ b/src/ui-kit/form-controls/sam-sds-autocomplete/selected-result/selected-result.component.ts @@ -48,7 +48,7 @@ export class SAMSDSSelectedResultComponent implements ControlValueAccessor { /** * Stored Event for ControlValueAccessor */ - public propogateChange: (_: any) => void = (_: any) => null; + public propogateChange: (_val: any) => void = () => null; @Input() public disabled: boolean; diff --git a/src/ui-kit/form-controls/select/select.component.ts b/src/ui-kit/form-controls/select/select.component.ts index 2e808e1b6..0aa1291b5 100755 --- a/src/ui-kit/form-controls/select/select.component.ts +++ b/src/ui-kit/form-controls/select/select.component.ts @@ -19,7 +19,6 @@ import { } from "@angular/forms"; import { SamFormService } from "../../form-service"; -const noop = () => undefined; const MY_VALUE_ACCESSOR: any = { provide: NG_VALUE_ACCESSOR, useExisting: forwardRef(() => SamSelectComponent), diff --git a/src/ui-kit/form-controls/select/select.spec.ts b/src/ui-kit/form-controls/select/select.spec.ts index 299a40b03..db77fef62 100755 --- a/src/ui-kit/form-controls/select/select.spec.ts +++ b/src/ui-kit/form-controls/select/select.spec.ts @@ -16,7 +16,7 @@ describe("The Sam Select component", () => { }); it("should implement controlvalueaccessor", () => { - component.registerOnChange((_) => undefined); + component.registerOnChange(() => undefined); component.registerOnTouched(() => undefined); component.setDisabledState(false); component.writeValue(["aaa"]); @@ -27,7 +27,7 @@ describe("The Sam Select component", () => { try { component.ngOnInit(); fail(); - } catch (e) { + } catch { expect(true).toBe(true); } }); diff --git a/src/ui-kit/form-controls/text/text.component.ts b/src/ui-kit/form-controls/text/text.component.ts index 581dd3ce3..4df77cba4 100755 --- a/src/ui-kit/form-controls/text/text.component.ts +++ b/src/ui-kit/form-controls/text/text.component.ts @@ -115,7 +115,7 @@ export class SamTextComponent @ViewChild(LabelWrapper, { static: true }) public wrapper: LabelWrapper; - public onChange: any = (c) => null; + public onChange: any = () => null; public onTouched: any = () => null; public focusEvent = new Subject(); diff --git a/src/ui-kit/form-controls/text/text.spec.ts b/src/ui-kit/form-controls/text/text.spec.ts index 0dbf5e16b..4a7907224 100755 --- a/src/ui-kit/form-controls/text/text.spec.ts +++ b/src/ui-kit/form-controls/text/text.spec.ts @@ -27,7 +27,7 @@ describe("The Sam Text component", () => { component.onChange(); component.onTouched(); component.setDisabledState(false); - component.registerOnChange((_) => undefined); + component.registerOnChange(() => undefined); component.registerOnTouched(() => undefined); component.writeValue("hello"); expect(component.value).toBe("hello"); diff --git a/src/ui-kit/form-controls/textarea/textarea.component.ts b/src/ui-kit/form-controls/textarea/textarea.component.ts index 9af918ead..d80455250 100755 --- a/src/ui-kit/form-controls/textarea/textarea.component.ts +++ b/src/ui-kit/form-controls/textarea/textarea.component.ts @@ -122,7 +122,7 @@ export class SamTextareaComponent @ViewChild(LabelWrapper, { static: true }) wrapper: LabelWrapper; public characterCounterMsg: string; - public onChange: any = (_) => undefined; + public onChange: any = () => undefined; public onTouched: any = () => undefined; private inBrowser = typeof window !== "undefined"; diff --git a/src/ui-kit/form-controls/textarea/textarea.spec.ts b/src/ui-kit/form-controls/textarea/textarea.spec.ts index af4246e3c..ef415155f 100755 --- a/src/ui-kit/form-controls/textarea/textarea.spec.ts +++ b/src/ui-kit/form-controls/textarea/textarea.spec.ts @@ -2,7 +2,6 @@ import { TestBed } from "@angular/core/testing"; import { SamTextareaComponent } from "./textarea.component"; import { LabelWrapper } from "../../wrappers/label-wrapper"; import { FormsModule, FormControl } from "@angular/forms"; -import { By } from "@angular/platform-browser"; import { SamFormService } from "../../form-service"; import { ChangeDetectorRef } from "@angular/core"; @@ -16,7 +15,7 @@ describe("The Sam Textarea component", () => { }); it("should implement control value accessor", () => { - component.registerOnChange((_) => undefined); + component.registerOnChange(() => undefined); component.registerOnTouched(() => undefined); component.onChange(undefined); component.onTouched(); @@ -58,7 +57,7 @@ describe("The Sam Textarea component", () => { try { component.ngOnInit(); fail(); - } catch (e) { + } catch { expect(true).toBe(true); } }); diff --git a/src/ui-kit/form-controls/time/time.component.ts b/src/ui-kit/form-controls/time/time.component.ts index 547a68195..849fec65b 100755 --- a/src/ui-kit/form-controls/time/time.component.ts +++ b/src/ui-kit/form-controls/time/time.component.ts @@ -2,8 +2,6 @@ import { Component, Input, ViewChild, - Output, - EventEmitter, OnInit, OnChanges, forwardRef, @@ -14,8 +12,6 @@ import { NG_VALUE_ACCESSOR, ControlValueAccessor, FormControl, - Validators, - ValidatorFn, } from "@angular/forms"; import { SamFormService } from "../../form-service"; diff --git a/src/ui-kit/form-controls/time/time.spec.ts b/src/ui-kit/form-controls/time/time.spec.ts index a79fd92cf..0377faff8 100755 --- a/src/ui-kit/form-controls/time/time.spec.ts +++ b/src/ui-kit/form-controls/time/time.spec.ts @@ -18,7 +18,7 @@ describe("The Sam Time component", () => { try { component.ngOnInit(); fail(); - } catch (e) { + } catch { expect(true).toBe(true); } }); @@ -43,7 +43,7 @@ describe("The Sam Time component", () => { it("should implement controlvalueaccessor", () => { component.setDisabledState(false); - component.registerOnChange((_) => undefined); + component.registerOnChange(() => undefined); component.registerOnTouched(() => undefined); component.writeValue("12:12"); expect(true).toBe(true); diff --git a/src/ui-kit/form-controls/toggle-switch/toggle-switch.component.ts b/src/ui-kit/form-controls/toggle-switch/toggle-switch.component.ts index 591f64c48..55d4b3887 100755 --- a/src/ui-kit/form-controls/toggle-switch/toggle-switch.component.ts +++ b/src/ui-kit/form-controls/toggle-switch/toggle-switch.component.ts @@ -5,13 +5,7 @@ import { EventEmitter, forwardRef, } from "@angular/core"; -import { - NG_VALUE_ACCESSOR, - ControlValueAccessor, - FormControl, - Validators, - ValidatorFn, -} from "@angular/forms"; +import { NG_VALUE_ACCESSOR, ControlValueAccessor } from "@angular/forms"; /** * SAM Toggle Switch Component diff --git a/src/ui-kit/form-controls/toggle-switch/toggle-switch.spec.ts b/src/ui-kit/form-controls/toggle-switch/toggle-switch.spec.ts index 0d0267d27..adb14e817 100755 --- a/src/ui-kit/form-controls/toggle-switch/toggle-switch.spec.ts +++ b/src/ui-kit/form-controls/toggle-switch/toggle-switch.spec.ts @@ -3,7 +3,6 @@ import { FormsModule } from "@angular/forms"; // Load the implementations that should be tested import { SamToggleSwitchComponent } from "./toggle-switch.component"; -import { SamUIKitModule } from "../../index"; import { By } from "@angular/platform-browser"; describe("The Sam Toggle Switch component", () => { @@ -33,7 +32,7 @@ describe("The Sam Toggle Switch component", () => { it("should implement controlvalueaccessor", () => { component.onChange(); component.onTouched(); - component.registerOnChange((_) => undefined); + component.registerOnChange(() => undefined); component.registerOnTouched(() => undefined); component.setDisabledState(false); component.writeValue(true); diff --git a/src/ui-kit/form-controls/upload-v2/upload-v2.component.ts b/src/ui-kit/form-controls/upload-v2/upload-v2.component.ts index 611397b77..d0f262dd4 100755 --- a/src/ui-kit/form-controls/upload-v2/upload-v2.component.ts +++ b/src/ui-kit/form-controls/upload-v2/upload-v2.component.ts @@ -419,7 +419,7 @@ export class SamUploadComponentV2 let toJson: any = {}; try { toJson = JSON.parse(error); - } catch (ex) {} + } catch {} upload.error = toJson.statusText || toJson.message || "Upload failed"; upload.status = UploadStatus.Error; this.emit(); diff --git a/src/ui-kit/form-controls/upload/upload.component.ts b/src/ui-kit/form-controls/upload/upload.component.ts index 70a5df218..ee60f7340 100755 --- a/src/ui-kit/form-controls/upload/upload.component.ts +++ b/src/ui-kit/form-controls/upload/upload.component.ts @@ -268,7 +268,7 @@ export class SamUploadComponent implements ControlValueAccessor { let toJson: any = {}; try { toJson = JSON.parse(error); - } catch (ex) {} + } catch {} upload.error = toJson.statusText || toJson.message || "Upload failed"; upload.status = UploadStatus.Error; this.emit(); diff --git a/src/ui-kit/form-templates/international-phone/international.component.ts b/src/ui-kit/form-templates/international-phone/international.component.ts index 9f772ab15..36c49de37 100755 --- a/src/ui-kit/form-templates/international-phone/international.component.ts +++ b/src/ui-kit/form-templates/international-phone/international.component.ts @@ -173,7 +173,7 @@ export class SamIntlPhoneGroup extends SamFieldset implements OnInit { } private _useDefaultStrategy(): void { - this.group.valueChanges.subscribe((_) => { + this.group.valueChanges.subscribe(() => { this.wrapper.formatErrors( this.group.controls.prefix, this.group.controls.phone, diff --git a/src/ui-kit/form-templates/international-phone/international.spec.ts b/src/ui-kit/form-templates/international-phone/international.spec.ts index 8d7205dc0..478b16299 100755 --- a/src/ui-kit/form-templates/international-phone/international.spec.ts +++ b/src/ui-kit/form-templates/international-phone/international.spec.ts @@ -75,7 +75,7 @@ describe("The Sam International Phone Group", () => { try { fixture.detectChanges(); fail(); - } catch (exception) { + } catch { expect(true).toBe(true); //fix component so it cleans up properly component.phoneName = "a"; @@ -91,7 +91,7 @@ describe("The Sam International Phone Group", () => { try { fixture.detectChanges(); fail(); - } catch (exception) { + } catch { expect(true).toBe(true); //fix component so it cleans up properly component.phoneName = "a"; @@ -107,7 +107,7 @@ describe("The Sam International Phone Group", () => { try { fixture.detectChanges(); fail(); - } catch (exception) { + } catch { expect(true).toBe(true); //fix component so it cleans up properly component.phoneName = "a"; diff --git a/src/ui-kit/form-templates/international-phone/sam-extension/extension.component.ts b/src/ui-kit/form-templates/international-phone/sam-extension/extension.component.ts index 19f57481a..d2ce88427 100755 --- a/src/ui-kit/form-templates/international-phone/sam-extension/extension.component.ts +++ b/src/ui-kit/form-templates/international-phone/sam-extension/extension.component.ts @@ -1,16 +1,11 @@ import { Component, - Input, - ElementRef, - OnChanges, ChangeDetectorRef, - SimpleChanges, - ViewChild, ViewEncapsulation, OnInit, } from "@angular/core"; -import { ValidatorFn, FormControl, ValidationErrors } from "@angular/forms"; +import { FormControl } from "@angular/forms"; import { SamFormService } from "../../../form-service"; diff --git a/src/ui-kit/form-templates/international-phone/sam-extension/extension.spec.ts b/src/ui-kit/form-templates/international-phone/sam-extension/extension.spec.ts index 0327f4de8..d4944b6fe 100755 --- a/src/ui-kit/form-templates/international-phone/sam-extension/extension.spec.ts +++ b/src/ui-kit/form-templates/international-phone/sam-extension/extension.spec.ts @@ -8,12 +8,6 @@ import { SamFormService } from "../../../form-service"; import { SamWrapperModule } from "../../../wrappers"; import { SamFormControlsModule } from "../../../form-controls"; -const mockEvent = { - currentTarget: { - value: undefined, - }, -}; - describe("Sam extension", () => { let component: SamExtension; diff --git a/src/ui-kit/form-templates/international-phone/sam-telephone/telephone.spec.ts b/src/ui-kit/form-templates/international-phone/sam-telephone/telephone.spec.ts index 1624fa881..c8d1dc54b 100755 --- a/src/ui-kit/form-templates/international-phone/sam-telephone/telephone.spec.ts +++ b/src/ui-kit/form-templates/international-phone/sam-telephone/telephone.spec.ts @@ -53,8 +53,6 @@ describe("Sam Telephone Component", () => { it("should use international validation if country code\ is not 1", () => { - const expected = "1234567890123456"; // Len > 15 fails - component.countryCode = 44; expect("").not.toBeNull(); diff --git a/src/ui-kit/form-templates/name-entry/name-entry.component.ts b/src/ui-kit/form-templates/name-entry/name-entry.component.ts index 435de4602..58fab881b 100755 --- a/src/ui-kit/form-templates/name-entry/name-entry.component.ts +++ b/src/ui-kit/form-templates/name-entry/name-entry.component.ts @@ -1,5 +1,4 @@ import { Component, Input, forwardRef } from "@angular/core"; -import { LabelWrapper } from "../../wrappers/label-wrapper"; //import * as suffixes from './suffixes.json'; import { NameEntryType } from "../../types"; import { @@ -8,8 +7,6 @@ import { Validator, ControlValueAccessor, FormControl, - Validators, - ValidatorFn, } from "@angular/forms"; const suffixes = [ @@ -196,7 +193,8 @@ export class SamNameEntryComponent implements ControlValueAccessor, Validator { // validates the form, returns null when valid else the validation object // in this case we're checking if the json parsing has passed or failed from // the onChange method - public validate(c: FormControl) { + public validate(c?: FormControl) { + void c; const obj: any = {}; if (!this.validateFirstName()) { obj.firstName = { diff --git a/src/ui-kit/form-templates/name-entry/name-entry.spec.ts b/src/ui-kit/form-templates/name-entry/name-entry.spec.ts index 0041a8ec9..0dd78ff95 100755 --- a/src/ui-kit/form-templates/name-entry/name-entry.spec.ts +++ b/src/ui-kit/form-templates/name-entry/name-entry.spec.ts @@ -1,8 +1,7 @@ -import { TestBed, waitForAsync, fakeAsync, tick } from "@angular/core/testing"; +import { TestBed, fakeAsync, tick } from "@angular/core/testing"; // Load the implementations that should be tested import { SamNameEntryComponent } from "./name-entry.component"; -import { SamUIKitModule } from "../../index"; import { SamFormService } from "../../form-service"; import { SamWrapperModule } from "../../wrappers"; import { FormsModule, FormControl } from "@angular/forms"; @@ -29,7 +28,7 @@ describe("The Sam Name Entry component", () => { component.setDisabledState(false); component.onChange(); component.onTouched(); - component.registerOnChange((_) => undefined); + component.registerOnChange(() => undefined); component.registerOnTouched(() => undefined); component.modelChange(); // triggers ontouched,onchanged const mockValue = { diff --git a/src/ui-kit/form-templates/phone-entry/phone-entry.component.ts b/src/ui-kit/form-templates/phone-entry/phone-entry.component.ts index 42b433296..8b7f8f085 100755 --- a/src/ui-kit/form-templates/phone-entry/phone-entry.component.ts +++ b/src/ui-kit/form-templates/phone-entry/phone-entry.component.ts @@ -14,9 +14,6 @@ import { NG_VALUE_ACCESSOR, ControlValueAccessor, AbstractControl, - FormControl, - Validators, - ValidatorFn, } from "@angular/forms"; import { SamFormService } from "../../form-service"; diff --git a/src/ui-kit/layout-deprecated/form-only-page.spec.ts b/src/ui-kit/layout-deprecated/form-only-page.spec.ts index 07b397742..9e4a40d3c 100755 --- a/src/ui-kit/layout-deprecated/form-only-page.spec.ts +++ b/src/ui-kit/layout-deprecated/form-only-page.spec.ts @@ -1,9 +1,7 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; -import { Component } from "@angular/core"; // Load the implementations that should be tested import { FormOnlyPageTemplateComponent } from "./form-only-page.component"; -import { By } from "@angular/platform-browser"; import { GridDirective } from "./grid/grid.directive"; import { ColumnDirective } from "./grid/column.directive"; import { RowDirective } from "./grid/row.directive"; @@ -12,7 +10,6 @@ import { SamBadgeComponent } from "../components/badge"; describe("FormOnlyPageTemplate component", () => { describe("rendered tests", () => { - let component: FormOnlyPageTemplateComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -29,7 +26,6 @@ describe("FormOnlyPageTemplate component", () => { }); fixture = TestBed.createComponent(FormOnlyPageTemplateComponent); - component = fixture.componentInstance; fixture.detectChanges(); }); diff --git a/src/ui-kit/layout-deprecated/grid/column.spec.ts b/src/ui-kit/layout-deprecated/grid/column.spec.ts index 7a4b03070..fbb8c97f5 100755 --- a/src/ui-kit/layout-deprecated/grid/column.spec.ts +++ b/src/ui-kit/layout-deprecated/grid/column.spec.ts @@ -1,4 +1,4 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { Component } from "@angular/core"; // Load the implementations that should be tested @@ -13,7 +13,6 @@ class TestComponent {} describe("Column Directive", () => { describe("rendered tests", () => { - let component: TestComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -23,7 +22,6 @@ describe("Column Directive", () => { }); fixture = TestBed.createComponent(TestComponent); - component = fixture.componentInstance; }); it("Get column class value", function () { diff --git a/src/ui-kit/layout-deprecated/grid/grid.directive.ts b/src/ui-kit/layout-deprecated/grid/grid.directive.ts index 9728d5c63..dc48bf768 100755 --- a/src/ui-kit/layout-deprecated/grid/grid.directive.ts +++ b/src/ui-kit/layout-deprecated/grid/grid.directive.ts @@ -1,4 +1,4 @@ -import { Directive, ElementRef, Renderer2, Input } from "@angular/core"; +import { Directive, ElementRef, Renderer2 } from "@angular/core"; @Directive({ selector: "[grid]", diff --git a/src/ui-kit/layout-deprecated/grid/grid.spec.ts b/src/ui-kit/layout-deprecated/grid/grid.spec.ts index d3a4da545..fd47f34e1 100755 --- a/src/ui-kit/layout-deprecated/grid/grid.spec.ts +++ b/src/ui-kit/layout-deprecated/grid/grid.spec.ts @@ -1,4 +1,4 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { Component } from "@angular/core"; // Load the implementations that should be tested @@ -13,7 +13,6 @@ class TestComponent {} describe("Grid Directive", () => { describe("rendered tests", () => { - let component: TestComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -23,7 +22,6 @@ describe("Grid Directive", () => { }); fixture = TestBed.createComponent(TestComponent); - component = fixture.componentInstance; }); it("Get grid class value", function () { diff --git a/src/ui-kit/layout-deprecated/grid/row.directive.ts b/src/ui-kit/layout-deprecated/grid/row.directive.ts index 34e87f49f..7a020c06a 100755 --- a/src/ui-kit/layout-deprecated/grid/row.directive.ts +++ b/src/ui-kit/layout-deprecated/grid/row.directive.ts @@ -1,4 +1,4 @@ -import { Directive, ElementRef, Renderer2, Input } from "@angular/core"; +import { Directive, ElementRef, Renderer2 } from "@angular/core"; @Directive({ selector: "[row]", diff --git a/src/ui-kit/layout-deprecated/grid/row.spec.ts b/src/ui-kit/layout-deprecated/grid/row.spec.ts index 7c99f2491..7a42b8eb8 100755 --- a/src/ui-kit/layout-deprecated/grid/row.spec.ts +++ b/src/ui-kit/layout-deprecated/grid/row.spec.ts @@ -1,4 +1,4 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { Component } from "@angular/core"; // Load the implementations that should be tested @@ -13,7 +13,6 @@ class TestComponent {} describe("Row Directive", () => { describe("rendered tests", () => { - let component: TestComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -23,7 +22,6 @@ describe("Row Directive", () => { }); fixture = TestBed.createComponent(TestComponent); - component = fixture.componentInstance; }); it("Get row class value", function () { diff --git a/src/ui-kit/layout-deprecated/list-results-message.spec.ts b/src/ui-kit/layout-deprecated/list-results-message.spec.ts index f41ee00b7..e9f79fd5b 100755 --- a/src/ui-kit/layout-deprecated/list-results-message.spec.ts +++ b/src/ui-kit/layout-deprecated/list-results-message.spec.ts @@ -1,8 +1,6 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; -import { Component } from "@angular/core"; // Load the implementations that should be tested -import { By } from "@angular/platform-browser"; import { ListResultsMessageComponent } from "./list-results-message"; describe("ListResultsMessage component", () => { diff --git a/src/ui-kit/layout-deprecated/page.service.spec.ts b/src/ui-kit/layout-deprecated/page.service.spec.ts index 425aa8e65..3bb2ae775 100755 --- a/src/ui-kit/layout-deprecated/page.service.spec.ts +++ b/src/ui-kit/layout-deprecated/page.service.spec.ts @@ -1,9 +1,3 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; - -import { Component } from "@angular/core"; -import { RouterTestingModule } from "@angular/router/testing"; -// Load the implementations that should be tested -import { By } from "@angular/platform-browser"; import { PageService } from "./page.service"; describe("PageService", () => { diff --git a/src/ui-kit/layout-deprecated/page.spec.ts b/src/ui-kit/layout-deprecated/page.spec.ts index dcb4bb20a..f2ebdea6f 100755 --- a/src/ui-kit/layout-deprecated/page.spec.ts +++ b/src/ui-kit/layout-deprecated/page.spec.ts @@ -1,9 +1,7 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; -import { Component } from "@angular/core"; import { RouterTestingModule } from "@angular/router/testing"; // Load the implementations that should be tested -import { By } from "@angular/platform-browser"; import { PageTemplateComponent } from "./page.component"; import { SamStickyComponent } from "../directives/sticky/sticky.component"; import { SamSidenavModule } from "../components/sidenav"; @@ -19,7 +17,6 @@ import { SamElementsModule } from "../elements"; describe("PageTemplateComponent component", () => { describe("rendered tests", () => { - let component: PageTemplateComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -41,12 +38,10 @@ describe("PageTemplateComponent component", () => { }); fixture = TestBed.createComponent(PageTemplateComponent); - component = fixture.componentInstance; fixture.detectChanges(); }); it("should initialize", function () { - const text = fixture.debugElement.nativeElement.textContent; expect(true).toBe(true); }); }); diff --git a/src/ui-kit/layout-deprecated/pages/form-step.spec.ts b/src/ui-kit/layout-deprecated/pages/form-step.spec.ts index a9409afdb..11068ed44 100755 --- a/src/ui-kit/layout-deprecated/pages/form-step.spec.ts +++ b/src/ui-kit/layout-deprecated/pages/form-step.spec.ts @@ -1,10 +1,8 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { RouterTestingModule } from "@angular/router/testing"; -import { Component } from "@angular/core"; // Load the implementations that should be tested import { FormStepComponent } from "./form-step.component"; -import { By } from "@angular/platform-browser"; import { SamStickyComponent } from "../../directives/sticky/sticky.component"; import { SamSidenavModule } from "../../components/sidenav"; import { SamBreadcrumbsComponent } from "../../components/breadcrumbs"; diff --git a/src/ui-kit/layout-deprecated/results.spec.ts b/src/ui-kit/layout-deprecated/results.spec.ts index cbb659fd4..8c531ad26 100755 --- a/src/ui-kit/layout-deprecated/results.spec.ts +++ b/src/ui-kit/layout-deprecated/results.spec.ts @@ -1,15 +1,12 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; -import { Component } from "@angular/core"; // Load the implementations that should be tested import { ResultsTemplateComponent } from "./results.component"; import { ListResultsMessageComponent } from "./list-results-message"; import { SamPaginationComponent } from "../components/pagination"; -import { By } from "@angular/platform-browser"; describe("ResultsTemplateComponent component", () => { describe("rendered tests", () => { - let component: ResultsTemplateComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -23,7 +20,6 @@ describe("ResultsTemplateComponent component", () => { }); fixture = TestBed.createComponent(ResultsTemplateComponent); - component = fixture.componentInstance; fixture.detectChanges(); }); diff --git a/src/ui-kit/layout-deprecated/sidebar.spec.ts b/src/ui-kit/layout-deprecated/sidebar.spec.ts index bf90dd62c..5bf71b4ee 100755 --- a/src/ui-kit/layout-deprecated/sidebar.spec.ts +++ b/src/ui-kit/layout-deprecated/sidebar.spec.ts @@ -1,14 +1,11 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; -import { Component } from "@angular/core"; // Load the implementations that should be tested import { SidebarTemplateComponent } from "./sidebar.component"; import { PageService } from "./page.service"; -import { By } from "@angular/platform-browser"; describe("SidebarTemplateComponent component", () => { describe("rendered tests", () => { - let component: SidebarTemplateComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -19,7 +16,6 @@ describe("SidebarTemplateComponent component", () => { }); fixture = TestBed.createComponent(SidebarTemplateComponent); - component = fixture.componentInstance; fixture.detectChanges(); }); diff --git a/src/ui-kit/layout-deprecated/title-and-section.spec.ts b/src/ui-kit/layout-deprecated/title-and-section.spec.ts index 22b49d88e..a3cfae0fd 100755 --- a/src/ui-kit/layout-deprecated/title-and-section.spec.ts +++ b/src/ui-kit/layout-deprecated/title-and-section.spec.ts @@ -1,15 +1,12 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; -import { Component } from "@angular/core"; // Load the implementations that should be tested import { TitleAndSectionComponent } from "./title-and-section.component"; -import { By } from "@angular/platform-browser"; import { SamBadgeComponent } from "../components/badge"; import { SamElementsModule } from "../elements"; describe("TitleAndSectionComponent component", () => { describe("rendered tests", () => { - let component: TitleAndSectionComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -20,7 +17,6 @@ describe("TitleAndSectionComponent component", () => { }); fixture = TestBed.createComponent(TitleAndSectionComponent); - component = fixture.componentInstance; fixture.detectChanges(); }); diff --git a/src/ui-kit/layout-deprecated/workspace/workspace-template.spec.ts b/src/ui-kit/layout-deprecated/workspace/workspace-template.spec.ts index a8dec4ea5..aef88d3d1 100755 --- a/src/ui-kit/layout-deprecated/workspace/workspace-template.spec.ts +++ b/src/ui-kit/layout-deprecated/workspace/workspace-template.spec.ts @@ -1,13 +1,10 @@ -import { TestBed, waitForAsync } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; -import { Component } from "@angular/core"; // Load the implementations that should be tested import { WorkspaceTemplateComponent } from "./workspace-template.component"; -import { By } from "@angular/platform-browser"; describe("Workspace template component", () => { describe("rendered tests", () => { - let component: WorkspaceTemplateComponent; let fixture: any; // provide our implementations or mocks to the dependency injector @@ -17,7 +14,6 @@ describe("Workspace template component", () => { }); fixture = TestBed.createComponent(WorkspaceTemplateComponent); - component = fixture.componentInstance; fixture.detectChanges(); }); diff --git a/src/ui-kit/layout/filter-drawer/filter-drawer.component.ts b/src/ui-kit/layout/filter-drawer/filter-drawer.component.ts index e00ab2478..f46cc2175 100755 --- a/src/ui-kit/layout/filter-drawer/filter-drawer.component.ts +++ b/src/ui-kit/layout/filter-drawer/filter-drawer.component.ts @@ -8,8 +8,6 @@ import { ViewChild, } from "@angular/core"; -import { SamPageNextService } from "../../experimental/patterns/layout/architecture"; - import { ChipHostDirective } from "./chip-host"; import { SamFilterDrawerItemComponent } from "./filter-drawer-item"; diff --git a/src/ui-kit/layout/filters-wrapper/filters-wrapper.component.ts b/src/ui-kit/layout/filters-wrapper/filters-wrapper.component.ts index 81995016d..f81969917 100755 --- a/src/ui-kit/layout/filters-wrapper/filters-wrapper.component.ts +++ b/src/ui-kit/layout/filters-wrapper/filters-wrapper.component.ts @@ -1,7 +1,7 @@ import { Component, Input, OnInit, OnDestroy, Optional } from "@angular/core"; import { FormGroup } from "@angular/forms"; -import { Observable, Subject, Subscription, combineLatest } from "rxjs"; +import { Subject, Subscription, combineLatest } from "rxjs"; import { SamPageNextService } from "../../experimental/patterns/layout/architecture"; import { areEqual } from "../../utilities"; @@ -69,7 +69,7 @@ export class SamFiltersWrapperComponent implements OnInit, OnDestroy { } private _initializeHandlers() { - this._runReportSubscription = this.runReportEvent.subscribe((_) => { + this._runReportSubscription = this.runReportEvent.subscribe(() => { if (this._service) { this._service.model.properties["filters"].setValue(this.group.value); } @@ -110,7 +110,7 @@ export class SamFiltersWrapperComponent implements OnInit, OnDestroy { ].valueChanges.subscribe((event) => { try { this.group.setValue(event, { emitEvent: false }); - } catch (e) { + } catch { return; } }); diff --git a/src/ui-kit/layout/footer/footer.component.spec.ts b/src/ui-kit/layout/footer/footer.component.spec.ts index 36da517c7..4bb327c3c 100755 --- a/src/ui-kit/layout/footer/footer.component.spec.ts +++ b/src/ui-kit/layout/footer/footer.component.spec.ts @@ -1,11 +1,5 @@ /* tslint:disable */ -import { - waitForAsync, - ComponentFixture, - TestBed, - fakeAsync, - tick, -} from "@angular/core/testing"; +import { waitForAsync, ComponentFixture, TestBed } from "@angular/core/testing"; import { SdsFooterComponent } from "./footer.component"; import { RouterTestingModule } from "@angular/router/testing"; diff --git a/src/ui-kit/layout/header/header.component.spec.ts b/src/ui-kit/layout/header/header.component.spec.ts index a563f7ae8..8fba414d4 100755 --- a/src/ui-kit/layout/header/header.component.spec.ts +++ b/src/ui-kit/layout/header/header.component.spec.ts @@ -1,11 +1,5 @@ /* tslint:disable */ -import { - waitForAsync, - ComponentFixture, - TestBed, - fakeAsync, - tick, -} from "@angular/core/testing"; +import { waitForAsync, ComponentFixture, TestBed } from "@angular/core/testing"; import { SdsHeaderComponent } from "./header.component"; import { RouterTestingModule } from "@angular/router/testing"; diff --git a/src/ui-kit/layout/page/pagination.component.spec.ts b/src/ui-kit/layout/page/pagination.component.spec.ts index f82ac5c4e..080fc8309 100755 --- a/src/ui-kit/layout/page/pagination.component.spec.ts +++ b/src/ui-kit/layout/page/pagination.component.spec.ts @@ -1,7 +1,6 @@ import { TestBed, waitForAsync, ComponentFixture } from "@angular/core/testing"; import { FormsModule } from "@angular/forms"; -import { RouterTestingModule } from "@angular/router/testing"; import { By } from "@angular/platform-browser"; import {} from "../../"; import { diff --git a/src/ui-kit/layout/pagination/pagination.component.spec.ts b/src/ui-kit/layout/pagination/pagination.component.spec.ts index 1bec9167a..9a1781ddf 100755 --- a/src/ui-kit/layout/pagination/pagination.component.spec.ts +++ b/src/ui-kit/layout/pagination/pagination.component.spec.ts @@ -3,9 +3,6 @@ import { TestBed, waitForAsync, ComponentFixture } from "@angular/core/testing"; import { SamPaginationNextComponent } from "./pagination.component"; import { FormsModule } from "@angular/forms"; -import { RouterTestingModule } from "@angular/router/testing"; -import { By } from "@angular/platform-browser"; - import { SamIconsModule } from "../../../ui-kit/experimental/icon/icon.module"; import { Paginator } from "./paginator"; @@ -32,7 +29,6 @@ describe("SamPaginationNextComponent", () => { }); it("page size", () => { - const paginator = new Paginator("Test Unit", 10, 100); expect(component.pageSize).toBe(10); }); diff --git a/src/ui-kit/layout/toolbar/toolbar.spec.ts b/src/ui-kit/layout/toolbar/toolbar.spec.ts index 1acfc6b17..d4ebffafd 100755 --- a/src/ui-kit/layout/toolbar/toolbar.spec.ts +++ b/src/ui-kit/layout/toolbar/toolbar.spec.ts @@ -1,11 +1,8 @@ -import { TestBed, ComponentFixture } from "@angular/core/testing"; +import { TestBed } from "@angular/core/testing"; import { SamToolbarsModule, SamToolbarComponent } from "./"; describe("The Sam Toolbar component", () => { describe("rendered tests", () => { - let component: SamToolbarComponent; - let fixture: ComponentFixture; - beforeEach(() => { TestBed.configureTestingModule({ imports: [SamToolbarsModule], @@ -13,8 +10,7 @@ describe("The Sam Toolbar component", () => { providers: [], }); - fixture = TestBed.createComponent(SamToolbarComponent); - component = fixture.componentInstance; + TestBed.createComponent(SamToolbarComponent); }); it("should initialize", () => { diff --git a/src/ui-kit/utilities/key-helper/key-helper.spec.ts b/src/ui-kit/utilities/key-helper/key-helper.spec.ts index a5b6fb0a4..007e8d1b0 100755 --- a/src/ui-kit/utilities/key-helper/key-helper.spec.ts +++ b/src/ui-kit/utilities/key-helper/key-helper.spec.ts @@ -173,8 +173,6 @@ describe("Sam KeyEvent Class", () => { }); describe("Instance methods", () => { - let instance: KeyHelper; - it("Should instantiate with supported keys", () => { const keys = [ "enter", diff --git a/src/ui-kit/wrappers/fieldset-wrapper/fieldset-wrapper.component.ts b/src/ui-kit/wrappers/fieldset-wrapper/fieldset-wrapper.component.ts index ae458beba..50d50a65e 100755 --- a/src/ui-kit/wrappers/fieldset-wrapper/fieldset-wrapper.component.ts +++ b/src/ui-kit/wrappers/fieldset-wrapper/fieldset-wrapper.component.ts @@ -104,7 +104,7 @@ export class FieldsetWrapper } @HostListener("window:resize", ["$event"]) - public onResize(event: UIEvent) { + public onResize() { // needs to be open to recalc correctly in // ngAfterViewChecked this.showToggle = false; diff --git a/src/ui-kit/wrappers/fieldset-wrapper/fieldset-wrapper.spec.ts b/src/ui-kit/wrappers/fieldset-wrapper/fieldset-wrapper.spec.ts index f0f23d5ff..c6377d89b 100755 --- a/src/ui-kit/wrappers/fieldset-wrapper/fieldset-wrapper.spec.ts +++ b/src/ui-kit/wrappers/fieldset-wrapper/fieldset-wrapper.spec.ts @@ -1,11 +1,6 @@ -import { - TestBed, - waitForAsync, - ComponentFixtureAutoDetect, - ComponentFixture, -} from "@angular/core/testing"; -import { Component, ChangeDetectorRef } from "@angular/core"; -import { By } from "@angular/platform-browser"; +import { TestBed, ComponentFixture } from "@angular/core/testing"; +import { ChangeDetectorRef } from "@angular/core"; + import { FormControl, FormGroup } from "@angular/forms"; // Load the implementations that should be tested import { FieldsetWrapper } from "./fieldset-wrapper.component"; diff --git a/src/ui-kit/wrappers/label-wrapper/label-wrapper.component.ts b/src/ui-kit/wrappers/label-wrapper/label-wrapper.component.ts index 4f8a3d65f..f7f07e272 100755 --- a/src/ui-kit/wrappers/label-wrapper/label-wrapper.component.ts +++ b/src/ui-kit/wrappers/label-wrapper/label-wrapper.component.ts @@ -101,7 +101,7 @@ export class LabelWrapper let lookup; try { lookup = this.labelDiv.nativeElement.querySelector(selector); - } catch (exception) { + } catch { console.error(selector + " not found in label wrapper setup"); } if (lookup) { @@ -139,7 +139,7 @@ export class LabelWrapper } @HostListener("window:resize", ["$event"]) - public onResize(event) { + public onResize() { // needs to be open to recalc correctly in // ngAfterViewChecked this.showToggle = false; diff --git a/src/ui-kit/wrappers/label-wrapper/label-wrapper.spec.ts b/src/ui-kit/wrappers/label-wrapper/label-wrapper.spec.ts index 215b42cb9..a3974a14e 100755 --- a/src/ui-kit/wrappers/label-wrapper/label-wrapper.spec.ts +++ b/src/ui-kit/wrappers/label-wrapper/label-wrapper.spec.ts @@ -1,11 +1,5 @@ -import { - TestBed, - waitForAsync, - ComponentFixtureAutoDetect, - ComponentFixture, -} from "@angular/core/testing"; -import { Component, ChangeDetectorRef, Renderer2 } from "@angular/core"; -import { By } from "@angular/platform-browser"; +import { TestBed, ComponentFixture } from "@angular/core/testing"; +import { ChangeDetectorRef, Renderer2 } from "@angular/core"; import { FormControl } from "@angular/forms"; // Load the implementations that should be tested import { LabelWrapper } from "./label-wrapper.component";