Commit abb178c
CI Runner
fix: make CI green — ruff/pyright violations, reflex module resolution, export working-directory
- Split 46 E701/E702 compound one-liners (if/raise, semicolon-chained
statements) across auth_adapter.py, migrations/env.py, 0001_application_spine.py,
analysis.py, auth.py, cli.py, models.py, services.py, worker.py — cosmetic,
no behavior change.
- auth_adapter.py: add missing @rx.event on do_logout (fixes pyright
reportIncompatibleVariableOverride — parent's do_logout is @rx.event,
the override wasn't); capture require()'s return in create_user instead of
discarding it (fixes reportOptionalMemberAccess on principal.user_id, and
was a real narrowing bug, not just a type-checker complaint).
- rxconfig.py: add app_module_import="starter_web.app" — Reflex's default
convention expects starter_web/starter_web.py, but the app lives in
src/starter_web/app.py (src-layout). Without this, `reflex export`/`reflex run`
never worked at all: "Module starter_web.starter_web not found". This was
never caught because no CI run ever got past the earlier ruff/pyright gap
to reach this step.
- ci.yml: add working-directory: apps/web to the reflex export step —
rxconfig.py lives there, not at repo root, so the step 404'd on
"rxconfig.py not found" even with the module fix applied.
- apps/web/.gitignore, apps/web/reflex.lock/: first successful `reflex init`
in this repo's history generated these; committing the lockfile for
reproducible frontend builds (same rationale as uv.lock).
Verified locally: ruff check, pyright, pytest -m "not database", and
reflex export --frontend-only --no-zip (from apps/web) all pass clean.1 parent 8c95eaa commit abb178c
14 files changed
Lines changed: 1250 additions & 28 deletions
File tree
- .github/workflows
- apps/web
- reflex.lock
- src/starter_web
- migrations
- versions
- packages/core/src/starter_core
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | | - | |
| 18 | + | |
| 19 | + | |
18 | 20 | | |
| 21 | + | |
| 22 | + | |
19 | 23 | | |
20 | 24 | | |
21 | 25 | | |
22 | 26 | | |
23 | 27 | | |
24 | | - | |
25 | | - | |
| 28 | + | |
26 | 29 | | |
27 | 30 | | |
28 | 31 | | |
29 | | - | |
| 32 | + | |
| 33 | + | |
30 | 34 | | |
31 | 35 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | | - | |
14 | | - | |
15 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
6 | 11 | | |
7 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
8 | 17 | | |
9 | 18 | | |
10 | | - | |
| 19 | + | |
| 20 | + | |
11 | 21 | | |
12 | 22 | | |
13 | | - | |
| 23 | + | |
| 24 | + | |
0 commit comments