add format workflow and fix formatting#10
Merged
szabo137 merged 2 commits intoJuliaHEP:mainfrom Jul 19, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 35.18% 35.58% +0.39%
==========================================
Files 8 8
Lines 162 163 +1
==========================================
+ Hits 57 58 +1
Misses 105 105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Moelf
approved these changes
Jul 19, 2025
Member
|
Thanks for adding this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository has a JuliaFormatter configuration yet the formatting isn't enforced (if IDE has a format on save enabled then one get's a lot unintentional changes)
Adding a standard formatting workflow for github and fixing changes.
I propose to use JuliaFormatter v1 in the CI since the IDE extensions like vscode are still using it. Luckily for this project JuliaFormatter v1 and v2 produces the same output (for now)
In case you decide to accept this, please consider not-squashing so later the formatting commit can be added to
.git-blame-ignore-revsto avoid polluting git blame