Skip to content

add format workflow and fix formatting#10

Merged
szabo137 merged 2 commits intoJuliaHEP:mainfrom
m-fila:format
Jul 19, 2025
Merged

add format workflow and fix formatting#10
szabo137 merged 2 commits intoJuliaHEP:mainfrom
m-fila:format

Conversation

@m-fila
Copy link
Copy Markdown
Member

@m-fila m-fila commented Jul 19, 2025

The repository has a JuliaFormatter configuration yet the formatting isn't enforced (if IDE has a format on save enabled then one get's a lot unintentional changes)

Adding a standard formatting workflow for github and fixing changes.

I propose to use JuliaFormatter v1 in the CI since the IDE extensions like vscode are still using it. Luckily for this project JuliaFormatter v1 and v2 produces the same output (for now)

In case you decide to accept this, please consider not-squashing so later the formatting commit can be added to .git-blame-ignore-revs to avoid polluting git blame

@m-fila m-fila requested a review from oschulz July 19, 2025 10:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2025

Codecov Report

Attention: Patch coverage is 43.93939% with 37 lines in your changes missing coverage. Please review.

Project coverage is 35.58%. Comparing base (2b757bd) to head (b353f80).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/event_generation/serial.jl 0.00% 14 Missing ⚠️
src/event_generation/threadsafe.jl 0.00% 12 Missing ⚠️
src/events.jl 45.45% 6 Missing ⚠️
ext/HEPExampleProjectMakieExt.jl 0.00% 3 Missing ⚠️
ext/HEPExampleProjectPlotsExt.jl 0.00% 1 Missing ⚠️
src/four_momentum.jl 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   35.18%   35.58%   +0.39%     
==========================================
  Files           8        8              
  Lines         162      163       +1     
==========================================
+ Hits           57       58       +1     
  Misses        105      105              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz oschulz requested a review from Moelf July 19, 2025 14:13
@szabo137
Copy link
Copy Markdown
Member

Thanks for adding this!

@szabo137 szabo137 merged commit fd52eb8 into JuliaHEP:main Jul 19, 2025
11 checks passed
@m-fila m-fila deleted the format branch July 19, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants