From 0cc68fb00bcc83dcfa86a6e0ed241cbd5eb07262 Mon Sep 17 00:00:00 2001 From: Kai Xu Date: Thu, 15 Aug 2019 23:32:43 +0100 Subject: [PATCH 1/2] use similar instead literal to init r --- src/generic.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/generic.jl b/src/generic.jl index 1af118e..6184f0c 100644 --- a/src/generic.jl +++ b/src/generic.jl @@ -209,6 +209,6 @@ function pairwise(metric::PreMetric, a::AbstractMatrix; dims = deprecated_dims(dims) dims in (1, 2) || throw(ArgumentError("dims should be 1 or 2 (got $dims)")) n = size(a, dims) - r = Matrix{result_type(metric, a, a)}(undef, n, n) + r = similar(a, result_type(metric, a, a), n, n) pairwise!(r, metric, a, dims=dims) end From a1b590f5ee137507722a89bb4bbd7399e87ab984 Mon Sep 17 00:00:00 2001 From: Kai Xu Date: Fri, 16 Aug 2019 01:03:12 +0100 Subject: [PATCH 2/2] use similar instead literal to init r --- src/generic.jl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/generic.jl b/src/generic.jl index 6184f0c..a3fed2a 100644 --- a/src/generic.jl +++ b/src/generic.jl @@ -200,7 +200,7 @@ function pairwise(metric::PreMetric, a::AbstractMatrix, b::AbstractMatrix; dims in (1, 2) || throw(ArgumentError("dims should be 1 or 2 (got $dims)")) m = size(a, dims) n = size(b, dims) - r = Matrix{result_type(metric, a, b)}(undef, m, n) + r = similar(a, result_type(metric, a, b), m, n) pairwise!(r, metric, a, b, dims=dims) end