Skip to content

SENSITIVE_HEADERS checks should not be case-sensitive #1237

@Moelf

Description

@Moelf

[Found by ZeroPath and manually checked by me]

elseif (header in SENSITIVE_HEADERS && !isdomainorsubdomain(url.host, oldurl.host))
return false

const SENSITIVE_HEADERS = Set([
"Authorization",
"Www-Authenticate",
"Cookie",
"Cookie2"
])

if there's a header like authorization, we would misjudge it as being not sensitive and forward it, which is a security flaw

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions