Skip to content

Improve nested prototype definitions #3

Description

@MCStreetguy

Describe the bug
Currently, if the debugger encounters a nested prototype definition it cannot handle it properly. Instead, the meta key containing these definitions remains in the otherwise flattened debug-view. This is no real issue as the overview is still correct, but as the information is unstyled it looks really messy...

We have not found a clear remedy to this problem currently. See our thoughts on this below:

  • One option would be to include modified properties if the corresponding prototype is used somewhere below the current level. This could be problematic as nested definitions also apply to furtherly nested prototypes and we would need to pass them around between recursions, which will most likely result in unexpected behaviour in some way.
  • Another possibility would be to append the modifications to the internal prototype definitions but this would introduce a whole new world of complexity, as we would need to differ between nesting-levels within protoype definitions and this would either be very time- or resource-expensive!
  • The third solution would be to simply keep the information where it is, but to style it in some way (colorization, etc.) to make it at least prettier if we cannot integrate it reasonably.

To Reproduce
Steps to reproduce the behavior:

  1. Create some prototype definition
  2. Create a nested prototype definition inside of the freshly created prototype
  3. Have a look at the debug-view of the topmost new prototype

Expected behavior
Nested definitions should not be ignored totally.

Environment (please complete the following information):

  • OS: Ubuntu 16.04
  • Terminal: Bash
  • PHP: 7.0.33-0ubuntu0.16.04.5
  • Flow: v4.3.19
  • Neos: v3.3.24

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions