Duplicate aiui launcher logic in cli/commands/ui.py default callback

[MervinPraison]

Summary

cli/commands/ui.py defines a reusable _launch_aiui_app() helper, but the default ui() callback re-implements the same install-check, app-file resolution and subprocess-launch logic inline instead of calling it. The two copies are textually near-identical, so a fix to one (e.g. the install hint or the aiui→python -m praisonaiui.cli fallback) silently misses the other.

Current behaviour

Code citations from src/praisonai/praisonai/cli/commands/ui.py:

• cli/commands/ui.py:45-108 — _launch_aiui_app(...): checks importlib.util.find_spec("praisonaiui"), resolves the app file, runs ["aiui", "run", ...], and falls back to [sys.executable, "-m", "praisonaiui.cli", ...].
• cli/commands/ui.py:~138-181 — the default ui() callback (when ctx.invoked_subcommand is None) repeats the identical install check, app-file resolution and the same subprocess launch + fallback block.

Why it matters

Maintenance / duplication. The default praisonai ui path and the helper used by the sub-commands (ui agents, ui bot, ui realtime) can drift apart; a bug fixed in one launch path remains in the other.

Category

Duplicate

Capability preserved

praisonai ui and all ui sub-commands continue to work exactly as today, including the praisonaiui install check, custom --app handling, default-app bootstrap, --port/--host/--reload, and the aiui→python -m praisonaiui.cli fallback.

Proposed approach

Merge. Replace the inline block in the ui() callback with a single call to the existing _launch_aiui_app(...), passing the chat defaults. Behaviour is identical; the callback already holds every argument the helper needs.

Resolution sketch

# Before — inline duplicate inside ui() callback
if ctx.invoked_subcommand is not None:
    return
# ...install check... resolve app file... subprocess.run(["aiui","run",...]) + fallback...

# After — delegate to the existing helper
if ctx.invoked_subcommand is not None:
    return
_launch_aiui_app("ui_chat", "ui_chat", port, host, app_file, reload, "Chat")

(If the callback's bespoke _ensure_default_app() resolution must be retained, fold that one difference into _launch_aiui_app behind a parameter so a single function owns the launch path.)

Layer placement

• Primary layer: wrapper
• Touches core/tools/plugins (optional): none
• 3-way surface (CLI + YAML + Python): CLI only (UI launch command); preserved yes

Severity

Low — small, contained duplication; no runtime cost, purely maintenance.

Validation

Traced: both blocks read in full; install check, command vector and fallback are identical bar minor formatting and the _ensure_default_app() vs bundled-copy detail. Not intentional robustness. No user-facing change.

Keep unchanged

Keep the praisonaiui install check and its pip install "praisonai[ui]" hint, the aiui→module fallback, the per-UI sub-commands (agents, bot, chat, realtime, dashboard), and the bundled default_app.py bootstrap behaviour.

[praisonai-triage-agent]

Claude finished @MervinPraison's task —— View job • claude/issue-2253-20260624-1609 • [Create PR ➔](https://github.com/MervinPraison/PraisonAI/compare/main...claude/issue-2253-20260624-1609?quick_pull=1&title=Issue%20%232253%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%232253%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)

---

Issue #2253 — Duplicate aiui launcher logic resolved ✅

• Read AGENTS.md guidelines
• Read cli/commands/ui.py to understand the duplication
• Implement the fix (merge inline block into _launch_aiui_app)
• Test changes (syntax + delegation checks pass)
• Commit, push, and create PR

What changed

src/praisonai/praisonai/cli/commands/ui.py:

• The default ui() callback (ui.py:137-180) re-implemented the install-check, app-file resolution and subprocess launch/fallback already present in _launch_aiui_app(). Replaced that inline block with a single delegating call:

  _launch_aiui_app("ui", "ui_chat", port, host, app_file, reload, "Chat")

• Removed the now-unused _ensure_default_app() helper and its UI_DIR/DEFAULT_APP constants (these existed only to serve that inline block; claw.py keeps its own copy, untouched).

Net: 1 insertion, 62 deletions — a single function now owns the launch path.

Behaviour preserved

• praisonaiui install check + pip install "praisonai[ui]" hint
• Custom --app handling and --port/--host/--reload
• Chat UI still resolves to ~/.praisonai/ui/app.py from bundled ui_chat/default_app.py (matched the old _ensure_default_app path/source exactly via app_dir="ui", default_app_name="ui_chat")
• aiui → python -m praisonaiui.cli fallback
• Sub-commands (agents, bot, realtime) unchanged — already used the helper

Note: the bundled-config creation message now reads ✓ Created default Chat config (helper format) instead of ... chat config — cosmetic only.

PR: #2256
• Branch: claude/issue-2253-20260624-1609