Makefile.inc1: fix intermittent libmagic build failure under high parallelism

[laffer1]

Summary

• Adds missing lib/libmagic__L: lib/libz__L dependency in Makefile.inc1
• lib/libmagic/Makefile has LIBADD= z but no __L ordering constraint was declared
• Under high parallelism (make -j28) the linker step for libmagic.so.4.full can race ahead of libz being installed into the sysroot

Observed failure:

ld: error: unable to find library -lz
cc: error: linker command failed with exit code 1
*** [libmagic.so.4.full] Error code 1

Same fix already merged to stable/4.0 in PR #399.

Test plan

• make -j28 buildworld on amd64 — confirm lib/libmagic builds cleanly
• make -j4 buildworld — confirm no regression at lower parallelism

🤖 Generated with Claude Code

Summary by Sourcery

Bug Fixes:

• Declare libmagic’s dependency on libz to prevent intermittent linker failures when building with high parallelism.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds a missing build dependency to ensure libmagic is linked only after libz is available, preventing intermittent link-time failures under high parallelism.

File-Level Changes

Change	Details	Files
Add explicit build dependency so libmagic links after libz, avoiding -lz not found errors in highly parallel builds.	Declare lib/libmagic__L to depend on lib/libz__L in the top-level build dependency graph Aligns make(1) library install/link ordering with existing LIBADD=z usage in lib/libmagic/Makefile Prevents the libmagic.so.4.full link step from racing ahead of libz being installed into the sysroot under make -jN	Makefile.inc1

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Code Review

This pull request updates Makefile.inc1 to add a dependency of lib/libmagic__L on lib/libz__L. There are no review comments to evaluate, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[github-actions]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[sourcery-ai]

Hey - I've left some high level feedback:

• Since this fixes an ordering race for libmagic vs libz, it’s worth scanning/grepping Makefile.inc1 for other libraries that have LIBADD entries in their own Makefiles but lack corresponding __L dependency edges to catch any similar parallel build races.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Since this fixes an ordering race for libmagic vs libz, it’s worth scanning/grepping Makefile.inc1 for other libraries that have LIBADD entries in their own Makefiles but lack corresponding __L dependency edges to catch any similar parallel build races.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}