Skip to content

Fix gh 197#198

Merged
scal444 merged 3 commits into
NVIDIA-BioNeMo:mainfrom
scal444:fix_gh_196
Jun 8, 2026
Merged

Fix gh 197#198
scal444 merged 3 commits into
NVIDIA-BioNeMo:mainfrom
scal444:fix_gh_196

Conversation

@scal444

@scal444 scal444 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator

Zero out a buffer that needed to be zero'd out every thread iteration, not just at the beginning of the batch. Wrote a reliable reproducer.

@scal444 scal444 requested a review from evasnow1992 June 6, 2026 12:01
@scal444

scal444 commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator Author

Fixes #197

@evasnow1992 evasnow1992 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Changes look good to me.

@scal444 scal444 merged commit 4f897f3 into NVIDIA-BioNeMo:main Jun 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants