Remove ament_target_dependencies to match ROS 2 Rolling

[bmchalenv]

Apparently ROS 2 on rolling is fully deprecating ament_target_dependencies 😮 #572

Update the Cmakelist to do the same. Recently in Jan 2026 it was fully removed. The post I linked is the reasons for doing it.

[greptile-apps]

Greptile Summary

This PR changes the CMake linking approach from ROS 2's ament_target_dependencies() to standard CMake target_link_libraries() using ${package_TARGETS} variables. It also removes the explicit find_package(ament_cmake REQUIRED) line that was added in commit 0c10299.

Key changes:

• Replaced all ament_target_dependencies() calls with target_link_libraries() using ${package_TARGETS} variables (e.g., ${rclcpp_TARGETS}, ${std_msgs_TARGETS})
• Removed explicit find_package(ament_cmake REQUIRED) statement
• Applied the pattern consistently across all executables and test targets

Concerns:

• PR title is misleading: Title says "Add ament_cmake as package" but the PR actually removes the explicit find_package(ament_cmake REQUIRED) line
• Deviates from ROS 2 conventions: Standard ROS 2 practice is to use ament_target_dependencies() which properly handles dependencies across different ROS 2 versions
• Reliance on ${package_TARGETS} variables: Assumes all dependencies export these CMake variables, which may not be universally true
• The commit message "Test new target link libraries" suggests this is experimental

Confidence Score: 3/5

• This PR may work but introduces unconventional CMake patterns that deviate from ROS 2 best practices
• Score reflects concerns about deviating from standard ROS 2 build patterns. While the code may compile and run, using target_link_libraries() with ${package_TARGETS} instead of ament_target_dependencies() is non-standard and could cause issues with packages that don't export TARGETS variables. The misleading PR title and removal of explicit ament_cmake dependency also raise questions about the approach.
• greenwave_monitor/CMakeLists.txt requires attention - verify that the build succeeds and all package dependencies properly export ${package_TARGETS} variables

Important Files Changed

Filename	Overview
greenwave_monitor/CMakeLists.txt	Replaced ament_target_dependencies() with target_link_libraries() using ${package_TARGETS} variables; removed explicit find_package(ament_cmake REQUIRED) line

_{Last reviewed commit: 834eb64}

[greptile-apps]

_{1 file reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Changed from ament_target_dependencies() to target_link_libraries() with ${package_TARGETS} variables. This deviates from standard ROS 2 practice. ament_target_dependencies() is the recommended approach as it properly handles include directories, link libraries, and compile definitions across different ROS 2 versions.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

[sgillen]

ament_target_dependencies is deprecated, so we need to switch.

[greptile-apps]

Additional Comments (1)

greenwave_monitor/CMakeLists.txt
The explicit find_package(ament_cmake REQUIRED) added in commit 0c10299 was removed. While ament_cmake_auto provides ament_cmake transitively, explicit dependencies are clearer, especially since ament_package() (line 195) comes from ament_cmake.

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}