Skip to content

Conversation

@jberchtold-nvidia
Copy link
Collaborator

Description

HF "glue" dataset seems to have moved from "glue" to "nyu-mll/glue". Small PR to update this dataset path as we've started to see 404 errors

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Use "nyu-mll/glue" instead of "glue" dataset path

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 26, 2026

Greptile Overview

Greptile Summary

This PR updates HuggingFace dataset paths in JAX examples to fix 404 errors. The GLUE dataset moved from "glue" to "nyu-mll/glue" and MNIST from "mnist" to "ylecun/mnist".

  • Updated 4 encoder test files to use "nyu-mll/glue" instead of "glue" for loading the CoLA dataset
  • Updated MNIST test file to use "ylecun/mnist" instead of "mnist"
  • Changes are minimal, only affecting dataset path strings in load_dataset() calls
  • All other functionality remains unchanged

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward dataset path updates that fix broken dataset loading. The modifications only affect string literals in load_dataset() calls without any logic changes. This is a simple bug fix that addresses HuggingFace dataset repository relocations.
  • No files require special attention

Important Files Changed

Filename Overview
examples/jax/encoder/test_single_gpu_encoder.py Updated dataset path from "glue" to "nyu-mll/glue" to fix 404 errors
examples/jax/encoder/test_multigpu_encoder.py Updated dataset path from "glue" to "nyu-mll/glue" to fix 404 errors
examples/jax/encoder/test_multiprocessing_encoder.py Updated dataset path from "glue" to "nyu-mll/glue" to fix 404 errors
examples/jax/encoder/test_model_parallel_encoder.py Updated dataset path from "glue" to "nyu-mll/glue" to fix 404 errors
examples/jax/mnist/test_single_gpu_mnist.py Updated dataset path from "mnist" to "ylecun/mnist" to fix 404 errors

Sequence Diagram

sequenceDiagram
    participant Test as Test Script
    participant HF as HuggingFace Hub
    participant Dataset as Dataset Loader
    participant Model as JAX Model
    
    Note over Test,HF: Before Fix (404 Error)
    Test->>Dataset: load_dataset("glue", "cola")
    Dataset->>HF: Request "glue" dataset
    HF-->>Dataset: 404 Not Found
    Dataset-->>Test: Error
    
    Note over Test,HF: After Fix (Success)
    Test->>Dataset: load_dataset("nyu-mll/glue", "cola")
    Dataset->>HF: Request "nyu-mll/glue" dataset
    HF-->>Dataset: Dataset data
    Dataset-->>Test: Loaded dataset
    Test->>Model: Train/evaluate with dataset
    Model-->>Test: Results
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

…error

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
@jberchtold-nvidia jberchtold-nvidia force-pushed the jberchtold/fix-glue-cola-dataset-name branch from bc3729d to 4c8eb15 Compare January 26, 2026 21:35
@jberchtold-nvidia
Copy link
Collaborator Author

/te-ci L0 jax

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

timmoon10
timmoon10 previously approved these changes Jan 27, 2026
Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jeremy Berchtold <jberchtold@nvidia.com>
@jberchtold-nvidia
Copy link
Collaborator Author

/te-ci L0 jax

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants