From a005ea89947138fe7631582ab20354f2b168b7bb Mon Sep 17 00:00:00 2001 From: JsDataRocks Date: Sun, 16 Aug 2026 17:20:06 -0300 Subject: [PATCH 1/2] fix(android): inset modal close button below status bar --- resources/android/ModalRenderer.kt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resources/android/ModalRenderer.kt b/resources/android/ModalRenderer.kt index d651223..deb5787 100644 --- a/resources/android/ModalRenderer.kt +++ b/resources/android/ModalRenderer.kt @@ -11,6 +11,7 @@ import androidx.compose.foundation.layout.Row import androidx.compose.foundation.layout.fillMaxSize import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.padding +import androidx.compose.foundation.layout.statusBarsPadding import androidx.compose.material.icons.Icons import androidx.compose.material.icons.filled.Close import androidx.compose.material3.Icon @@ -85,7 +86,10 @@ object ModalRenderer { Column(modifier = Modifier.fillMaxSize()) { if (dismissible) { Row( - modifier = Modifier.fillMaxWidth().padding(8.dp), + modifier = Modifier + .fillMaxWidth() + .statusBarsPadding() + .padding(8.dp), horizontalArrangement = Arrangement.End, ) { IconButton(onClick = { From c19915beedd202091f393566dc723a3da36b28b9 Mon Sep 17 00:00:00 2001 From: JsDataRocks Date: Sun, 30 Aug 2026 10:59:06 -0300 Subject: [PATCH 2/2] test(android): cover modal close button status bar inset --- tests/ModalRendererTest.php | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 tests/ModalRendererTest.php diff --git a/tests/ModalRendererTest.php b/tests/ModalRendererTest.php new file mode 100644 index 0000000..146a652 --- /dev/null +++ b/tests/ModalRendererTest.php @@ -0,0 +1,17 @@ +toBeFile(); + + $renderer = file_get_contents($rendererPath); + $closeButtonModifierPattern = '/if \(dismissible\) \{\s*Row\(\s*modifier = Modifier\s*' + .'\.fillMaxWidth\(\)\s*' + .'\.statusBarsPadding\(\)\s*' + .'\.padding\(8\.dp\),/s'; + + expect($renderer) + ->toBeString() + ->toMatch($closeButtonModifierPattern); +});