From a4eda6b3f92351be72319d676b9e45af9b5bad8c Mon Sep 17 00:00:00 2001 From: martincostello Date: Wed, 17 Jun 2026 13:21:31 +0100 Subject: [PATCH 1/2] GitHub Actions workflow fixes - Fix CodeQL query pack. - Fix shellcheck warning. - Do not fail all CI jobs if one fails. Contributes to #814. --- .github/workflows/codeql.yml | 1 - .github/workflows/node.js.yml | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 3f437c2a..f5a6c312 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -41,7 +41,6 @@ jobs: uses: github/codeql-action/init@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2 with: languages: ${{ matrix.language }} - queries: security - name: Perform CodeQL Analysis uses: github/codeql-action/analyze@8aad20d150bbac5944a9f9d289da16a4b0d87c1e # v4.36.2 diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index ebc3bb65..cd1a239b 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -22,6 +22,7 @@ jobs: contents: read strategy: + fail-fast: false matrix: node-version: [14.x, 16.x, 18.x, 20.x, 22.x] @@ -38,7 +39,7 @@ jobs: package-manager-cache: false - name: Set PUBLISH_PLEASE_DISABLE_PROMPT - run: echo "PUBLISH_PLEASE_DISABLE_PROMPT=true" >> $GITHUB_ENV + run: echo "PUBLISH_PLEASE_DISABLE_PROMPT=true" >> "${GITHUB_ENV}" - name: Install dependencies run: npm install --ignore-scripts From a2588591c0692d4707bc93de508d7523dc96fa42 Mon Sep 17 00:00:00 2001 From: martincostello Date: Wed, 17 Jun 2026 13:23:19 +0100 Subject: [PATCH 2/2] Fix concurrency Include the matrix node version in the group name. --- .github/workflows/node.js.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index cd1a239b..baeceaff 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -15,7 +15,7 @@ jobs: timeout-minutes: 10 concurrency: - group: ${{ github.workflow }}-${{ github.sha }} + group: ${{ github.workflow }}-${{ github.sha }}-${{ matrix.node-version }} cancel-in-progress: false permissions: