Make storeDir a part of UnkeyedValidPathInfo
#14707
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous commit hacked it into the output of `nix path-info --json`, this cleans that up my making it an actual field of that data type, and part of the canonical JSON serializers for it (and `ValidPathInfo` and `NarInfo`). Beyond cleaning up the JSON code, this also opens the doors to things like: - Binary caches that contain store objects that don't all belong in the same store directory - Relocatable store objects which carefully don't mention any store directory by absolute path, and instead use relative paths for anything. (NixOS#9549)
github-actions
bot
added
documentation
new-cli
edolstra
reviewed
Dec 4, 2025
| * This supports relocatable store objects where different objects | ||
| * may have different store directories. | ||
| */ | ||
| std::string storeDir; |
Member
There was a problem hiding this comment.
Maybe this should be a CanonPath? Or perhaps an std::filesystem::path, but I don't think we're prepared for that.
Member
Author
There was a problem hiding this comment.
I made it a string because it might be a Windows path on Unix, or a Unix path on Windows. I do wish there was a better type of this, but we don't have one yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The previous commit hacked it into the output of
nix path-info --json, this cleans that up my making it an actual field of that data type, and part of the canonical JSON serializers for it (andValidPathInfoandNarInfo).Context
Beyond cleaning up the JSON code, this also opens the doors to things like:
Binary caches that contain store objects that don't all belong in the same store directory
Relocatable store objects which carefully don't mention any store directory by absolute path, and instead use relative paths for anything. ( Relocatable store objects #9549)
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.