Conversation
Signed-off-by: SumanthRH <sumanthrh@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request updates pyproject.toml to add an override dependency for nixl-cu13 with the environment marker sys_platform == 'never'. This change prevents the installation of nixl-cu13 on Linux, resolving a collision with nixl-cu12 that breaks vLLM model inspection in CUDA-12 environments. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Megatron Models GPU CI passes: https://github.com/NovaSky-AI/SkyRL/actions/runs/27103746484/job/79989027090?pr=1756 The same workflow fails on main with the vllm model validation error: https://github.com/NovaSky-AI/SkyRL/actions/runs/27085057237/job/79937793420 |
#1756 was insufficient, since the marker on override-dependencies gates when the override happens not when the dependency is installed.
What does this PR do?
Excludes nixl cu13 from the packages.
After #1601 , vllm model resolution fails with
The root cause is the
nixlpackage. Thenixlpackage on PyPI is a meta package that includes bothnixl-cu12andnixl-cu13.nixl-cu13ships a binary that breaks vllm model inspection.I haven't figured out why the vllm-router upgrade triggered this, but the fix seems to work