Update dependency @openzeppelin/confidential-contracts to v0.3.2 [SECURITY] - #877
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.3.1→0.3.2OpenZeppelin Confidential Contracts
VestingWalletConfidential: a malicious ERC-7984 token is able to extract private data from the vesting walletGHSA-29h2-jr22-frmh
More information
Details
Impact
Two locations consume an encrypted handle returned by an untrusted external party and use it without verifying that the party is ACL-authorized on it.
VestingWalletConfidentialMalicious users can call
releasewith a malicious token. This token could return an alternative handle onconfidentialBalanceOf, which represents the balance of the vesting wallet on an alternative ERC-7984 token (or any other handle that the vesting wallet has access to). The vesting wallet does not check that the token has ACL access and grants access to a new handle derived from the returned handle.Effectively, this bug allows a malicious user to gain information about any private
euint64handle that the vesting wallet has access to via a malicious ERC-7984 token. There is no loss of funds.ERC7984
On a transfer with callback,
ERC7984uses theeboolreturned by therecipient's
IERC7984Receiver.onConfidentialTransferReceivedto drive the refundlogic, without checking that the recipient has ACL access to it. A malicious recipient
can return any
eboolthe token has access to and recover its plaintext from therefund result, which the token grants the caller access to. The leak is limited
to
eboolhandles (the value is only used as anFHE.selectcondition), andthere is no loss of funds.
Patches
Both issues were fixed in the same patch releases: v0.5.2, v0.4.2, v0.3.2
VestingWalletConfidential: 93e75ceed2b9648f53f9d133f431064353456805 (#423).ERC7984transfer callback: fe0863af2c9dce7614acce98720a913bf6a767a5 (#428), with follow-up ee47edf189ab681cebdad18bfb53dee541987be2 (#431) permitting an uninitialized returned handle.Severity
CVSS:4.0/AV:N/AC:L/AT:N/PR:L/UI:N/VC:H/VI:N/VA:N/SC:N/SI:N/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
OpenZeppelin/openzeppelin-confidential-contracts (@openzeppelin/confidential-contracts)
v0.3.2Compare Source
VestingWalletConfidential: Ensure that tokens are allowed to access handles they return (or the handle is uninitialized). (#423)ERC7984: Check thatIERC7984Receiverhas ACL access to the ebool they return (or the handle is uninitialized). (#428)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.