#8862: Preventing the SQL Server Service Broker feature from being enabled for tenants that are not using Microsoft SQL Server as their database provider (Lombiq Technologies: ORCH-309)

[I3undy]

Fixes #8862.

[BenedekFarkas]

Namespace and rewrap:

Suggested change

	/// <summary>
	/// Prevents the SQL Server Service Broker feature from being enabled for tenants that are not using
	/// Microsoft SQL Server as their database provider.
	/// </summary>
	/// <remarks>
	/// The implementation is hackish but there seems to be no other way: if it would use <see cref="Orchard.UI.Notify.INotifier"/>
	/// it wouldn't work since <see cref="Orchard.UI.Notify.NotifyFilter"/> that writes out notifications to TempData
	/// runs before feature events are raised. Thus we have to manually add the messages to TempData, just as the filter
	/// would do.
	/// </remarks>
	/// <summary>
	/// Prevents the SQL Server Service Broker feature from being enabled for tenants that are not using Microsoft SQL
	/// Server as their database provider.
	/// </summary>
	/// <remarks>
	/// The implementation is hackish but there seems to be no other way: if it would use <see cref="INotifier"/> it
	/// wouldn't work since <see cref="NotifyFilter"/> that writes out notifications to TempData runs before feature
	/// events are raised. Thus we have to manually add the messages to TempData, just as the filter would do.
	/// </remarks>

[BenedekFarkas]

Suggested change

[BenedekFarkas]

Can you please check if you see the same behavior: When enabling SqlServerServiceBroker while Orchard.MessageBus is also disabled, then the notification will not be displayed. If I disable SqlServerServiceBroker and then enable it again (and thus Orchard.MessageBus is already enabled) then the notification is displayed.

[BenedekFarkas]

Please check if we can store here whether SqlServerServiceBroker's dependencies (there's only Orchard.MessageBus, but don't wire that in) are already enabled or not. Those that aren't should also be disabled along with SqlServerServiceBroker in the Enabled handler.

[BenedekFarkas]

Suggested change

	notifyType.ToString() +
	":" +
	message.Text +
	System.Environment.NewLine +
	"-" +
	System.Environment.NewLine;
	$"{notifyType}:{message.Text}{System.Environment.NewLine}-{System.Environment.NewLine}";