[BUG] PF1e - Advanced Class Guide - Elf Brawler Favored Class Bonus not working

[taelnia]

Describe the bug
When using Pathfinder 1e Advanced Class Guide the favored class bonus for Elf Brawlers is not loading/being listed by PCGen. Additionally, there is an error in its calculation of how it applies its bonus once it is loading.

To Reproduce
Steps to reproduce the behavior:

1. Create a new character: Race Elf, Class Brawler
2. Go to add the favored class bonus
3. Notice that the "Bonus Base Speed" that is listed in the acg racial ability list file for elf brawlers is NOT listed in the favored class bonus list

Expected behavior
The "Bonus Base Speed" should be listed for Elven Brawlers to select. And the speed should properly add to movement speed with the ability noted that only 5ft increment bonus count for combat.

Desktop (please complete the following information):

• OS: Windows 10 22H2 ESU
• Browser N/A
• Java Version Eclipse Adoptium Temurin-11.0.28+6
• PCGen Version: 6.08.00 RC's 8/10/11

Additional context
I was able to fix this on my local copy with the following changes. I do not know if this is the desired way to fix this however. That is why I created this issue instead of a PR.

--- C:\Users\Taelnia\Downloads\acg_abilities_race.lst 2025-10-06 11:34:24.000000000 -0400
+++ E:\Non-Installed Applications\PCGen\6.08.00RC11\data\pathfinder\paizo\roleplaying_game\advanced_class_guide\acg_abilities_race.lst 2026-06-06 11:28:46.442000000 -0400
@@ -57,7 +57,7 @@
-Bonus Base Speed KEY:Elf ~ Favored Class Bonus ~ Base Speed CATEGORY:Special Ability TYPE:SpecialQuality.FavoredClassBonus.FavoredClassBrawler VISIBLE:DISPLAY PREABILITY:1,CATEGORY=Special Ability,Brawler PRECLASS:1,Brawler=1 PRERACE:1,Elf%,RACESUBTYPE=Elf DEFINE:ElfBrawlerFavClassBonus|0 DESC:Add 1 foot to the brawler's base speed. In combat, this has an effect only for every five increases in the brawler's base speed. STACK:YES MULT:YES CHOOSE:NOCHOICE ABILITY:Special Ability|AUTOMATIC|Elf ~ Brawler ~ Fast Movement|PREVARGTEQ:ElfBrawlerFavClassBonus,5 BONUS:VAR|ElfBrawlerFavClassBonus|1
+Bonus Base Speed KEY:Favored Class Bonus ~ Brawler ~ Elf CATEGORY:Special Ability TYPE:FavoredClassBonus.FavoredClassBrawler VISIBLE:DISPLAY PREABILITY:1,CATEGORY=Special Ability,Brawler PRECLASS:1,Brawler=1 PRERACE:1,Elf,RACESUBTYPE=Elf DEFINE:ElfBrawlerFavClassBonus|0 DESC:Add 1 foot to the brawler's base speed. In combat, this has an effect only for every five increases in the brawler's base speed. STACK:YES MULT:YES CHOOSE:NOCHOICE ABILITY:Special Ability|AUTOMATIC|Elf ~ Brawler ~ Fast Movement BONUS:VAR|ElfBrawlerFavClassBonus|1
@@ -323,7 +323,7 @@
-Fast Movement KEY:Elf ~ Brawler ~ Fast Movement CATEGORY:Special Ability TYPE:SpecialQuality.ModifyMovement DESC:Your land speed is faster than the norm for your race by %1 feet.|floor(ElfBrawlerFavClassBonus/5) BONUS:MOVEADD|TYPE=Walk|floor(ElfBrawlerFavClassBonus/5)
+Fast Movement KEY:Elf ~ Brawler ~ Fast Movement CATEGORY:Special Ability TYPE:SpecialQuality.ModifyMovement DESC:Add %1 feet to the brawler's base speed. In combat, this has an effect only for every five increases in the brawler's base speed. (Combat Bonus: %2 feet).|ElfBrawlerFavClassBonus|5*floor(ElfBrawlerFavClassBonus/5) BONUS:MOVEADD|TYPE=Walk|ElfBrawlerFavClassBonus

[Vest]

p.s. I haven't invested much time here, but here is my 2 cents.
@LegacyKing I have verified this info with my LLM, here is the result:

I can reproduce this on master (data/pathfinder/paizo/roleplaying_game/advanced_class_guide/acg_abilities_race.lst). Two ability entries declare the same KEY in the same CATEGORY:

• Line ~55, Elf Bloodrager:
  KEY:Elf ~ Favored Class Bonus ~ Base Speed · CATEGORY:Special Ability · TYPE:SpecialQuality.FavoredClassBonus.FavoredClassBloodrager
• Line ~59, Elf Brawler:
  KEY:Elf ~ Favored Class Bonus ~ Base Speed · CATEGORY:Special Ability · TYPE:SpecialQuality.FavoredClassBonus.FavoredClassBrawler

PCGen identifies abilities by (CATEGORY, KEY). Two rows with the same (CATEGORY, KEY) collide: only one survives the load. The Bloodrager row wins, and the Brawler-typed entry is lost — which is exactly why "Bonus Base Speed" never appears in the Brawler favored-class-bonus list. (For Bloodragers it does still show up.)

This also explains why the OP's local fix worked: renaming the Brawler row's KEY removed the collision.

Proposed minimal fix (data only)

Rename the Brawler row's KEY so the two abilities don't collide. To stay consistent with the existing PF convention (e.g. Dwarf ~ Favored Class Bonus ~ Unarmed Strike for the Dwarf Brawler entry), the cleanest options
are:

• KEY:Elf ~ Favored Class Bonus ~ Brawler Base Speed, or
• KEY:Elf ~ Favored Class Bonus ~ Base Speed (Brawler)

I'd suggest applying the same disambiguation to the Bloodrager row (... Bloodrager Base Speed) to make it symmetric, but that's optional — only one of the two needs to change to fix the bug.

No other change to that row is required: the rest of its fields (PREFACT:1,TEMPLATES,IsElf=true, PRECLASS:1,Brawler=1, BONUS:VAR|ElfBrawlerFavClassBonus|1, etc.) are already correct on master. Note that the OP's diff is against an older version of the file that used PRERACE:1,Elf%; the current code already uses the IsElf template fact, so that part of their patch isn't needed.

About the second half of the OP's diff (the Fast Movement MOVEADD change)

The OP also proposes changing the auto-granted Elf ~ Brawler ~ Fast Movement ability from:

BONUS:MOVEADD|TYPE=Walk|floor(ElfBrawlerFavClassBonus/5)

to:

BONUS:MOVEADD|TYPE=Walk|ElfBrawlerFavClassBonus

I'd push back on this part. The neighbouring Half-Elf ~ Hunter ~ Companion Fast Movement entry uses the same floor(.../5) MOVEADD pattern, and the parent Bonus Base Speed row only auto-grants Fast Movement once
ElfBrawlerFavClassBonus >= 5 (PREVARGTEQ:ElfBrawlerFavClassBonus,5). So the existing math is "every 5 stacks gives +1 ft of effective combat speed," which matches the rules text "this has an effect only for every five increases in the brawler's base speed." Replacing floor(x/5) with x would grant the full per-stack speed in combat, which is the opposite of the rules wording.

The OP's only legitimate complaint about this line is the description, which currently shows floor(ElfBrawlerFavClassBonus/5) and could be improved to also show the cosmetic non-combat foot count. That's a polish nit, not a bug.

TL;DR

• Bug: duplicate (CATEGORY, KEY) between the Elf Bloodrager and Elf Brawler "Bonus Base Speed" entries causes one to be silently dropped at load. Brawler loses.
• Fix: rename one (or both) of the two rows' KEY. One-line change in acg_abilities_race.lst.
• MOVEADD math is correct as-is — don't change it.

[taelnia]

The second part is because with the current math, the added move speed to the character is incorrect in ALL situations, not just combat.

The combat notation of all of these FCB's is due to pathfinder combat working in five foot increments, so you need at least +5 bonus to apply +1 5ft combat square bonus.

By flooring the bonus before adding to base move, you end up with incorrect and odd values.
For example select bonus move +13 times for 13 levels, this by rules should add 13 feet move to the character. as the dataset is written it adds 2 move to the character sheet. It should be +13 for social/town/adventuring situations, and +10 (two 5 foot squares) for combat/anything else that uses grid rules.
This combat adjustment is slightly better explained on the version of this for the Elf Shifter FCB: " [Shifter] Add 1 to the shifter's base speed. This has no in-game effect unless the shifter has selected this reward five times (or any multiple of five) to enhance her speed by 5 feet. This bonus applies only when the shifter is wearing no armor."

Edit:
I believe this flooring may be an issue with the other FCB abilities in the various sources as well. The dataset calculations are treating the count of five foot square increments as the add to the move when it should be the count *5. Each FCB is slightly different, but they share the theme of each level being 1/5th of a total five foot square increment. for combat.

This isn't a polish nit, this is a bug, because even the current data sets do not match the rules. as your LLM noted above: So the existing math is "every 5 stacks gives +1 ft of effective combat speed," which matches the rules text "this has an effect only for every five increases in the brawler's base speed." This is incorrect Every five increases in the base speed produces a five foot increase, which then takes effect in combat(which the LLM neglected to include the first part of the quote "In combat, this has an effect ..."). Nowhere in pathfinder does anything add one foot increments to combat. All of combat in pathfinder is ruled around five foot increments and squares.

Just because the issue is also detected by the LLM in a nearby line or ability and decides that this should match does not negate the overall bug. An error created once and the replicated in other spaces is still an error.

If the desire is for the movement speed to show combat abilities on the character sheet, then I'd propose the MOVEADD be 5*floor(ElfBrawlerFavClassBonus/5). I would still leave the other changes i proposed (the description change to include both social and combat bonuses, and the removal of the PREVARGTEQ condition as the description and the MOVEADD account for that)