Skip to content

Commit 04bc5fb

Browse files
authored
Use Particular.Approvals for approvals (#5797)
1 parent 0f202b4 commit 04bc5fb

5 files changed

Lines changed: 5 additions & 17 deletions

‎src/Directory.Packages.props‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,6 @@
9595
<PackageVersion Include="System.Reflection.MetadataLoadContext" Version="$(RuntimeFrameworkVersion)" />
9696
<PackageVersion Include="System.ServiceProcess.ServiceController" Version="$(RuntimeFrameworkVersion)" />
9797
<PackageVersion Include="Validar.Fody" Version="1.9.0" />
98-
<PackageVersion Include="Verify.NUnit" Version="31.20.0" />
9998
<PackageVersion Include="Yarp.ReverseProxy" Version="2.3.0" />
10099
</ItemGroup>
101100
<ItemGroup Label="Versions to pin transitive references">
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"roles":["admin"],"routes":[{"method":"GET","url_template":"/api/errors"}]}

‎src/ServiceControl.Infrastructure.Tests/Auth/RouteManifestEntrySerializationTests.Response_wraps_roles_and_routes_under_pinned_field_names.verified.txt‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎src/ServiceControl.Infrastructure.Tests/Auth/RouteManifestEntrySerializationTests.cs‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22
namespace ServiceControl.Infrastructure.Tests.Auth;
33

44
using System.Text.Json;
5-
using System.Threading.Tasks;
65
using NUnit.Framework;
6+
using Particular.Approvals;
77
using ServiceControl.Infrastructure.Auth;
8-
using VerifyNUnit;
98

109
[TestFixture]
1110
class RouteManifestEntrySerializationTests
@@ -30,12 +29,12 @@ public void Emits_snake_case_field_names_even_under_a_camelCase_policy()
3029
// Same contract as above, but for the response wrapper: roles are reported once at the top level,
3130
// not duplicated onto every route entry.
3231
[Test]
33-
public Task Response_wraps_roles_and_routes_under_pinned_field_names()
32+
public void Response_wraps_roles_and_routes_under_pinned_field_names()
3433
{
3534
var json = JsonSerializer.Serialize(
3635
new MyRoutesResponse(["admin"], [new RouteManifestEntry("GET", "/api/errors")]),
3736
new JsonSerializerOptions { PropertyNamingPolicy = JsonNamingPolicy.CamelCase });
3837

39-
return Verifier.VerifyJson(json);
38+
Approver.Verify(json);
4039
}
4140
}

‎src/ServiceControl.Infrastructure.Tests/ServiceControl.Infrastructure.Tests.csproj‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<PackageReference Include="NUnit" />
1919
<PackageReference Include="NUnit.Analyzers" />
2020
<PackageReference Include="NUnit3TestAdapter" />
21-
<PackageReference Include="Verify.NUnit" />
21+
<PackageReference Include="Particular.Approvals" />
2222
</ItemGroup>
2323

2424
</Project>

0 commit comments

Comments
 (0)