Repository navigation
Commit ce7fa64
authored
Upgrade AG Grid and enhance the data viewer (#1765)
Upgrade AG Grid Community from 35.2.1 to 36.2.0 and add shared controls to the on-demand and file-backed data viewers. Columns fill the viewport by default and remain fitted through scrolling, page changes, and webview resizing; content sizing runs only when requested.
Closes #1586.
## Changes
- Add searchable column visibility and pinning controls, floating filters, clear-all filters, row counts, and full-value tooltips. Showing or hiding floating filters preserves the current column order.
- Preserve compatible column layouts, sorting, filters, page sizes, and sizing modes across repeated `View()` calls. Reset restores fit-width sizing, and older saved fixed widths migrate to the new default.
- Replace outdated grid/selection API usage and initialize file-backed grids after the document is ready. Share date, boolean, missing-value, and integer64 handling between viewer modes.
- Update TypeScript to AG Grid's supported minimum of 5.8.3 and declare the test suite's `glob` dependency with compatible types.
- Document the viewer controls and add regression tests for sizing, state restoration, schema changes, pagination, and column types.
## Validation
- Production bundle, TypeScript compilation, and ESLint on changed TypeScript files pass.
- Full extension suite in VS Code 1.119.0: 141 tests pass.
- R data-viewer suite: 79 checks pass; native AG Grid date and bigint filter models also verified against R.
- Headless Chrome checks using all 53,940 `ggplot2::diamonds` rows in both viewer modes, including scrolling, new blocks/pages, widening/narrowing, mode switching, reset, manual widths, and saved-state migration. No browser errors or AG Grid validation warnings.
- Chrome checks confirm floating filters render, apply, hide, and restore while preserving column order, widths/flex, pinning, visibility, and sorting. Reset clears sorting and filters and restores the default layout in paged, unpaged, and file-backed viewers.1 parent b3c5202 commit ce7fa64
8 files changed
Lines changed: 860 additions & 283 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
| 17 | + | |
16 | 18 | | |
17 | 19 | | |
18 | 20 | | |
| |||
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| 36 | + | |
| 37 | + | |
34 | 38 | | |
35 | 39 | | |
36 | 40 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
116 | 125 | | |
117 | 126 | | |
118 | 127 | | |
| |||
0 commit comments