Skip to content

Commit 66e508b

Browse files
committed
Revert unrelated rustfmt churn
The previous commit ran cargo fmt over the whole workspace, which reformatted 129 files the Poetry fix does not touch. Restore them so the PR only changes the Poetry crawler and its tests. Assisted-by: Claude Code:claude-opus-5-5
1 parent 5f7c5f5 commit 66e508b

130 files changed

Lines changed: 846 additions & 2228 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎crates/socket-patch-cli/src/commands/apply.rs‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ use clap::Args;
22
use socket_patch_core::api::blob_fetcher::get_missing_blobs;
33
use socket_patch_core::api::client::{get_api_client_with_overrides, ApiClient};
44
use socket_patch_core::crawlers::ruby_crawler::config_path_ignored_warning;
5-
use socket_patch_core::crawlers::{detect_npm_pkg_manager, Ecosystem, NpmPkgManager, RubyCrawler};
5+
use socket_patch_core::crawlers::{
6+
detect_npm_pkg_manager, Ecosystem, NpmPkgManager, RubyCrawler,
7+
};
68
use socket_patch_core::manifest::operations::read_manifest;
79
use socket_patch_core::manifest::schema::{PatchFileInfo, PatchManifest, PatchRecord};
810
use socket_patch_core::patch::apply::{

‎crates/socket-patch-cli/src/commands/list.rs‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -431,10 +431,7 @@ pub async fn run(args: ListArgs) -> i32 {
431431
detail: detail.clone(),
432432
});
433433
} else if !args.common.silent {
434-
eprintln!(
435-
"Warning: {}",
436-
crate::commands::rollback::capitalize_first(detail)
437-
);
434+
eprintln!("Warning: {}", crate::commands::rollback::capitalize_first(detail));
438435
}
439436
}
440437
let vendor_state = crate::commands::vendor_state_lenient(&loaded.vendor, args.common.silent);
@@ -776,18 +773,12 @@ mod tests {
776773
let listings = HostedListing::from_pins(
777774
&[
778775
pin("pkg:npm/minimist@1.2.2", &record.uuid),
779-
pin(
780-
"pkg:npm/other@1.0.0",
781-
"33333333-3333-4333-8333-333333333333",
782-
),
776+
pin("pkg:npm/other@1.0.0", "33333333-3333-4333-8333-333333333333"),
783777
],
784778
Some(&legacy),
785779
);
786780
assert_eq!(listings[0].record, record);
787-
assert_eq!(
788-
listings[1].record.uuid,
789-
"33333333-3333-4333-8333-333333333333"
790-
);
781+
assert_eq!(listings[1].record.uuid, "33333333-3333-4333-8333-333333333333");
791782
assert!(listings[1].record.vulnerabilities.is_empty());
792783
assert_eq!(listings[1].lockfiles, vec!["yarn.lock".to_string()]);
793784
}

‎crates/socket-patch-cli/src/commands/mod.rs‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
pub mod apply;
22
pub(crate) mod bun_preflight;
3-
pub(crate) mod composer_hints;
43
pub(crate) mod context;
4+
pub(crate) mod composer_hints;
55
pub(crate) mod fetch_stage;
66
pub mod get;
77
pub mod hosted_bundle;
88
pub mod list;
99
pub(crate) mod lock_cli;
1010
pub mod remove;
1111
pub mod repair;
12+
pub(crate) mod vendored_backend;
1213
pub mod rollback;
1314
pub mod scan;
1415
pub mod update;
1516
pub mod vendor;
16-
pub(crate) mod vendored_backend;
1717
pub mod vex;
1818
pub(crate) mod vex_consumed;
1919
pub(crate) mod vex_sources;
@@ -141,11 +141,9 @@ pub(crate) async fn hosted_state_from_lockfiles(
141141
common: &crate::args::GlobalArgs,
142142
root: &Path,
143143
) -> socket_patch_core::patch::redirect::RedirectState {
144-
hosted_state_from_pins(
145-
&socket_patch_core::patch::redirect::upstream::HostedPin::all(
146-
&discover_wiring(common, root).await,
147-
),
148-
)
144+
hosted_state_from_pins(&socket_patch_core::patch::redirect::upstream::HostedPin::all(
145+
&discover_wiring(common, root).await,
146+
))
149147
}
150148

151149
/// [`hosted_state_from_lockfiles`] over already-discovered pins. A purl
@@ -155,17 +153,18 @@ pub(crate) fn hosted_state_from_pins(
155153
) -> socket_patch_core::patch::redirect::RedirectState {
156154
let mut state = socket_patch_core::patch::redirect::RedirectState::new();
157155
for pin in pins {
158-
state.records.entry(pin.purl.clone()).or_insert_with(|| {
159-
socket_patch_core::manifest::schema::PatchRecord {
156+
state
157+
.records
158+
.entry(pin.purl.clone())
159+
.or_insert_with(|| socket_patch_core::manifest::schema::PatchRecord {
160160
uuid: pin.uuid.clone(),
161161
exported_at: String::new(),
162162
files: Default::default(),
163163
vulnerabilities: Default::default(),
164164
description: String::new(),
165165
license: String::new(),
166166
tier: String::new(),
167-
}
168-
});
167+
});
169168
}
170169
state
171170
}
@@ -192,3 +191,4 @@ pub(crate) fn vendor_state_lenient(
192191
}
193192
}
194193
}
194+

‎crates/socket-patch-cli/src/commands/remove.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ use super::rollback::{
1717
pin_before_hash_blobs, rollback_patches_inner, run_hosted_leg, sweep_failure,
1818
sweep_unused_artifacts, HostedLegOutcome, InnerSelection,
1919
};
20+
use crate::commands::vendored_backend::{RevertedEntry, VendorRevertStep, VendoredBackend};
2021
use crate::args::{apply_env_toggles, GlobalArgs};
2122
use crate::commands::lock_cli::acquire_or_emit;
22-
use crate::commands::vendored_backend::{RevertedEntry, VendorRevertStep, VendoredBackend};
2323
use crate::json_envelope::{Command, Envelope, EnvelopeError, PatchAction, PatchEvent, Status};
2424
use crate::ui::plural;
2525

‎crates/socket-patch-cli/src/commands/rollback.rs‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,13 @@ use socket_patch_core::manifest::operations::{
1010
};
1111
use socket_patch_core::manifest::schema::{PatchFileInfo, PatchManifest, PatchRecord};
1212
use socket_patch_core::patch::apply::select_installed_variants;
13-
use socket_patch_core::patch::redirect::upstream::HostedPin;
1413
use socket_patch_core::patch::rollback::{
1514
cannot_rollback_error, rollback_package_patch, verify_file_rollback, RollbackResult,
1615
VerifyRollbackResult, VerifyRollbackStatus,
1716
};
1817
use socket_patch_core::telemetry::{track_patch_rollback_failed, track_patch_rolled_back};
1918
use socket_patch_core::utils::purl::{patch_matches, strip_purl_qualifiers};
19+
use socket_patch_core::patch::redirect::upstream::HostedPin;
2020
use socket_patch_core::vendor::{purl_keys_cover, RevertOpts, VendorState};
2121
use std::collections::{HashMap, HashSet};
2222
use std::path::{Path, PathBuf};
@@ -1026,8 +1026,7 @@ pub(crate) async fn run_hosted_leg(common: &GlobalArgs, pins: &[HostedPin]) -> H
10261026
.iter()
10271027
.map(|(code, detail)| (code.to_string(), detail.clone())),
10281028
);
1029-
out.edited_files
1030-
.extend(outcome.reverted_files.iter().cloned());
1029+
out.edited_files.extend(outcome.reverted_files.iter().cloned());
10311030
let unwound: Vec<_> = vlt_targets
10321031
.into_iter()
10331032
.filter(|t| out.reverted.iter().any(|p| p == &t.purl))
@@ -1171,11 +1170,7 @@ pub async fn run(args: RollbackArgs) -> i32 {
11711170
} else if !args.common.silent {
11721171
println!(
11731172
"{} the pre-v5 hosted ledger {}: no lockfile pins a hosted patch.",
1174-
if args.common.dry_run {
1175-
"Would remove"
1176-
} else {
1177-
"Removed"
1178-
},
1173+
if args.common.dry_run { "Would remove" } else { "Removed" },
11791174
socket_patch_core::patch::redirect::REDIRECT_STATE_REL
11801175
);
11811176
}

‎crates/socket-patch-cli/src/commands/scan/discovery.rs‎

Lines changed: 26 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -168,32 +168,29 @@ pub(crate) async fn vendored_ledger_supplement(
168168
}
169169
// `(ledger key, base purl, entry)`; the artifact fallback has no
170170
// entries to probe, so it never reports unwired keys.
171-
let candidates: Vec<(
172-
String,
173-
String,
174-
Option<&socket_patch_core::vendor::VendorEntry>,
175-
)> = match state {
176-
Ok(state) => state
177-
.entries
178-
.iter()
179-
.map(|(key, entry)| {
180-
(
181-
key.clone(),
182-
strip_purl_qualifiers(&entry.base_purl).to_string(),
183-
Some(entry),
184-
)
185-
})
186-
.collect(),
187-
// Corrupt/unreadable ledger (a MISSING file is Ok(empty) above):
188-
// recover the vendored set from the committed artifacts, or
189-
// `scan --prune` (whose ledger exemption also degrades to empty)
190-
// would delete still-vendored packages' manifest entries and blobs.
191-
Err(_) => vendored_purls_from_artifacts(common)
192-
.await
193-
.into_iter()
194-
.map(|base| (base.clone(), base, None))
195-
.collect(),
196-
};
171+
let candidates: Vec<(String, String, Option<&socket_patch_core::vendor::VendorEntry>)> =
172+
match state {
173+
Ok(state) => state
174+
.entries
175+
.iter()
176+
.map(|(key, entry)| {
177+
(
178+
key.clone(),
179+
strip_purl_qualifiers(&entry.base_purl).to_string(),
180+
Some(entry),
181+
)
182+
})
183+
.collect(),
184+
// Corrupt/unreadable ledger (a MISSING file is Ok(empty) above):
185+
// recover the vendored set from the committed artifacts, or
186+
// `scan --prune` (whose ledger exemption also degrades to empty)
187+
// would delete still-vendored packages' manifest entries and blobs.
188+
Err(_) => vendored_purls_from_artifacts(common)
189+
.await
190+
.into_iter()
191+
.map(|base| (base.clone(), base, None))
192+
.collect(),
193+
};
197194
// Composer by release identity: a ledger `@3.0.2.0` is the crawled
198195
// `@3.0.2`, not a second package to supplement.
199196
let key = |p: &str| composer_purl_identity(p).unwrap_or_else(|| normalize_purl(p).into_owned());
@@ -1041,9 +1038,7 @@ mod tests {
10411038
..GlobalArgs::default()
10421039
};
10431040
let state = socket_patch_core::vendor::load_state(root).await;
1044-
vendored_ledger_supplement(&args, crawled, &state)
1045-
.await
1046-
.packages
1041+
vendored_ledger_supplement(&args, crawled, &state).await.packages
10471042
}
10481043

10491044
/// A ledger entry vendored as `@3.0.2.0` is the crawled composer
@@ -1078,9 +1073,7 @@ mod tests {
10781073
out.iter().map(|p| &p.purl).collect::<Vec<_>>()
10791074
);
10801075

1081-
let out = vendored_ledger_supplement(&args, &[], &Ok(state))
1082-
.await
1083-
.packages;
1076+
let out = vendored_ledger_supplement(&args, &[], &Ok(state)).await.packages;
10841077
assert_eq!(
10851078
out.iter().map(|p| p.purl.as_str()).collect::<Vec<_>>(),
10861079
vec!["pkg:composer/psr/log@3.0.2.0"]
@@ -1183,10 +1176,7 @@ mod tests {
11831176
let state = npm_ledger_with_lock(tmp.path(), lock.as_deref()).await;
11841177
let out = vendored_ledger_supplement(&args, &[], &state).await;
11851178
assert_eq!(
1186-
out.packages
1187-
.iter()
1188-
.map(|p| p.purl.as_str())
1189-
.collect::<Vec<_>>(),
1179+
out.packages.iter().map(|p| p.purl.as_str()).collect::<Vec<_>>(),
11901180
vec!["pkg:npm/left-pad@1.3.0"],
11911181
"lock={lock:?}"
11921182
);

‎crates/socket-patch-cli/src/commands/scan/hosted.rs‎

Lines changed: 11 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -932,8 +932,7 @@ pub(crate) async fn run_redirect_selected(
932932
socket_patch_core::utils::fs::read_regular_to_string_sync(path).ok()
933933
})
934934
};
935-
let rewrite_options = || {
936-
RewriteOptions {
935+
let rewrite_options = || RewriteOptions {
937936
dry_run: common.dry_run,
938937
targets_pipenv_lock,
939938
pipenv_major,
@@ -945,7 +944,6 @@ pub(crate) async fn run_redirect_selected(
945944
npm_allow_remote_config: !common.no_npm_allow_remote_config,
946945
npm_outer: &npm_outer,
947946
blocking: true,
948-
}
949947
};
950948
// The rollout gate plans again without its deferred rows: keep what
951949
// the second pass needs.
@@ -2306,19 +2304,13 @@ fn join_names(names: &[String], max: usize) -> String {
23062304
/// artifacts, then verify with `vex`. After a vendored→hosted takeover
23072305
/// (`vendored_removed`) the commit also has to carry the deleted vendored
23082306
/// ledger entries and artifacts.
2309-
fn format_next_steps(
2310-
files: &[String],
2311-
edits: &[socket_patch_core::patch::redirect::FileEdit],
2312-
vendored_removed: bool,
2313-
) -> Vec<String> {
2307+
fn format_next_steps(files: &[String], edits: &[socket_patch_core::patch::redirect::FileEdit], vendored_removed: bool) -> Vec<String> {
23142308
if files.is_empty() && !vendored_removed {
23152309
return Vec::new();
23162310
}
23172311
let mut commit: Vec<String> = Vec::new();
23182312
if vendored_removed {
2319-
commit.push(
2320-
".socket/vendor/ (the removed vendored ledger entries and artifacts)".to_string(),
2321-
);
2313+
commit.push(".socket/vendor/ (the removed vendored ledger entries and artifacts)".to_string());
23222314
}
23232315
commit.extend(files.iter().cloned());
23242316
let npm = files
@@ -4399,43 +4391,19 @@ mod tests {
43994391
use super::npm_allow_remote_one_line;
44004392
let hosts = ["patch.socket.dev"];
44014393
let cases = [
4402-
(
4403-
npm_allow_remote_configured_detail(&hosts, true, false),
4404-
"Note: set",
4405-
),
4406-
(
4407-
npm_allow_remote_configured_detail(&hosts, false, false),
4408-
"Note: set",
4409-
),
4410-
(
4411-
npm_allow_remote_configured_detail(&hosts, true, true),
4412-
"Note: would set",
4413-
),
4414-
(
4415-
npm_allow_remote_already_detail(&hosts),
4416-
"Note: .npmrc already",
4417-
),
4418-
(
4419-
npm_allow_remote_user_set_detail(&hosts, "none"),
4420-
"Warning: npm >=12",
4421-
),
4422-
(
4423-
npm_allow_remote_env_set_detail(&hosts, "npm_config_allow_remote", "none"),
4424-
"Warning: npm >=12",
4425-
),
4394+
(npm_allow_remote_configured_detail(&hosts, true, false), "Note: set"),
4395+
(npm_allow_remote_configured_detail(&hosts, false, false), "Note: set"),
4396+
(npm_allow_remote_configured_detail(&hosts, true, true), "Note: would set"),
4397+
(npm_allow_remote_already_detail(&hosts), "Note: .npmrc already"),
4398+
(npm_allow_remote_user_set_detail(&hosts, "none"), "Warning: npm >=12"),
4399+
(npm_allow_remote_env_set_detail(&hosts, "npm_config_allow_remote", "none"), "Warning: npm >=12"),
44264400
(npm_allow_remote_manual_detail(&hosts), "Warning: npm >=12"),
4427-
(
4428-
npm_allow_remote_unreadable_detail(&hosts, "is a symlink"),
4429-
"Warning: npm >=12",
4430-
),
4401+
(npm_allow_remote_unreadable_detail(&hosts, "is a symlink"), "Warning: npm >=12"),
44314402
];
44324403
for (detail, start) in cases {
44334404
let line = npm_allow_remote_one_line(&detail);
44344405
assert!(line.starts_with(start), "{line}");
4435-
assert!(
4436-
!line.contains('\n') && line.ends_with("(details: --verbose)."),
4437-
"{line}"
4438-
);
4406+
assert!(!line.contains('\n') && line.ends_with("(details: --verbose)."), "{line}");
44394407
}
44404408
}
44414409
}

0 commit comments

Comments
 (0)