Skip to content

Commit ce95d8a

Browse files
Compile tests on Windows in the merge queue (#1378)
Lean scope skips every Windows leg on pull requests and in the merge queue, so a cfg(unix) slip in a test reaches main and is caught only by the nightly. #1324 did exactly that: a new test separated covgap_commands_vendor's symlink test from its #[cfg(unix)] gate, and only the full-scope e2e-build-windows run caught the compile error. e2e-build-windows now also runs on merge_group. That is one GitHub-hosted Windows job per queue group that compiles every test target. Its consumers (e2e-windows, cargo-vex-matrix-windows) stay full-scope only, so no Windows tests run in the queue. The reused push on main still skips it as before. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
1 parent d877fc4 commit ce95d8a

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ concurrency:
5858
# the repository variable CI_SCOPE is `full`, pull_request, merge_group and
5959
# push runs use one targeted e2e row per package manager (the rest are in
6060
# e2e-extended), one row each of the yarn and cargo VEX matrices, and skip
61-
# the Windows/macOS legs, test, test-release, old cargo toolchains and the
61+
# the Windows/macOS legs (except e2e-build-windows, which still compiles every
62+
# test target on Windows in the merge queue), test, test-release, old cargo toolchains and the
6263
# sbt Docker coverage slice. Everything runs in the nightly schedule and on
6364
# workflow_dispatch. Set CI_SCOPE=full to restore the old gate without a
6465
# commit. ci-ok treats skipped jobs as passing. hosted-e2e is not scoped:
@@ -1014,7 +1015,10 @@ jobs:
10141015
retention-days: 3
10151016

10161017
e2e-build-windows:
1017-
if: (github.event.pull_request.draft != true) && (vars.CI_SCOPE == 'full' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch')
1018+
# Lean scope still compiles every test target on Windows in the merge
1019+
# queue (one job): lean pull_request runs skip Windows, and a cfg(unix)
1020+
# slip only shows up here (#1324). Its consumers stay full-scope only.
1021+
if: (github.event.pull_request.draft != true) && (vars.CI_SCOPE == 'full' || github.event_name == 'merge_group' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch')
10181022
needs: clippy
10191023
outputs:
10201024
reuse: ${{ needs.clippy.outputs.reuse }}

0 commit comments

Comments
 (0)