Repository navigation
Commit e02c7ff
* Start fix for #956
Assisted-by: Claude Code:claude-opus-5-5
* Quote scoped names in pnpm 7/8 vendored locks
Vendoring a scoped package (@scope/pkg) into a pnpm 7 (lock 5.4) or
pnpm 8 (lock 6.0) project wrote `name: @scope/pkg` into the rekeyed
packages entry. A bare `@` cannot start a YAML scalar, so pnpm refused
the whole lock with ERR_PNPM_BROKEN_LOCKFILE: every frozen install
failed after a scan that reported success, and lock-only VEX kept
attesting not_affected from a lock pnpm could not read.
The name is now written through the shared YAML scalar quoting, which
gives `name: '@scope/pkg'`, byte-identical to what pnpm 7.33.7 and
8.15.9 serialize themselves for the same override.
Tests: a byte-exact unit oracle captured from real pnpm 7/8 for
@isaacs/string-locale-compare (vendor, in-sync re-run, revert), and
scoped real-pnpm lifecycle legs (frozen install, moved checkout,
manifest-less VEX, revert) in e2e_vendor_pnpm_build, also run in the
pinned pnpm 7/8 matrix. Fixes #956.
Assisted-by: Claude Code:claude-opus-5-5
* Skip scoped legacy leg on pnpm 8.0.0-8.1.0
pnpm 8.0.0 and 8.1.0 refuse their own lock for a scoped file: tarball
override under --frozen-lockfile (ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY
on the key they just wrote); 8.1.1 fixed it. Measured with real pnpm
on Node 16: the lock pnpm itself writes fails the same way, so no
vendored scoped lock can pass there. The pinned matrix keeps the
unscoped leg on those versions and runs the scoped leg everywhere else.
Assisted-by: Claude Code:claude-opus-5-5
* Route Gradle digests through utils::digest
main has failed socket-patch-core's lib tests since Gradle support
(#646) and the digest helpers (#865) both landed. The guard test
production_digests_go_through_the_helpers flags three files #646 added
that still hash inline: crawlers/gradle_cache.rs, patch/jvm_jar.rs and
patch/sidecars/maven.rs. That breaks test, test-release and coverage on
every open PR.
Each inline sha1/sha256 call now goes through sha1_hex_of or
sha256_hex_of, which compute the same lowercase hex. Behaviour is
unchanged.
(cherry picked from commit 659ac2c)
Ported from #878 so this PR's CI is green while main's digest guard
test is red; it no-ops once #878 lands.
Assisted-by: Claude Code:claude-opus-5-5
* Re-vendor rewrites a stale unquoted scoped name
edit_packages treated a packages entry as in sync once its file: key
and resolution matched, without looking at name:. A lock vendored by a
release before the #956 fix still carries `name: @scope/pkg`, which
pnpm 7/8 can't load, so a later vendor reported the package already
vendored and left the lock broken.
The in-sync check now also requires the canonical quoted name: line, so
the old spelling is rewritten like any other stale wiring. The new test
revendor_heals_an_unquoted_scoped_name fails without this change.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UepoBazrbnBjy7HkD9YVJN
---------
Co-authored-by: Claude <noreply@anthropic.com>
1 parent cd7dd92 commit e02c7ff
2 files changed
Lines changed: 305 additions & 12 deletions
File tree
- crates
- socket-patch-cli/tests
- socket-patch-core/src/vendor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
152 | 164 | | |
153 | 165 | | |
154 | 166 | | |
| |||
888 | 900 | | |
889 | 901 | | |
890 | 902 | | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
891 | 907 | | |
892 | 908 | | |
893 | | - | |
| 909 | + | |
894 | 910 | | |
895 | 911 | | |
896 | 912 | | |
| |||
1025 | 1041 | | |
1026 | 1042 | | |
1027 | 1043 | | |
1028 | | - | |
| 1044 | + | |
1029 | 1045 | | |
1030 | 1046 | | |
1031 | 1047 | | |
| |||
1062 | 1078 | | |
1063 | 1079 | | |
1064 | 1080 | | |
1065 | | - | |
1066 | | - | |
| 1081 | + | |
| 1082 | + | |
| 1083 | + | |
| 1084 | + | |
| 1085 | + | |
| 1086 | + | |
| 1087 | + | |
| 1088 | + | |
| 1089 | + | |
| 1090 | + | |
| 1091 | + | |
| 1092 | + | |
| 1093 | + | |
| 1094 | + | |
| 1095 | + | |
| 1096 | + | |
| 1097 | + | |
| 1098 | + | |
| 1099 | + | |
| 1100 | + | |
| 1101 | + | |
| 1102 | + | |
| 1103 | + | |
| 1104 | + | |
1067 | 1105 | | |
1068 | 1106 | | |
1069 | 1107 | | |
| |||
1637 | 1675 | | |
1638 | 1676 | | |
1639 | 1677 | | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
1640 | 1715 | | |
1641 | 1716 | | |
1642 | 1717 | | |
| |||
1653 | 1728 | | |
1654 | 1729 | | |
1655 | 1730 | | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
1656 | 1736 | | |
1657 | 1737 | | |
1658 | 1738 | | |
1659 | 1739 | | |
1660 | 1740 | | |
1661 | 1741 | | |
1662 | 1742 | | |
1663 | | - | |
| 1743 | + | |
1664 | 1744 | | |
1665 | 1745 | | |
1666 | 1746 | | |
| |||
1688 | 1768 | | |
1689 | 1769 | | |
1690 | 1770 | | |
1691 | | - | |
| 1771 | + | |
1692 | 1772 | | |
1693 | 1773 | | |
1694 | | - | |
| 1774 | + | |
1695 | 1775 | | |
1696 | 1776 | | |
1697 | 1777 | | |
| |||
1722 | 1802 | | |
1723 | 1803 | | |
1724 | 1804 | | |
1725 | | - | |
| 1805 | + | |
1726 | 1806 | | |
1727 | 1807 | | |
1728 | 1808 | | |
1729 | 1809 | | |
1730 | 1810 | | |
1731 | 1811 | | |
| 1812 | + | |
| 1813 | + | |
| 1814 | + | |
| 1815 | + | |
| 1816 | + | |
| 1817 | + | |
1732 | 1818 | | |
1733 | 1819 | | |
1734 | 1820 | | |
1735 | 1821 | | |
1736 | | - | |
| 1822 | + | |
1737 | 1823 | | |
1738 | 1824 | | |
1739 | 1825 | | |
| |||
1857 | 1943 | | |
1858 | 1944 | | |
1859 | 1945 | | |
1860 | | - | |
| 1946 | + | |
1861 | 1947 | | |
1862 | 1948 | | |
1863 | 1949 | | |
| |||
0 commit comments