Remove more lazy access comments

Author: jdalton

eslint.config.js

@@ -58,7 +58,6 @@ if (process.env.LINT_EXTERNAL) {
 }
 
 function getIgnores(isEsm) {
-  // Lazily access constants.npmPackageNames.
   return constants.npmPackageNames.flatMap(sockRegPkgName => {
     const pkgPath = path.join(npmPackagesPath, sockRegPkgName)
     const { type } = readPackageJsonSync(pkgPath)
@@ -70,7 +69,6 @@ function getIgnores(isEsm) {
       if (
         globSync(['**/*.cjs'], {
           cwd: pkgPath,
-          // Lazily access constants.ignoreGlobs.
           ignores: constants.ignoreGlobs
         }).length
       ) {
@@ -171,15 +169,13 @@ function configs(sourceType) {
       'error',
       {
         ignores: ['Object.groupBy'],
-        // Lazily access constants.maintainedNodeVersions.
         version: constants.maintainedNodeVersions.current
       }
     ],
     'n/no-unsupported-features/es-syntax': [
       'error',
       {
         ignores: ['object-map-groupby'],
-        // Lazily access constants.maintainedNodeVersions.
         version: constants.maintainedNodeVersions.current
       }
     ],
@@ -192,7 +188,6 @@ function configs(sourceType) {
           'fs.promises.cp',
           'process.features.require_module'
         ],
-        // Lazily access constants.maintainedNodeVersions.
         version: constants.maintainedNodeVersions.current
       }
     ],

registry/lib/constants/skip-tests-by-ecosystem.js

@@ -17,7 +17,6 @@ module.exports = new Map([
       // Win32 environments for the time being.
       // https://github.com/es-shims/Date/issues/3
       // https://github.com/es-shims/Date/tree/v2.0.5
-      // Lazily access constants.ENV.
       ...(WIN32 ? [] : ['date']),
       // es6-object-assign has no unit tests.
       // https://github.com/rubennorte/es6-object-assign/tree/v1.1.0

scripts/lib/templates.js

@@ -56,10 +56,7 @@ function getTemplates() {
           TEMPLATE_ES_SHIM_CONSTRUCTOR,
           TEMPLATE_ES_SHIM_PROTOTYPE_METHOD,
           TEMPLATE_ES_SHIM_STATIC_METHOD
-        ].map(k =>
-          // Lazily access constants.npmTemplatesPath.
-          [k, path.join(constants.npmTemplatesPath, k)]
-        )
+        ].map(k => [k, path.join(constants.npmTemplatesPath, k)])
       )
     })
   }
@@ -108,7 +105,6 @@ async function getNpmReadmeAction(pkgPath, options) {
     {
       __proto__: null,
       readme: await renderAction([
-        // Lazily access constants.npmTemplatesPath.
         path.join(constants.npmTemplatesPath, README_MD),
         {
           __proto__: null,
@@ -143,9 +139,7 @@ async function getPackageJsonAction(pkgPath, options) {
       categories: Array.isArray(categories)
         ? categories
         : Array.from(PACKAGE_DEFAULT_SOCKET_CATEGORIES),
-      // Lazily access constants.PACKAGE_DEFAULT_NODE_RANGE.
       engines: engines ?? { node: constants.PACKAGE_DEFAULT_NODE_RANGE },
-      // Lazily access constants.PACKAGE_DEFAULT_VERSION.
       version: semver.parse(
         manifestData?.version ?? constants.PACKAGE_DEFAULT_VERSION
       )

scripts/update-npm-package-access.js

@@ -21,7 +21,6 @@ function packageData(data) {
 
 void (async () => {
   // Exit early if not running in CI or with --force.
-  // Lazily access constants.ENV.
   const { ENV } = constants
   if (!(cliArgs.force || ENV.CI)) {
     return
@@ -33,7 +32,6 @@ void (async () => {
       name: '@socketsecurity/registry',
       path: constants.registryPkgPath
     }),
-    // Lazily access constants.npmPackageNames.
     ...constants.npmPackageNames.map(sockRegPkgName =>
       packageData({
         name: `${SOCKET_REGISTRY_SCOPE}/${sockRegPkgName}`,
@@ -53,7 +51,6 @@ void (async () => {
             cwd: pkg.path,
             env: {
               ...process.env,
-              // Lazily access constants.ENV.NODE_AUTH_TOKEN.
               NODE_AUTH_TOKEN: ENV.NODE_AUTH_TOKEN
             }
           })

scripts/update-npm-package-json.js

@@ -19,7 +19,6 @@ const { PACKAGE_JSON, SOCKET_REGISTRY_SCOPE } = constants
 
 void (async () => {
   await Promise.all(
-    // Lazily access constants.npmPackageNames.
     constants.npmPackageNames.map(async sockRegPkgName => {
       const pkgPath = path.join(constants.npmPackagesPath, sockRegPkgName)
       const pkgJsonPath = path.join(pkgPath, PACKAGE_JSON)

scripts/update-npm-package-publish.js

@@ -38,7 +38,6 @@ async function publish(pkg, state = { fails: [] }) {
           cwd: pkg.path,
           env: {
             ...process.env,
-            // Lazily access constants.ENV.NODE_AUTH_TOKEN.
             NODE_AUTH_TOKEN: constants.ENV.NODE_AUTH_TOKEN
           }
         }
@@ -74,15 +73,13 @@ async function publishPackages(packages, state = { fails: [] }) {
 
 void (async () => {
   // Exit early if not running in CI or with --force.
-  // Lazily access constants.ENV.
   if (!(cliArgs.force || constants.ENV.CI)) {
     return
   }
 
   const fails = []
   const packages = [
     packageData({ name: '@socketsecurity/registry', path: registryPkgPath }),
-    // Lazily access constants.npmPackageNames.
     ...constants.npmPackageNames.map(sockRegPkgName => {
       const pkgPath = path.join(npmPackagesPath, sockRegPkgName)
       const pkgJson = readPackageJsonSync(pkgPath)

scripts/update-npm-readmes.js

@@ -18,7 +18,6 @@ void (async () => {
     return
   }
   await Promise.all(
-    // Lazily access constants.npmPackageNames.
     constants.npmPackageNames.map(async sockRegPkgName => {
       const pkgPath = path.join(npmPackagesPath, sockRegPkgName)
       const readmePath = path.join(pkgPath, README_MD)

scripts/update-package-json.js

@@ -5,7 +5,6 @@ const { runNpmScript } = require('@socketsecurity/registry/lib/npm')
 const { readPackageJson } = require('@socketsecurity/registry/lib/packages')
 
 void (async () => {
-  // Lazily access constants.rootPackageJsonPath.
   const rootEditablePkgJson = await readPackageJson(
     constants.rootPackageJsonPath,
     {
@@ -15,12 +14,10 @@ void (async () => {
   )
   // Update engines field.
   rootEditablePkgJson.update({
-    // Lazily access constants.PACKAGE_DEFAULT_NODE_RANGE.
     engines: { node: constants.PACKAGE_DEFAULT_NODE_RANGE }
   })
   await rootEditablePkgJson.save()
   await runNpmScript('update:package-lock', ['--', '--force'], {
-    // Lazily access constants.rootPath.
     cwd: constants.rootPath,
     stdio: 'inherit'
   })

scripts/update-tap-config.js

@@ -16,7 +16,6 @@ const { values: cliArgs } = util.parseArgs(constants.parseArgsConfig)
 void (async () => {
   const { tapConfigPath } = constants
   // Exit early if no relevant files have been modified.
-  // Lazily access constants.ENV.
   if (
     !cliArgs.force &&
     !constants.ENV.CI &&

scripts/update-test-npm-package-json.js

@@ -439,7 +439,6 @@ async function linkPackages(packageNames, options) {
         // Roughly check Node range as semver.coerce will strip leading
         // v's, carets (^), comparators (<,<=,>,>=,=), and tildes (~).
         semver.coerce(nodeRange),
-        // Lazily access constants.maintainedNodeVersions.
         constants.maintainedNodeVersions.last
       )
     ) {
@@ -667,7 +666,6 @@ void (async () => {
   ) {
     return
   }
-  // Lazily access constants.spinner.
   const { spinner } = constants
   spinner.start(`Initializing ${relTestNpmNodeModulesPath}...`)
   // Refresh/initialize test/npm/node_modules
@@ -681,10 +679,7 @@ void (async () => {
     spinner.errorAndStop('Initialization encountered an error:', e)
     return
   }
-  const packageNames = addingPkgNames
-    ? cliArgs.add
-    : // Lazily access constants.npmPackageNames.
-      constants.npmPackageNames
+  const packageNames = addingPkgNames ? cliArgs.add : constants.npmPackageNames
   await resolveDevDependencies(packageNames, { spinner })
   const linkedPackageNames = packageNames.length
     ? await linkPackages(packageNames, { spinner })