Skip to content

⚠️ [HIGH] Validation Middleware is a No-Op Pass-Through #996

Description

@ayomideadeniran

Description

The validateInput middleware function in backend/src/middleware/validation.js does nothing — it calls next() immediately without any validation logic.

Location

backend/src/middleware/validation.js:

export function validateInput(req, res, next) {
  next();
}

Impact

This middleware is imported and used in routes like backend/src/routes/v1/synthetic-assets.js:

import { validateInput } from ../../middleware/validation.js;

Routes that depend on this for input validation are processing unvalidated user input, which is a security risk.

Required Fix

Implement actual request validation in validation.js, including:

  • Body schema validation
  • Parameter sanitization
  • Type checking for expected input fields
  • Consider using a validation library (Joi, Zod, or similar)

Reference

Identified during full codebase audit of soroban-playground.

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programbackendBackend related issuesbugSomething isn't workingsecuritySecurity related issues

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions