レビュー受けての修正

Author: TrueRyoB

frontend/src/App.svelte

@@ -8,20 +8,19 @@
   import { type Problem, type ClosedRange, createValidRange } from "./utils/types";
   import { cacheInput, loadLastInput } from "./cacher";
 
-  const maxDiff = 3854;
-  const minDiff = 0;
+  const MinDiff:number = 0;
+  const MaxDiff:number = 3854;
 
   let cachedInput : ClosedRange | null = loadLastInput();
   let currentInput : ClosedRange | null;
 
-  let under_diff = $state<number>(cachedInput ? cachedInput.min : minDiff);
-  let over_diff = $state<number>(cachedInput ? cachedInput.max : maxDiff);
+  let under_diff = $state<number>(cachedInput ? cachedInput.min : MinDiff);
+  let over_diff = $state<number>(cachedInput ? cachedInput.max : MaxDiff);
   
   let errors = $derived({
-    rangeError: under_diff > over_diff,
+    rangeError: !(currentInput = createValidRange(under_diff, over_diff)),
     isMinusUnderDiff: under_diff < 0,
     isMinusOverDiff: over_diff < 0,
-    invalidRange: !(currentInput = createValidRange(under_diff, over_diff))
   });
 
   let result = $state<Problem | null>(null);
@@ -77,8 +76,6 @@
       <p class="text-destructive mb-2 text-sm">最高Diffが負の値になっています。</p>
     {:else if errors.isMinusUnderDiff}
       <p class="text-destructive mb-2 text-sm">最低Diffが負の値になっています</p>
-    {:else if errors.invalidRange}
-      <p class="text-destructive mb-2 text-sm">不正なDiff範囲になっています。</p>
     {/if}
 
     <div class="flex items-center gap-2">

frontend/src/cacher.ts

@@ -2,10 +2,10 @@ import type { ClosedRange } from './utils/types';
 
 const rangeKey : string = 'lastDiff';
 
-export function cacheInput(range : ClosedRange): void {
-    localStorage.setItem(rangeKey, JSON.stringify(range));
+export const cacheInput = (range : ClosedRange): void => {
+  localStorage.setItem(rangeKey, JSON.stringify(range));
 }
-export function loadLastInput(): ClosedRange | null {
-    const data = localStorage.getItem(rangeKey);
-    return data ? JSON.parse(data) as ClosedRange : null;
+export const loadLastInput = (): ClosedRange | null => {
+  const data = localStorage.getItem(rangeKey);
+  return data ? JSON.parse(data) as ClosedRange : null;
 }

frontend/src/utils/types.ts

@@ -11,12 +11,6 @@ export type ClosedRange = {
 } & { readonly __brand: unique symbol }; 
 
 // for validation
-export function createValidRange(min: number, max: number): ClosedRange | null {
-  if (min > max) return null;
-  
-  return {
-    min,
-    max,
-    __brand: Symbol('ClosedRange') as never
-  };
+export const createValidRange = (min: number, max: number): ClosedRange | null => {
+  return min>max ? null : {min, max, __brand: Symbol('ClosedRange') as never};
 }