-
Notifications
You must be signed in to change notification settings - Fork 28
Added Excerpt generation core functionality (no UI) #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Excerpt generation core functionality (no UI) #96
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @nholzmann. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dkotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good as a starting base for this Experiment. Left a few minor comments and there's also a PHPCS failure that needs cleaned up: https://github.com/WordPress/ai/actions/runs/19641726991/job/56246694268?pr=96
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #96 +/- ##
==============================================
+ Coverage 27.33% 38.91% +11.57%
- Complexity 152 176 +24
==============================================
Files 14 16 +2
Lines 900 1010 +110
==============================================
+ Hits 246 393 +147
+ Misses 654 617 -37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dkotter I've gone through the feedback here; I've tested and confirmed this works, screenshot attached from Postman showing the single excerpt with ~50 words. Please let me know if there's anything else needed here!
|
dkotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall things look good here, have left a handful of minor comments that need addressing but then this will be good to go.
@jeffpaul Curious on your thoughts here as far as next steps. Since this PR adds the base functionality for generating excerpts but doesn't add the UI yet, we could end up in a scenario where we merge this and before the UI part is finished, we want to do another release. This would result in partially finished work being released.
That's not the end of the world so is an option but we could also do one of the following:
- Create a new branch (i.e.
experiment/excerpt-generation) to use as our based. This PR could be merged into that instead ofdevelopand the UI portion would then branch off of that. Downside here is we then need a final PR that merges that branch intodevelop - We could merge this into
developbut could first remove the registration of the Experiment. So the code would go out in the next release but this wouldn't show on the settings page or be usable until the UI is done
The only folks who'd really see or benefit from it would be extenders, until the UI exists non-technical users won't have any benefit so I'm fine with the phased approach here even across releases. |

What?
Closes #11
Why?
This PR introduces the logic for generating Excerpts.
How?
We want to add a feature for Excerpt Generation and this is the start of that work. Decided instead of having everything be in a single PR I'd break things down into smaller chunks in order to hopefully speed up reviews and testing. This contains the initial feature class that registers an ability to generate one or more titles from content.
There will need to be followup PRs to handle (at least) the following:
Testing Instructions
Testing Instructions for Keyboard
There is no UI yet but can be tested by making direct API requests to the endpoint using an application password.
You should see a response like this:
Alternatively, this can be checked in postman (with the same username and application password)
Screenshots or screencast
Screenshot from CURL command:

Screenshot from Postman:
