Fix construction of script/style URL when version is null and args are supplied via enqueued handle #10608
Conversation
…queue-args * trac-64238-dependencies-phpstan: Use string type check before passing into in_default_dir() Specify that default_dirs may be null Fix typo Clarify WP_Dependencies::$args
* trunk: Docs: Improve accuracy for types in phpdoc for `WP_Dependencies`, `_WP_Dependency`, `WP_Scripts`, and `WP_Styles`.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
This is wild.
I've added a suggestion inline for additional tests separating out the register and enqueue calls. I think this hints at the intended purpose of this feature, which makes it no less wild.
| wp_enqueue_script( 'empty-deps-version', 'example.com', array(), '1.2' ); | ||
| wp_enqueue_script( 'empty-deps-null-version', 'example.com', array(), null ); | ||
| wp_enqueue_script( 'empty-deps-arg-in-handle-with-ver?arg1=foo&arg2=bar', 'https://example.com/test.js', array(), '2.0' ); | ||
| wp_enqueue_script( 'empty-deps-arg-in-handle-without-ver?arg1=foo&arg2=bar', 'https://example.com/test.js', array(), null ); |
There was a problem hiding this comment.
Add a test for the following, the expected output should include the handle's query string in the enqueue statement.
wp_register_script( 'registered-no-qs-handle-null-version-enqueued-with-qs', ... );
wp_enqueue_script( 'registered-no-qs-handle-null-version-enqueued-with-qs?arg1=foo&arg2=bar' );🔢 And same below for styles.
Co-authored-by: Peter Wilson <[email protected]>
2 participants
Trac ticket: https://core.trac.wordpress.org/ticket/64372
This pull request was based off of #10607
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.