Updates the alt text description text in both the media attachment po… #10609
+8
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st screen and media manager templates. Updates the alt text description text in both the media attachment post screen and media manager templates. The new text is clearer and more concise, and includes an external link icon for better user experience. Trac ticket: https://core.trac.wordpress.org/ticket/64374 --- **This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See [GitHub Pull Requests for Code Review](https://make.wordpress.org/core/handbook/contribute/git/github-pull-requests-for-code-review/) in the Core Handbook for more details.**
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Moves the dashicons-external icon outside the anchor tag so it appears after the link text rather than inside it. Fixes #64374
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Places the period before the external link icon for better visual flow and readability. Fixes #64374
westonruter
reviewed
Dec 8, 2025
| /* translators: 1: Link to tutorial, 2: Additional link attributes, 3: Accessibility text. */ | ||
| __( '<a href="%1$s" %2$s>Learn how to describe the purpose of the image%3$s</a>. Leave empty if the image is purely decorative.' ), | ||
| /* translators: 1: Link to tutorial, 2: Additional link attributes, 3: Accessibility text, 4: External link icon. */ | ||
| __( 'Alt text describes the image\'s purpose. Leave it blank if the image is purely decorative. <a href="%1$s" %2$s>Learn more about alt text%3$s</a>.%4$s' ), |
Member
There was a problem hiding this comment.
The right single quotation mark is more commonly used as an apostrophe for possessives in core's translated strings:
Suggested change
| __( 'Alt text describes the image\'s purpose. Leave it blank if the image is purely decorative. <a href="%1$s" %2$s>Learn more about alt text%3$s</a>.%4$s' ), | |
| __( 'Alt text describes the image’s purpose. Leave it blank if the image is purely decorative. <a href="%1$s" %2$s>Learn more about alt text%3$s</a>.%4$s' ), |
| /* translators: 1: Link to tutorial, 2: Additional link attributes, 3: Accessibility text. */ | ||
| __( '<a href="%1$s" %2$s>Learn how to describe the purpose of the image%3$s</a>. Leave empty if the image is purely decorative.' ), | ||
| /* translators: 1: Link to tutorial, 2: Additional link attributes, 3: Accessibility text, 4: External link icon. */ | ||
| __( 'Alt text describes the image\'s purpose. Leave it blank if the image is purely decorative. <a href="%1$s" %2$s>Learn more about alt text%3$s</a>.%4$s' ), |
Member
There was a problem hiding this comment.
Suggested change
| __( 'Alt text describes the image\'s purpose. Leave it blank if the image is purely decorative. <a href="%1$s" %2$s>Learn more about alt text%3$s</a>.%4$s' ), | |
| __( 'Alt text describes the image’s purpose. Leave it blank if the image is purely decorative. <a href="%1$s" %2$s>Learn more about alt text%3$s</a>.%4$s' ), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…st screen and media manager templates.
Updates the alt text description text in both the media attachment post screen and media manager templates. The new text is clearer and more concise, and includes an external link icon for better user experience.
Trac ticket: https://core.trac.wordpress.org/ticket/64374
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.