Add Notes column to posts list table #10611
+158
−44
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -705,12 +705,11 @@ public function get_columns() { | |||||
| if ( post_type_supports( $post_type, 'comments' ) | ||||||
| && ! in_array( $post_status, array( 'pending', 'draft', 'future' ), true ) | ||||||
| ) { | ||||||
| $posts_columns['comments'] = __( 'Comments' ); | ||||||
| } | ||||||
|
|
||||||
| if ( post_type_supports( $post_type, 'editor', 'notes' ) ) { | ||||||
| $posts_columns['notes'] = __( 'Notes' ); | ||||||
| } | ||||||
|
|
||||||
| $posts_columns['date'] = __( 'Date' ); | ||||||
|
|
@@ -762,27 +761,19 @@ protected function get_sortable_columns() { | |||||
|
|
||||||
| $post_type = $this->screen->post_type; | ||||||
|
|
||||||
| $title_orderby_text = __( 'Table ordered by Title.' ); | ||||||
|
|
||||||
| if ( 'page' === $post_type && ! isset( $_GET['orderby'] ) ) { | ||||||
| $title_orderby_text = __( 'Table ordered by Hierarchical Menu Order and Title.' ); | ||||||
| } | ||||||
|
|
||||||
| $sortables = array( | ||||||
| 'title' => array( 'title', false, __( 'Title' ), $title_orderby_text ), | ||||||
| 'parent' => array( 'parent', false ), | ||||||
| 'comments' => array( 'comment_count', false, __( 'Comments' ), __( 'Table ordered by Comments.' ) ), | ||||||
| 'notes' => array( 'note_count', false, __( 'Notes' ), __( 'Table ordered by Notes.' ) ), | ||||||
| 'date' => array( 'date', true, __( 'Date' ), __( 'Table ordered by Date.' ), 'desc' ), | ||||||
| ); | ||||||
| // Custom Post Types: there's a filter for that, see get_column_info(). | ||||||
|
|
||||||
| return $sortables; | ||||||
|
|
@@ -1263,11 +1254,29 @@ public function column_date( $post ) { | |||||
| public function column_comments( $post ) { | ||||||
| ?> | ||||||
| <div class="post-com-count-wrapper"> | ||||||
| <?php | ||||||
| $pending_comments = isset( $this->comment_pending_count[ $post->ID ] ) ? $this->comment_pending_count[ $post->ID ] : 0; | ||||||
|
|
||||||
| $this->comments_bubble( $post->ID, $pending_comments ); | ||||||
| ?> | ||||||
| </div> | ||||||
| <?php | ||||||
| } | ||||||
|
|
||||||
| /** | ||||||
| * Handles the notes column output. | ||||||
| * | ||||||
| * @since 7.0 | ||||||
|
Member
There was a problem hiding this comment.
Suggested change
|
||||||
| * | ||||||
| * @param WP_Post $post The current WP_Post object. | ||||||
| */ | ||||||
| public function column_notes( $post ) { | ||||||
| global $_wp_post_type_features; | ||||||
| ?> | ||||||
| <div class="post-com-count-wrapper"> | ||||||
| <?php | ||||||
| $this->notes_bubble( $post->ID ); | ||||||
| ?> | ||||||
| </div> | ||||||
| <?php | ||||||
| } | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2340,15 +2340,39 @@ function get_all_post_type_supports( $post_type ) { | |
| * | ||
| * @global array $_wp_post_type_features | ||
| * | ||
| * @param string $post_type The post type being checked. | ||
| * @param string $feature The feature being checked. | ||
| * @param string|null $sub_feature The sub-feature being checked. | ||
| * @return bool Whether the post type supports the given feature. | ||
| */ | ||
| function post_type_supports( $post_type, $feature, $sub_feature = null ) { | ||
|
Member
There was a problem hiding this comment. This change is best done in a separate ticket. See https://core.trac.wordpress.org/ticket/64156 and #10426 (comment) It will require extensive unit tests as well. |
||
| global $_wp_post_type_features; | ||
|
|
||
| if ( ! isset( $_wp_post_type_features[ $post_type ] ) ) { | ||
| return false; | ||
| } | ||
|
|
||
| if ( ! isset( $_wp_post_type_features[ $post_type ][ $feature ] ) ) { | ||
| return false; | ||
| } | ||
|
|
||
| if ( null === $sub_feature ) { | ||
| return ! empty( $_wp_post_type_features[ $post_type ][ $feature ] ); | ||
| } | ||
|
|
||
| if ( ! is_array( $_wp_post_type_features[ $post_type ][ $feature ] ) ) { | ||
| return false; | ||
| } | ||
|
|
||
| if ( array_key_exists( $sub_feature, $_wp_post_type_features[ $post_type ][ $feature ] ) ) { | ||
| return true; | ||
| } | ||
|
|
||
| $sub_features = array_merge( ...$_wp_post_type_features[ $post_type ][ $feature ] ); | ||
|
|
||
| return isset( $sub_features[ $sub_feature ] ); | ||
| } | ||
|
|
||
| /** | ||
| * Retrieves a list of post type names that support a specific feature. | ||
| * | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.