[Bug]: SimpleFIN throws obtuse error when payment for the subscription has failed

[jhollowe]

Verified issue does not already exist?

• I have searched and found no existing issue

What happened?

I had a fully-working SimpleFIN sync setup for several accounts. I accidentally let my SimpleFIN subscription lapse and so simpleFIN stopped returning data and instead returned an error. This is not handled well by the simpleFIN handler which throws a seemingly unrelated error (included below).

This should ideally be gracefully handled and surfaced to the user to inform them of this issue.

What error did you receive?

SimpleFIN returns the following error

$ curl -u 'AUTH_USER_HERE:AUTH_PASS_HERE' https://beta-bridge.simplefin.org/simplefin/accounts
{"errors":["Payment required."],"accounts":[]}

This shows up as the following error in the actual logs as:

Something went wrong TypeError: Cannot read properties of undefined (reading 'balance')
    at file:///app/src/app-simplefin/app-simplefin.js:73:36
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) [Function: sendErrorResponse]

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Windows 10

[psybers]

The SimpleFin docs state they will return a 402 "Payment required" in this case. Actual should check for non-200 responses and flag the sync as failing.

[psybers]

See the end of here for their responses: https://www.simplefin.org/protocol.html