[WIP] Move redux state to react-query - account states #6140
+2,463
−1,865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for actualbudget-website canceled.
|
Contributor
Bundle Statsdesktop-clientTotal
ChangesetFile | Δ | Size ---- | - | ---- `src/accounts/mutations.ts` | 🆕 +28.31 kB | 0 B → 28.31 kB `src/budget/mutations.ts` | 🆕 +17.61 kB | 0 B → 17.61 kB `node_modules/@tanstack/query-core/build/modern/queryObserver.js` | 🆕 +15.52 kB | 0 B → 15.52 kB `node_modules/@tanstack/query-core/build/modern/query.js` | 🆕 +11.35 kB | 0 B → 11.35 kB `node_modules/@tanstack/query-core/build/modern/queryClient.js` | 🆕 +8.82 kB | 0 B → 8.82 kB `node_modules/@tanstack/query-core/build/modern/mutation.js` | 🆕 +6.44 kB | 0 B → 6.44 kB `node_modules/@tanstack/query-core/build/modern/utils.js` | 🆕 +5.7 kB | 0 B → 5.7 kB `node_modules/@tanstack/query-core/build/modern/infiniteQueryBehavior.js` | 🆕 +3.73 kB | 0 B → 3.73 kB `node_modules/@tanstack/query-core/build/modern/mutationObserver.js` | 🆕 +3.32 kB | 0 B → 3.32 kB `node_modules/@tanstack/query-core/build/modern/mutationCache.js` | 🆕 +3.24 kB | 0 B → 3.24 kB `node_modules/@tanstack/query-core/build/modern/retryer.js` | 🆕 +3.18 kB | 0 B → 3.18 kB `node_modules/@tanstack/react-query/build/modern/useBaseQuery.js` | 🆕 +2.56 kB | 0 B → 2.56 kB `node_modules/@tanstack/query-core/build/modern/queryCache.js` | 🆕 +2.1 kB | 0 B → 2.1 kB `node_modules/@tanstack/query-core/build/modern/notifyManager.js` | 🆕 +1.81 kB | 0 B → 1.81 kB `node_modules/@tanstack/query-core/build/modern/timeoutManager.js` | 🆕 +1.71 kB | 0 B → 1.71 kB `node_modules/@tanstack/query-core/build/modern/focusManager.js` | 🆕 +1.39 kB | 0 B → 1.39 kB `node_modules/@tanstack/query-core/build/modern/onlineManager.js` | 🆕 +1.28 kB | 0 B → 1.28 kB `src/budget/queries.ts` | 🆕 +1.08 kB | 0 B → 1.08 kB `node_modules/@tanstack/react-query/build/modern/suspense.js` | 🆕 +1016 B | 0 B → 1016 B `node_modules/@tanstack/react-query/build/modern/useMutation.js` | 🆕 +912 B | 0 B → 912 B `node_modules/@tanstack/react-query/build/modern/errorBoundaryUtils.js` | 🆕 +699 B | 0 B → 699 B `src/accounts/queries.ts` | 🆕 +690 B | 0 B → 690 B `node_modules/@tanstack/query-core/build/modern/thenable.js` | 🆕 +633 B | 0 B → 633 B `node_modules/@tanstack/query-core/build/modern/removable.js` | 🆕 +599 B | 0 B → 599 B `node_modules/@tanstack/react-query/build/modern/QueryClientProvider.js` | 🆕 +572 B | 0 B → 572 B `node_modules/@tanstack/query-core/build/modern/subscribable.js` | 🆕 +454 B | 0 B → 454 B `node_modules/@tanstack/react-query/build/modern/QueryErrorResetBoundary.js` | 🆕 +392 B | 0 B → 392 B `src/hooks/useCategoriesQuery.ts` | 🆕 +245 B | 0 B → 245 B `src/hooks/useAccountsQuery.ts` | 🆕 +242 B | 0 B → 242 B `node_modules/@tanstack/react-query/build/modern/IsRestoringProvider.js` | 🆕 +160 B | 0 B → 160 B `node_modules/@tanstack/react-query/build/modern/useQuery.js` | 🆕 +92 B | 0 B → 92 B `node_modules/@tanstack/react-query/build/modern/queryOptions.js` | 🆕 +75 B | 0 B → 75 B `src/hooks/useOffBudgetAccounts.ts` | 📈 +60 B (+17.19%) | 349 B → 409 B `src/hooks/useOnBudgetAccounts.ts` | 📈 +59 B (+16.95%) | 348 B → 407 B `src/index.tsx` | 📈 +218 B (+14.13%) | 1.51 kB → 1.72 kB `src/redux/store.ts` | 📈 +115 B (+11.39%) | 1010 B → 1.1 kB `src/hooks/useAccount.ts` | 📈 +30 B (+7.28%) | 412 B → 442 B `src/modals/modalsSlice.ts` | 📈 +102 B (+4.76%) | 2.09 kB → 2.19 kB `src/components/budget/index.tsx` | 📈 +731 B (+4.60%) | 15.51 kB → 16.22 kB `locale/fr.json` | 📈 +6.33 kB (+3.68%) | 171.96 kB → 178.29 kB `src/global-events.ts` | 📈 +123 B (+3.24%) | 3.71 kB → 3.83 kB `src/components/accounts/Account.tsx` | 📈 +1.16 kB (+2.39%) | 48.52 kB → 49.68 kB `src/hooks/useCategory.ts` | 📈 +10 B (+2.28%) | 439 B → 449 B `src/components/modals/CreateLocalAccountModal.tsx` | 📈 +137 B (+2.09%) | 6.4 kB → 6.54 kB `src/components/banksync/EditSyncAccount.tsx` | 📈 +133 B (+1.84%) | 7.05 kB → 7.18 kB `src/components/modals/SelectLinkedAccountsModal.tsx` | 📈 +456 B (+1.63%) | 27.3 kB → 27.75 kB `src/components/mobile/budget/BudgetPage.tsx` | 📈 +689 B (+1.57%) | 42.87 kB → 43.54 kB `src/components/App.tsx` | 📈 +117 B (+1.53%) | 7.47 kB → 7.59 kB `src/components/mobile/banksync/MobileBankSyncAccountEditPage.tsx` | 📈 +142 B (+1.46%) | 9.47 kB → 9.61 kB `src/components/modals/ImportTransactionsModal/ImportTransactionsModal.tsx` | 📈 +393 B (+1.39%) | 27.54 kB → 27.92 kB `src/components/mobile/accounts/AccountPage.tsx` | 📈 +118 B (+1.25%) | 9.21 kB → 9.32 kB `src/components/sidebar/Account.tsx` | 📈 +164 B (+1.24%) | 12.87 kB → 13.03 kB `src/sync-events.ts` | 📈 +118 B (+1.18%) | 9.73 kB → 9.85 kB `src/components/modals/CloseAccountModal.tsx` | 📈 +104 B (+0.89%) | 11.46 kB → 11.56 kB `src/components/mobile/budget/ExpenseGroupList.tsx` | 📈 +38 B (+0.70%) | 5.31 kB → 5.34 kB `src/components/accounts/AccountSyncCheck.tsx` | 📈 +59 B (+0.63%) | 9.09 kB → 9.15 kB `src/components/mobile/accounts/AccountTransactions.tsx` | 📈 +60 B (+0.63%) | 9.34 kB → 9.4 kB `src/components/mobile/budget/IncomeCategoryList.tsx` | 📈 +18 B (+0.53%) | 3.31 kB → 3.33 kB `src/components/mobile/budget/ExpenseCategoryList.tsx` | 📈 +18 B (+0.46%) | 3.83 kB → 3.85 kB `src/components/FinancesApp.tsx` | 📈 +78 B (+0.44%) | 17.25 kB → 17.33 kB `src/components/mobile/accounts/AccountsPage.tsx` | 📈 +58 B (+0.27%) | 21.11 kB → 21.17 kB `src/components/transactions/TransactionsTable.tsx` | 📈 +214 B (+0.24%) | 85.39 kB → 85.6 kB `src/components/sidebar/Accounts.tsx` | 📈 +17 B (+0.20%) | 8.36 kB → 8.38 kB `locale/en.json` | 📈 +38 B (+0.02%) | 154.21 kB → 154.24 kB `src/components/select/RecurringSchedulePicker.tsx` | 📉 -2 B (-0.01%) | 31.02 kB → 31.01 kB `src/hooks/useTransactionFilters.ts` | 📉 -2 B (-0.23%) | 879 B → 877 B `src/components/autocomplete/CategoryAutocomplete.tsx` | 📉 -146 B (-0.85%) | 16.68 kB → 16.53 kB `src/hooks/useCategoryGroup.ts` | 📉 -6 B (-1.30%) | 463 B → 457 B `src/components/budget/BudgetTable.tsx` | 📉 -156 B (-1.35%) | 11.27 kB → 11.12 kB `src/app/appSlice.ts` | 📉 -605 B (-18.17%) | 3.25 kB → 2.66 kB `src/hooks/useCategories.ts` | 📉 -537 B (-64.70%) | 830 B → 293 B `src/hooks/useAccounts.ts` | 📉 -564 B (-69.29%) | 814 B → 250 B `src/accounts/accountsSlice.ts` | 📉 -9.64 kB (-88.00%) | 10.96 kB → 1.31 kB `src/budget/budgetSlice.ts` | 🔥 -9.65 kB (-100%) | 9.65 kB → 0 BView detailed bundle breakdown
**Added**
No assets were added
Removed Bigger
Smaller Unchanged
loot-coreTotal
ChangesetFile | Δ | Size ---- | - | ---- `home/runner/work/actual/actual/packages/loot-core/src/server/accounts/app.ts` | 📈 +966 B (+3.63%) | 26.01 kB → 26.95 kB `home/runner/work/actual/actual/packages/loot-core/src/server/api.ts` | 📈 +11 B (+0.04%) | 25.15 kB → 25.16 kBView detailed bundle breakdown
**Added**
Asset | File Size | % Changed
----- | --------- | ---------
kcab.worker.DBaXoUTx.js | 0 B → 5.79 MB (+5.79 MB) | -
Removed
Bigger Smaller Unchanged apiTotal
ChangesetFile | Δ | Size ---- | - | ---- `src/server/accounts/app.ts` | 📈 +878 B (+3.86%) | 22.2 kB → 23.05 kB `src/server/api.ts` | 📈 +11 B (+0.05%) | 22 kB → 22.01 kBView detailed bundle breakdown
**Added**
No assets were added
Removed Bigger
Smaller Unchanged |
Contributor
|
✅ VRT screenshots have been automatically updated. |
Contributor
|
✅ VRT screenshots have been automatically updated. |
joel-jeremy
commented
Nov 14, 2025
Member
Author
There was a problem hiding this comment.
Moved to packages/desktop-client/src/mocks.tsx
Contributor
|
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
Contributor
|
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
Contributor
|
This PR was closed because it has been stalled for 5 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.