-
Notifications
You must be signed in to change notification settings - Fork 1.9k
151 lines (134 loc) · 5.53 KB
/
Copy pathcheck-protected-classes.yml
File metadata and controls
151 lines (134 loc) · 5.53 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
name: Protected Classes
on: pull_request_target
concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true
jobs:
check-protected-classes:
runs-on: ubuntu-latest
name: Rolling Upgrade check
permissions:
issues: write
pull-requests: write
checks: write
steps:
- uses: actions/checkout@v6
with:
ref: ${{ github.event.pull_request.head.sha }}
fetch-depth: 0
- name: Rolling Upgrade check
id: check
run: |
BASE_SHA=${{ github.event.pull_request.base.sha }}
HEAD_SHA=${{ github.event.pull_request.head.sha }}
ANNOTATION='org.apache.ignite.internal.Order'
HITS_FILE=/tmp/protected-hits.txt
# Added/deleted/modified .java files in the PR as "<status>\t<path>" lines.
changed_java_files() {
git diff --name-status --no-renames --diff-filter=ADM "$BASE_SHA"..."$HEAD_SHA" -- '*.java'
}
# A protected class carries the @Order annotation; an added file is
# defined by the new revision, a deleted/modified one by the base.
is_protected_class() {
local status=$1 file=$2 ref=$BASE_SHA
[ "$status" = A ] && ref=$HEAD_SHA
git show "$ref:$file" 2>/dev/null | grep -q "$ANNOTATION"
}
# Read "<status>\t<path>" lines, emit the paths that are protected.
filter_protected() {
while IFS=$'\t' read -r status file; do
if is_protected_class "$status" "$file"; then
echo "$file"
fi
done
}
changed_java_files | filter_protected > "$HITS_FILE"
if [ -s "$HITS_FILE" ]; then
echo "affected=true" >> "$GITHUB_OUTPUT"
fi
- name: Comment on PR
if: steps.check.outputs.affected == 'true'
uses: actions/github-script@v8
with:
script: |
const fs = require('fs');
const hits = fs.readFileSync('/tmp/protected-hits.txt', 'utf8').trim();
const body = [
'## Possible compatibility issues. Please, check rolling upgrade cases',
'',
'This PR modifies protected classes (with **Order** annotation).',
'Changes to these classes can break rolling upgrade compatibility.',
'',
'**Affected files:**',
hits.split('\n').map(f => '- `' + f.trim() + '`').join('\n'),
'',
].join('\n');
const { data: comments } = await github.rest.issues.listComments({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
});
const existing = comments.find(c => c.body.includes('Possible compatibility issues. Please, check rolling upgrade cases'));
if (existing) {
await github.rest.issues.deleteComment({
owner: context.repo.owner,
repo: context.repo.repo,
comment_id: existing.id,
});
}
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
body,
});
- name: Add label
if: steps.check.outputs.affected == 'true'
uses: actions/github-script@v8
with:
script: |
await github.rest.issues.addLabels({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.issue.number,
labels: ['compatibility'],
});
- name: Warning check on affected
if: steps.check.outputs.affected == 'true'
uses: actions/github-script@v8
with:
script: |
const fs = require('fs');
const hits = fs.readFileSync('/tmp/protected-hits.txt', 'utf8').trim();
await github.rest.checks.create({
owner: context.repo.owner,
repo: context.repo.repo,
name: 'Rolling upgrade compatibility',
head_sha: context.payload.pull_request.head.sha,
status: 'completed',
conclusion: 'neutral',
output: {
title: 'Possible compatibility issues',
summary: [
'This PR modifies protected classes (with **Order** annotation).',
'Changes to these classes can break rolling upgrade compatibility.',
'',
'**Affected files:**',
hits.split('\n').map(f => '- `' + f.trim() + '`').join('\n'),
].join('\n'),
},
});