[SPARK-54624][UI] Ensure user name in historypage get escaped #53364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Dec 6, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM for Spark History Server.
Do we need this in the live UI too, @sarutak ?
Member
|
cc @yaooqinn |
Member
Author
I think we need no change for the live UI because user name in it is escaped in scala-xml side. 
|
yaooqinn
approved these changes
Dec 6, 2025
Member
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 6, 2025
### What changes were proposed in this pull request? This PR aims to escape user name displayed in historypage. ### Why are the changes needed? Similar to the issue resolved in #52851, user name should also get escaped because arbitrary user name can be set through the env var `SPARK_USER`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? User name displayed in historypage is escaped even if the name is like `<script>alert('XSS')</script>` ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53364 from sarutak/fix-username-xss. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9f3c6a3) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to escape user name displayed in historypage.
Why are the changes needed?
Similar to the issue resolved in #52851, user name should also get escaped because arbitrary user name can be set through the env var
SPARK_USER.Does this PR introduce any user-facing change?
No.
How was this patch tested?
User name displayed in historypage is escaped even if the name is like
<script>alert('XSS')</script>Was this patch authored or co-authored using generative AI tooling?
No.