[SPARK-54625][SQL] UTF8String#reverse should check offset and length on copying #53366
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Dec 6, 2025
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @sarutak .
Merged to master/4.1 for Apache Spark 4.1.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 6, 2025
…on copying ### What changes were proposed in this pull request? This PR aims to check offset and length on copying in `UTF8String#reverse`. For details, see https://lists.apache.org/thread/d9pvkh3jbsq8lc33v75kmwq5wg57422h (Only PMC members can read with login). To avoid performance regression, this PR choose to check offset and length rather than validate the input UTF-8 string. ### Why are the changes needed? For safety. ### Does this PR introduce _any_ user-facing change? Yes, but doesn't break compatibility. ### How was this patch tested? Example queries mentioned in [this thread](https://lists.apache.org/thread/d9pvkh3jbsq8lc33v75kmwq5wg57422h) works even though the results are broken. All the operation defined in `UTF8String` are expected to work correctly with valid UTF-8 strings so the broken results with invalid UTF-8 strings should be reasonable. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #53366 from sarutak/fix-utf8-reverse. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit e2722b8) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to check offset and length on copying in
UTF8String#reverse.For details, see https://lists.apache.org/thread/d9pvkh3jbsq8lc33v75kmwq5wg57422h (Only PMC members can read with login).
To avoid performance regression, this PR choose to check offset and length rather than validate the input UTF-8 string.
Why are the changes needed?
For safety.
Does this PR introduce any user-facing change?
Yes, but doesn't break compatibility.
How was this patch tested?
Example queries mentioned in this thread works even though the results are broken.
All the operation defined in
UTF8Stringare expected to work correctly with valid UTF-8 strings so the broken results with invalid UTF-8 strings should be reasonable.Was this patch authored or co-authored using generative AI tooling?
No.