Skip to content

Conversation

@KazuCocoa
Copy link
Member

This PR keeps setup.py for compatibility purposes, but we'll be able to delete it. Then, maybe it makes sense to bump the major version.

This PR still keeps current release.sh method yet.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the package build system from using setup.py sdist to uv build while maintaining backward compatibility by keeping setup.py for now. The changes modernize the build process by leveraging pyproject.toml as the primary configuration source.

Key changes:

  • Modified setup.py to read configuration from pyproject.toml instead of hardcoded values
  • Updated build script to use uv build instead of python setup.py sdist
  • Moved package metadata from dynamic to static configuration in pyproject.toml

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
setup.py Refactored to read metadata from pyproject.toml using tomllib/tomli
script/release.py Updated build command and upload process to use uv build and include wheel files
pyproject.toml Moved from dynamic to static metadata configuration and added build exclusions
README.md Simplified gitchangelog installation instruction

import io
import os

# FIXME: Remove this setup.py completely.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also have a TODO to remove release.py? I assume all uv-specific steps could be moved to a makefile script instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume release.py itself can be removed without major version update. I'm still modifying for it so still haven't ended with comment

@KazuCocoa KazuCocoa merged commit c095f79 into master Aug 7, 2025
12 checks passed
@KazuCocoa KazuCocoa deleted the uv-metadata branch August 7, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants