-
Notifications
You must be signed in to change notification settings - Fork 572
chore: use uv build to build the package #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the package build system from using setup.py sdist to uv build while maintaining backward compatibility by keeping setup.py for now. The changes modernize the build process by leveraging pyproject.toml as the primary configuration source.
Key changes:
- Modified
setup.pyto read configuration frompyproject.tomlinstead of hardcoded values - Updated build script to use
uv buildinstead ofpython setup.py sdist - Moved package metadata from dynamic to static configuration in
pyproject.toml
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| setup.py | Refactored to read metadata from pyproject.toml using tomllib/tomli |
| script/release.py | Updated build command and upload process to use uv build and include wheel files |
| pyproject.toml | Moved from dynamic to static metadata configuration and added build exclusions |
| README.md | Simplified gitchangelog installation instruction |
| import io | ||
| import os | ||
|
|
||
| # FIXME: Remove this setup.py completely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also have a TODO to remove release.py? I assume all uv-specific steps could be moved to a makefile script instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume release.py itself can be removed without major version update. I'm still modifying for it so still haven't ended with comment
This PR keeps
setup.pyfor compatibility purposes, but we'll be able to delete it. Then, maybe it makes sense to bump the major version.This PR still keeps current
release.shmethod yet.