Skip to content

Commit da60019

Browse files
Remove unneeded code for docker push and push only one tag when publishing preview
1 parent d3f3968 commit da60019

File tree

1 file changed

+12
-29
lines changed

1 file changed

+12
-29
lines changed

Makefile

Lines changed: 12 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,16 @@ VERSION_MAJOR := $(shell echo $(VERSION_MAJOR_MINOR) | cut -f 1 -d '.')
1010
COMMIT := $(shell git rev-parse --short HEAD)
1111
MAKEFILE := $(ROOTDIR)/Makefile
1212

13-
MULTIARCH ?= 1
13+
DOCKERNAMESPACE ?= arangodb
14+
IMAGE_NAME := $(DOCKERNAMESPACE)/arangodb-starter
15+
16+
STARTER_TAGS := -t $(IMAGE_NAME):$(VERSION)
17+
ifeq (, $(findstring -preview,$(VERSION)))
18+
STARTER_TAGS = -t $(IMAGE_NAME):$(VERSION) \
19+
-t $(IMAGE_NAME):$(VERSION_MAJOR_MINOR) \
20+
-t $(IMAGE_NAME):$(VERSION_MAJOR) \
21+
-t $(IMAGE_NAME):latest
22+
endif
1423

1524
ALPINE_IMAGE ?= alpine:3.16
1625

@@ -46,7 +55,6 @@ ifeq ("$(GOOS)", "windows")
4655
endif
4756

4857
ARANGODB ?= arangodb/arangodb:latest
49-
DOCKERNAMESPACE ?= arangodb
5058

5159
IP ?= $(shell hostname -I | cut -d ' ' -f 1)
5260

@@ -177,34 +185,9 @@ docker: binaries
177185
$(DOCKERMACLI) -t arangodb/arangodb-starter .
178186
endif
179187

180-
ifneq ($(MULTIARCH),1)
181-
docker-push: docker
182-
ifneq ($(DOCKERNAMESPACE), arangodb)
183-
docker tag arangodb/arangodb-starter $(DOCKERNAMESPACE)/arangodb-starter
184-
endif
185-
docker push $(DOCKERNAMESPACE)/arangodb-starter
186-
else
187-
docker-push: docker
188-
$(DOCKERMACLI) --push -t $(DOCKERNAMESPACE)/arangodb-starter .
189-
endif
190-
191-
ifneq ($(MULTIARCH),1)
192-
docker-push-version: docker
193-
docker tag arangodb/arangodb-starter arangodb/arangodb-starter:$(VERSION)
194-
docker tag arangodb/arangodb-starter arangodb/arangodb-starter:$(VERSION_MAJOR_MINOR)
195-
docker tag arangodb/arangodb-starter arangodb/arangodb-starter:$(VERSION_MAJOR)
196-
docker tag arangodb/arangodb-starter arangodb/arangodb-starter:latest
197-
docker push arangodb/arangodb-starter:$(VERSION)
198-
docker push arangodb/arangodb-starter:$(VERSION_MAJOR_MINOR)
199-
docker push arangodb/arangodb-starter:$(VERSION_MAJOR)
200-
docker push arangodb/arangodb-starter:latest
201-
else
202188
docker-push-version: docker
203-
$(DOCKERMACLI) --push -t arangodb/arangodb-starter:$(VERSION) .
204-
$(DOCKERMACLI) --push -t arangodb/arangodb-starter:$(VERSION_MAJOR_MINOR) .
205-
$(DOCKERMACLI) --push -t arangodb/arangodb-starter:$(VERSION_MAJOR) .
206-
$(DOCKERMACLI) --push -t arangodb/arangodb-starter:latest .
207-
endif
189+
$(DOCKERMACLI) --push $(STARTER_TAGS) .
190+
208191

209192
$(RELEASE): $(GOBUILDDIR) $(GO_SOURCES)
210193
$(DOCKER_CMD) go build -o "$(RELEASE_BIN)" $(REPOPATH)/tools/release

0 commit comments

Comments
 (0)