feat(argo-cd): allowing apiVersions customization

[brunosimsenhor]

Allow customization of the apiVersion for some of the CRDs.

It all started to improve the integration with the Azure Managed Prometheus implementation.

See docs.

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• I have created a separate pull request for each chart according to pull requests
• My build is green (troubleshooting builds).

[mkilchhofer]

Hi @brunosimsenhor

Sorry for the late reply.
Would it be possible for you to refactor it to use the same approach as in argo-workflows to keep our chart harmonized for the core functionality?

argo-helm/charts/argo-workflows/values.yaml

Lines 39 to 46 in 090b818

	# Override APIVersions
	apiVersionOverrides:
	# -- String to override apiVersion of autoscaling rendered by this helm chart
	autoscaling: "" # autoscaling/v2
	# -- String to override apiVersion of GKE resources rendered by this helm chart
	cloudgoogle: "" # cloud.google.com/v1
	# -- String to override apiVersion of monitoring CRDs (ServiceMonitor) rendered by this helm chart
	monitoring: "" # monitoring.coreos.com/v1

Related PR for the monitoring CRDs:

• feat(argo-workflows): check prometheus CRD for ServiceMonitor #2430

[brunosimsenhor]

Hi @brunosimsenhor

Sorry for the late reply. Would it be possible for you to refactor it to use the same approach as in argo-workflows to keep our chart harmonized for the core functionality?

argo-helm/charts/argo-workflows/values.yaml

Lines 39 to 46 in 090b818

	# Override APIVersions
	apiVersionOverrides:
	# -- String to override apiVersion of autoscaling rendered by this helm chart
	autoscaling: "" # autoscaling/v2
	# -- String to override apiVersion of GKE resources rendered by this helm chart
	cloudgoogle: "" # cloud.google.com/v1
	# -- String to override apiVersion of monitoring CRDs (ServiceMonitor) rendered by this helm chart
	monitoring: "" # monitoring.coreos.com/v1

Related PR for the monitoring CRDs:

• feat(argo-workflows): check prometheus CRD for ServiceMonitor #2430

Done!

[mkilchhofer]

Hi @brunosimsenhor
Sorry for the late reply. Would it be possible for you to refactor it to use the same approach as in argo-workflows to keep our chart harmonized for the core functionality?

argo-helm/charts/argo-workflows/values.yaml

Lines 39 to 46 in 090b818

	# Override APIVersions
	apiVersionOverrides:
	# -- String to override apiVersion of autoscaling rendered by this helm chart
	autoscaling: "" # autoscaling/v2
	# -- String to override apiVersion of GKE resources rendered by this helm chart
	cloudgoogle: "" # cloud.google.com/v1
	# -- String to override apiVersion of monitoring CRDs (ServiceMonitor) rendered by this helm chart
	monitoring: "" # monitoring.coreos.com/v1

Related PR for the monitoring CRDs:

• feat(argo-workflows): check prometheus CRD for ServiceMonitor #2430

Done!

Since your intent is to support Azure monitor things, can you revert all the changes outside the ServiceMonitors? I think we don't need customization for the other apiVersions at the moment (no user asked for this). :)

Also, please add the accessed values to the values.yaml. And then run helm-docs. This should end in a green CI run.

Thank you for your contribution 🙏

[brunosimsenhor]

Hi @brunosimsenhor
Sorry for the late reply. Would it be possible for you to refactor it to use the same approach as in argo-workflows to keep our chart harmonized for the core functionality?

argo-helm/charts/argo-workflows/values.yaml

Lines 39 to 46 in 090b818

	# Override APIVersions
	apiVersionOverrides:
	# -- String to override apiVersion of autoscaling rendered by this helm chart
	autoscaling: "" # autoscaling/v2
	# -- String to override apiVersion of GKE resources rendered by this helm chart
	cloudgoogle: "" # cloud.google.com/v1
	# -- String to override apiVersion of monitoring CRDs (ServiceMonitor) rendered by this helm chart
	monitoring: "" # monitoring.coreos.com/v1

Related PR for the monitoring CRDs:

• feat(argo-workflows): check prometheus CRD for ServiceMonitor #2430

Done!

Since your intent is to support Azure monitor things, can you revert all the changes outside the ServiceMonitors? I think we don't need customization for the other apiVersions at the moment (no user asked for this). :)

Also, please add the accessed values to the values.yaml. And then run helm-docs. This should end in a green CI run.

Thank you for your contribution 🙏

@mkilchhofer, I rolled back and kept only the changes related to the ServiceMonitor, the PrometheusRule is not supported by the Azure Managed Prometheus integration.