add enum for direction of order

Author: pavog

README.md

@@ -228,9 +228,9 @@ User::query(new \Aternos\Model\Query\SelectQuery(
         ], \Aternos\Model\Query\WhereGroup:: OR)
     ]),
     [
-        new \Aternos\Model\Query\OrderField("field", \Aternos\Model\Query\OrderField::DESCENDING),
-        new \Aternos\Model\Query\OrderField("hello", \Aternos\Model\Query\OrderField::ASCENDING),
-        new \Aternos\Model\Query\OrderField("foo", \Aternos\Model\Query\OrderField::DESCENDING)
+        new \Aternos\Model\Query\OrderField("field", \Aternos\Model\Query\Direction::DESCENDING),
+        new \Aternos\Model\Query\OrderField("hello", \Aternos\Model\Query\Direction::ASCENDING),
+        new \Aternos\Model\Query\OrderField("foo", \Aternos\Model\Query\Direction::DESCENDING)
     ],
     [
         new \Aternos\Model\Query\SelectField("field"), 

src/Query/Direction.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace Aternos\Model\Query;
+
+enum Direction
+{
+    case ASCENDING;
+    case DESCENDING;
+}

src/Query/Generator/SQL.php

@@ -3,6 +3,7 @@
 namespace Aternos\Model\Query\Generator;
 
 use Aternos\Model\Query\{DeleteQuery,
+    Direction,
     OrderField,
     Query,
     SelectField,
@@ -171,9 +172,8 @@ private function generateOrder(Query $query): string
         foreach ($orderFields as $orderField) {
             /** @var OrderField $orderField */
             $direction = match ($orderField->direction) {
-                OrderField::ASCENDING => "ASC",
-                OrderField::DESCENDING => "DESC",
-                default => throw new UnexpectedValueException("Invalid direction: " . $orderField->direction),
+                Direction::ASCENDING => "ASC",
+                Direction::DESCENDING => "DESC",
             };
 
             if ($orderField->raw) {

src/Query/OrderField.php

@@ -9,11 +9,6 @@
  */
 class OrderField
 {
-    /**
-     * Direction constants
-     */
-    const int ASCENDING = 0;
-    const int DESCENDING = 1;
 
     /**
      * Field name to order by
@@ -30,17 +25,17 @@ class OrderField
     /**
      * Order direction
      *
-     * @var int
+     * @var Direction
      */
-    public int $direction = self::ASCENDING;
+    public Direction $direction = Direction::ASCENDING;
 
     /**
      * OrderField constructor.
      *
      * @param string|null $field
-     * @param int $direction
+     * @param Direction $direction
      */
-    public function __construct(?string $field = null, int $direction = self::ASCENDING)
+    public function __construct(?string $field = null, Direction $direction = Direction::ASCENDING)
     {
         $this->field = $field;
         $this->direction = $direction;
@@ -57,10 +52,10 @@ public function setRaw(bool $raw): OrderField
     }
 
     /**
-     * @param int $direction
+     * @param Direction $direction
      * @return OrderField
      */
-    public function setDirection(int $direction): OrderField
+    public function setDirection(Direction $direction): OrderField
     {
         $this->direction = $direction;
         return $this;

src/Query/Query.php

@@ -111,8 +111,8 @@ public function orderBy(array $order): static
 
             if (!is_int($value)) {
                 $value = match (strtoupper($value)) {
-                    "ASCENDING", "ASC" => OrderField::ASCENDING,
-                    "DESCENDING", "DESC" => OrderField::DESCENDING,
+                    "ASCENDING", "ASC" => Direction::ASCENDING,
+                    "DESCENDING", "DESC" => Direction::DESCENDING,
                     default => throw new InvalidArgumentException('Argument $order contains invalid order direction: ' . $value),
                 };
             }

test/tests/TestDriverTest.php

@@ -6,6 +6,7 @@
 use Aternos\Model\Driver\Test\TestDriver;
 use Aternos\Model\Query\CountField;
 use Aternos\Model\Query\DeleteQuery;
+use Aternos\Model\Query\Direction;
 use Aternos\Model\Query\MaxField;
 use Aternos\Model\Query\MinField;
 use Aternos\Model\Query\OrderField;
@@ -337,7 +338,7 @@ public function testSelectLikeEscaping(): void
 
     public function testSelectOrder(): void
     {
-        $models = TestModel::select(order: ["number" => OrderField::DESCENDING]);
+        $models = TestModel::select(order: ["number" => Direction::DESCENDING]);
         $this->assertCount(10, $models);
         $this->assertEquals("9J", $models[0]->id);
         $this->assertEquals("J", $models[0]->text);