chore(.eslintrc.json): add prefer-const, no-console (#3622)

Helias · web-flow · commit 39609fdc50f5 · 2025-11-04T10:06:52.000+01:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -44,7 +44,9 @@
         "@typescript-eslint/no-explicit-any": "off",
         "@typescript-eslint/ban-ts-comment": "off",
         "no-duplicate-imports": "error",
-        "require-await": "error"
+        "require-await": "error",
+        "prefer-const": "error",
+        "no-console": ["error", { "allow": ["warn", "info", "error"] }]
       }
     },
     {
diff --git a/libs/shared/base-abstract-classes/src/service/editors/multi-row-editor.service.ts b/libs/shared/base-abstract-classes/src/service/editors/multi-row-editor.service.ts
@@ -163,9 +163,9 @@ export abstract class MultiRowEditorService<T extends TableRow> extends EditorSe
         control.setValue(selectedRow[field]);
       } else {
         console.error(`Control '${field}' does not exist!`);
-        console.log(`----------- DEBUG CONTROL KEYS:`);
+        console.info(`----------- DEBUG CONTROL KEYS:`);
         for (const k of Object.keys(this._form.controls)) {
-          console.log(k);
+          console.info(k);
         }
       }
     }
diff --git a/libs/shared/base-abstract-classes/src/service/editors/single-row-editor.service.ts b/libs/shared/base-abstract-classes/src/service/editors/single-row-editor.service.ts
@@ -1,6 +1,6 @@
 import { Class, TableRow } from '@keira/shared/constants';
-import { distinctUntilChanged } from 'rxjs';
 import { compareObjFn, getNumberOrString } from '@keira/shared/utils';
+import { distinctUntilChanged } from 'rxjs';
 import { EditorService } from './editor.service';
 
 export abstract class SingleRowEditorService<T extends TableRow> extends EditorService<T> {
@@ -90,9 +90,9 @@ export abstract class SingleRowEditorService<T extends TableRow> extends EditorS
         control.setValue(this._originalValue[field]);
       } else {
         console.error(`Control '${field}' does not exist!`);
-        console.log(`----------- DEBUG CONTROL KEYS:`);
+        console.info(`----------- DEBUG CONTROL KEYS:`);
         for (const k of Object.keys(this._form.controls)) {
-          console.log(k);
+          console.info(k);
         }
       }
     }
diff --git a/libs/shared/db-layer/src/mysql.service.spec.ts b/libs/shared/db-layer/src/mysql.service.spec.ts
@@ -1,13 +1,13 @@
-import { TestBed } from '@angular/core/testing';
 import { provideZonelessChangeDetection } from '@angular/core';
+import { TestBed } from '@angular/core/testing';
 import { provideNoopAnimations } from '@angular/platform-browser/animations';
+import { ElectronService } from '@keira/shared/common-services';
 import { Connection, ConnectionOptions, QueryError } from 'mysql2';
+import { tickAsync } from 'ngx-page-object-model';
 import { Subscriber } from 'rxjs';
 import { instance, mock, reset } from 'ts-mockito';
-import { ElectronService } from '@keira/shared/common-services';
 import { MysqlService } from './mysql.service';
 import Spy = jasmine.Spy;
-import { tickAsync } from 'ngx-page-object-model';
 
 class MockMySql {
   createConnection() {}
@@ -213,7 +213,7 @@ describe('MysqlService', () => {
   it('reconnect() should correctly work ', async () => {
     service['_reconnecting'] = false;
     spyOn(service['_connectionLostSubject'], 'next');
-    spyOn(console, 'log');
+    spyOn(console, 'info');
     (service as any).mysql = new MockMySql();
     const mockConnection = new MockConnection();
     spyOn((service as any).mysql, 'createConnection').and.returnValue(mockConnection);
@@ -223,8 +223,8 @@ describe('MysqlService', () => {
     expect(service['_reconnecting']).toBe(true);
     expect(service['_connectionLostSubject'].next).toHaveBeenCalledTimes(1);
     expect(service['_connectionLostSubject'].next).toHaveBeenCalledWith(false);
-    expect(console.log).toHaveBeenCalledTimes(1);
-    expect(console.log).toHaveBeenCalledWith(`DB connection lost. Reconnecting in 500 ms...`);
+    expect(console.info).toHaveBeenCalledTimes(1);
+    expect(console.info).toHaveBeenCalledWith(`DB connection lost. Reconnecting in 500 ms...`);
 
     await tickAsync(500);
     expect(service['_connection']).toEqual(mockConnection as unknown as Connection);
diff --git a/libs/shared/db-layer/src/mysql.service.ts b/libs/shared/db-layer/src/mysql.service.ts
@@ -81,7 +81,7 @@ export class MysqlService {
     this._reconnecting = true;
     this._connectionLostSubject.next(false);
     const RECONNECTION_TIME_MS = 500;
-    console.log(`DB connection lost. Reconnecting in ${RECONNECTION_TIME_MS} ms...`);
+    console.info(`DB connection lost. Reconnecting in ${RECONNECTION_TIME_MS} ms...`);
 
     setTimeout(() => {
       this._connection = this.mysql.createConnection(this.config);
@@ -129,7 +129,7 @@ export class MysqlService {
     return (err: QueryError | null, result?: T[], fields?: FieldInfo[]) => {
       this.ngZone.run(() => {
         if (err) {
-          console.log(`Error when executing query: \n\n${err.stack}`);
+          console.info(`Error when executing query: \n\n${err.stack}`);
           subscriber.error(err);
         } else {
           subscriber.next({ result, fields });
diff --git a/libs/shared/db-layer/src/query/mysql-query.service.spec.ts b/libs/shared/db-layer/src/query/mysql-query.service.spec.ts
@@ -54,13 +54,13 @@ describe('MysqlQueryService', () => {
   });
 
   it('query() should call mysqlService.dbQuery() and output query and results if debug mode is enabled', () => {
-    const logSpy = spyOn(console, 'log');
+    const infoSpy = spyOn(console, 'info');
     configService.debugMode.set(true);
     const querySpy = spyOn(TestBed.inject(MysqlService), 'dbQuery').and.returnValue(of({ id: 'mock value' } as TableRow));
     const myQuery = 'SELECT azerothcore FROM projects;';
 
     service.query(myQuery).subscribe(() => {
-      expect(logSpy).toHaveBeenCalledTimes(2);
+      expect(infoSpy).toHaveBeenCalledTimes(2);
     });
 
     expect(querySpy).toHaveBeenCalledWith(myQuery, undefined);
diff --git a/libs/shared/db-layer/src/query/mysql-query.service.ts b/libs/shared/db-layer/src/query/mysql-query.service.ts
@@ -25,8 +25,8 @@ export class MysqlQueryService extends BaseQueryService {
     return this.mysqlService.dbQuery<T>(queryString, values).pipe(
       tap((val) => {
         if (this.configService.debugMode()) {
-          console.log(`\n${queryString}`);
-          console.log(val);
+          console.info(`\n${queryString}`);
+          console.info(val);
         }
       }),
       map((val) => val?.result),
diff --git a/libs/shared/db-layer/src/query/sqlite-query.service.ts b/libs/shared/db-layer/src/query/sqlite-query.service.ts
@@ -21,8 +21,8 @@ export class SqliteQueryService extends BaseQueryService {
     return this.sqliteService.dbQuery<T>(queryString).pipe(
       tap((val) => {
         if (this.configService.debugMode() && !silent) {
-          console.log(`\n${queryString}`);
-          console.log(val);
+          console.info(`\n${queryString}`);
+          console.info(val);
         }
       }),
     );
diff --git a/libs/shared/db-layer/src/sqlite.service.ts b/libs/shared/db-layer/src/sqlite.service.ts
@@ -1,9 +1,9 @@
 import { Injectable, NgZone, inject } from '@angular/core';
 
+import { ElectronService } from '@keira/shared/common-services';
 import { KEIRA_APP_CONFIG_TOKEN, KeiraAppConfig } from '@keira/shared/config';
 import { TableRow } from '@keira/shared/constants';
 import { Observable, Subscriber } from 'rxjs';
-import { ElectronService } from '@keira/shared/common-services';
 
 /* istanbul ignore next */ // Note: will be tested in e2e
 @Injectable({
@@ -23,7 +23,7 @@ export class SqliteService {
       const sqlite = window.require('sqlite3');
       this.db = new sqlite.Database(KEIRA_APP_CONFIG.sqlitePath, sqlite.OPEN_READONLY, (error: unknown) => {
         if (error) {
-          console.log(`Error when opening sqlite database at ${KEIRA_APP_CONFIG.sqlitePath}`);
+          console.info(`Error when opening sqlite database at ${KEIRA_APP_CONFIG.sqlitePath}`);
           console.error(error);
         }
       });
@@ -45,7 +45,7 @@ export class SqliteService {
     return (err: Error | null, results: T[]) => {
       this.ngZone.run(() => {
         if (err) {
-          console.log(`Error when executing sqlite query: \n\n`);
+          console.info(`Error when executing sqlite query: \n\n`);
           console.error(err);
           subscriber.error(err);
         } else {
diff --git a/libs/shared/model-3d-viewer/src/helper.ts b/libs/shared/model-3d-viewer/src/helper.ts
@@ -133,7 +133,7 @@ export function getShadowlandDisplayId(
     const sqlite = window.require('sqlite3');
     const db = new sqlite.Database(sqliteItem3dPath, sqlite.OPEN_READONLY, (error: unknown) => {
       if (error) {
-        console.log(`Error when opening sqlite database at DISPLAY ID`);
+        console.info(`Error when opening sqlite database at DISPLAY ID`);
         console.error(error);
       }
     });
@@ -148,7 +148,7 @@ export function getShadowlandDisplayId(
             if (data.length && 'ItemDisplayInfoID' in data[0]) {
               resolve({ displayId: data[0].ItemDisplayInfoID, displayType: data[0].DisplayType });
             } else {
-              console.log('no ItemDisplayInfoID available for this item');
+              console.info('no ItemDisplayInfoID available for this item');
             }
           }
         },

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,9 @@`
`44`	`44`	`"@typescript-eslint/no-explicit-any": "off",`
`45`	`45`	`"@typescript-eslint/ban-ts-comment": "off",`
`46`	`46`	`"no-duplicate-imports": "error",`
`47`		`- "require-await": "error"`
	`47`	`+ "require-await": "error",`
	`48`	`+ "prefer-const": "error",`
	`49`	`+ "no-console": ["error", { "allow": ["warn", "info", "error"] }]`
`48`	`50`	`}`
`49`	`51`	`},`
`50`	`52`	`{`
Original file line number	Diff line number	Diff line change
`@@ -163,9 +163,9 @@ export abstract class MultiRowEditorService<T extends TableRow> extends EditorSe`
`163`	`163`	`control.setValue(selectedRow[field]);`
`164`	`164`	`} else {`
`165`	`165`	console.error(`Control '${field}' does not exist!`);
`166`		- console.log(`----------- DEBUG CONTROL KEYS:`);
	`166`	+ console.info(`----------- DEBUG CONTROL KEYS:`);
`167`	`167`	`for (const k of Object.keys(this._form.controls)) {`
`168`		`- console.log(k);`
	`168`	`+ console.info(k);`
`169`	`169`	`}`
`170`	`170`	`}`
`171`	`171`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`import { Class, TableRow } from '@keira/shared/constants';`
`2`		`-import { distinctUntilChanged } from 'rxjs';`
`3`	`2`	`import { compareObjFn, getNumberOrString } from '@keira/shared/utils';`
	`3`	`+import { distinctUntilChanged } from 'rxjs';`
`4`	`4`	`import { EditorService } from './editor.service';`
`5`	`5`
`6`	`6`	`export abstract class SingleRowEditorService<T extends TableRow> extends EditorService<T> {`
`@@ -90,9 +90,9 @@ export abstract class SingleRowEditorService<T extends TableRow> extends EditorS`
`90`	`90`	`control.setValue(this._originalValue[field]);`
`91`	`91`	`} else {`
`92`	`92`	console.error(`Control '${field}' does not exist!`);
`93`		- console.log(`----------- DEBUG CONTROL KEYS:`);
	`93`	+ console.info(`----------- DEBUG CONTROL KEYS:`);
`94`	`94`	`for (const k of Object.keys(this._form.controls)) {`
`95`		`- console.log(k);`
	`95`	`+ console.info(k);`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`	`}`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ export function getShadowlandDisplayId(`
`133`	`133`	`const sqlite = window.require('sqlite3');`
`134`	`134`	`const db = new sqlite.Database(sqliteItem3dPath, sqlite.OPEN_READONLY, (error: unknown) => {`
`135`	`135`	`if (error) {`
`136`		- console.log(`Error when opening sqlite database at DISPLAY ID`);
	`136`	+ console.info(`Error when opening sqlite database at DISPLAY ID`);
`137`	`137`	`console.error(error);`
`138`	`138`	`}`
`139`	`139`	`});`
`@@ -148,7 +148,7 @@ export function getShadowlandDisplayId(`
`148`	`148`	`if (data.length && 'ItemDisplayInfoID' in data[0]) {`
`149`	`149`	`resolve({ displayId: data[0].ItemDisplayInfoID, displayType: data[0].DisplayType });`
`150`	`150`	`} else {`
`151`		`- console.log('no ItemDisplayInfoID available for this item');`
	`151`	`+ console.info('no ItemDisplayInfoID available for this item');`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`	`},`