From 5c65bfb8d22545eff6b9197c68a90eb4ff67d7b9 Mon Sep 17 00:00:00 2001
From: Cameron Aragon <69489633+camaragon@users.noreply.github.com>
Date: Fri, 28 Aug 2026 05:10:41 +0000
Subject: [PATCH] fix(desktop): hide resting markdown link underlines

Signed-off-by: Cameron Aragon <69489633+camaragon@users.noreply.github.com>
---
 .../ui/markdown/ExternalLinkAnchor.test.mjs   | 32 +++++++++++++++++++
 .../shared/ui/markdown/ExternalLinkAnchor.tsx |  2 +-
 2 files changed, 33 insertions(+), 1 deletion(-)
 create mode 100644 desktop/src/shared/ui/markdown/ExternalLinkAnchor.test.mjs

diff --git a/desktop/src/shared/ui/markdown/ExternalLinkAnchor.test.mjs b/desktop/src/shared/ui/markdown/ExternalLinkAnchor.test.mjs
new file mode 100644
index 00000000000..115ae194eb2
--- /dev/null
+++ b/desktop/src/shared/ui/markdown/ExternalLinkAnchor.test.mjs
@@ -0,0 +1,32 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+
+import React from "react";
+import { renderToStaticMarkup } from "react-dom/server";
+
+import { TooltipProvider } from "../tooltip.tsx";
+import { ExternalLinkAnchor } from "./ExternalLinkAnchor.tsx";
+
+test("external markdown links rest without an underline", () => {
+  const html = renderToStaticMarkup(
+    React.createElement(
+      TooltipProvider,
+      null,
+      React.createElement(
+        ExternalLinkAnchor,
+        {
+          anchorProps: {},
+          href: "https://example.com/tasks/t_5873512f",
+          isLinearLink: false,
+          label: "t_5873512f",
+        },
+        "t_5873512f",
+      ),
+    ),
+  );
+
+  const className = html.match(/<a[^>]*class="([^"]+)"/)?.[1] ?? "";
+  assert.match(className, /(?:^| )no-underline(?: |$)/);
+  assert.match(className, /(?:^| )hover:underline(?: |$)/);
+  assert.doesNotMatch(className, /(?:^| )underline(?: |$)/);
+});
diff --git a/desktop/src/shared/ui/markdown/ExternalLinkAnchor.tsx b/desktop/src/shared/ui/markdown/ExternalLinkAnchor.tsx
index 00f19fb8dec..ff08a8d8689 100644
--- a/desktop/src/shared/ui/markdown/ExternalLinkAnchor.tsx
+++ b/desktop/src/shared/ui/markdown/ExternalLinkAnchor.tsx
@@ -42,7 +42,7 @@ export function ExternalLinkAnchor({
     <a
       {...anchorProps}
       className={cn(
-        "font-medium underline underline-offset-4 transition-colors",
+        "font-medium no-underline underline-offset-4 transition-colors hover:underline",
         isLinearLink ? "linear-link" : "text-primary hover:text-primary/80",
       )}
       href={href}