fix(gtk3): fix critici e alti su connessioni remote

- log_viewer: command injection fix (shlex.quote su extra field)
- cron_widget: race condition fix (threading.Lock + _write_pending)
- winscp_widget: leak SSH/SFTP transfer connection in chiudi_processo
- winscp_widget: idle_add throttling ogni 100ms (non piu' per-chunk)
- winscp_widget: BUG CRITICO upload/download invertito nel ramo upload
- sftp_editor: temp file cleanup su destroy handler
- keepassxc_manager: subprocess leak fix con try/finally
- rdp_widget: zombie processes (Popen->subprocess.run), resize throttling
- tunnel_manager: override_color deprecato -> CSS provider
- vnc_widget: dead code rimosso (if False), 'tigervnc' -> 'tigervncviewer'

Author: buzzqw

gtk3/cron_widget.py

@@ -256,6 +256,8 @@ def __init__(self, profilo: dict):
         self._profilo = profilo
         self._ssh: "paramiko.SSHClient | None" = None
         self._rows: list = []
+        self._write_lock = threading.Lock()
+        self._write_pending = False
 
         self._build_ui()
         self.connect("destroy", lambda _: self._chiudi())
@@ -400,8 +402,10 @@ def _leggi_crontab(self):
             GLib.idle_add(self._set_status, f"✖ Lettura crontab: {e}")
 
     def _scrivi_crontab(self):
-        if not self._ssh:
-            return
+        with self._write_lock:
+            if not self._ssh or self._write_pending:
+                return
+            self._write_pending = True
         try:
             text = _rows_to_crontab(self._rows)
             stdin, stdout, stderr = self._ssh.exec_command("crontab -", timeout=10)
@@ -415,6 +419,9 @@ def _scrivi_crontab(self):
                 GLib.idle_add(self._set_status, "✔ Crontab salvato")
         except Exception as e:
             GLib.idle_add(self._set_status, f"✖ Salvataggio: {e}")
+        finally:
+            with self._write_lock:
+                self._write_pending = False
 
     def _chiudi(self):
         if self._ssh:

gtk3/keepassxc_manager.py

@@ -459,10 +459,10 @@ def __init__(self, parent=None):
 
         if _HAS_NACL:
             def _test_conn():
+                client = None
                 try:
                     client = KeePassXCClient()
                     if client.exchange_keys():
-                        client.close()
                         GLib.idle_add(lambda: lbl_status.set_markup(
                             f"<span foreground='green'>✔ {t('keepass.connected')}</span>"
                         ))
@@ -475,5 +475,11 @@ def _test_conn():
                     GLib.idle_add(lambda: lbl_status.set_markup(
                         f"<span foreground='orange'>⚠ {t('keepass.error', e=msg)}</span>"
                     ))
+                finally:
+                    if client is not None:
+                        try:
+                            client.close()
+                        except Exception:
+                            pass
 
             threading.Thread(target=_test_conn, daemon=True).start()

gtk3/log_viewer.py

@@ -11,6 +11,7 @@
 
 import os
 import re
+import shlex
 import threading
 
 import gi
@@ -166,9 +167,11 @@ def _get_cmd(self) -> str:
         tmpl = _SORGENTI[idx][0]
         extra = self._extra.get_text().strip()
         if "{svc}" in tmpl:
-            return tmpl.format(svc=extra or "ssh")
+            safe = shlex.quote(extra) if extra else "ssh"
+            return tmpl.format(svc=safe)
         if "{file}" in tmpl:
-            return tmpl.format(file=extra or "/var/log/syslog")
+            safe = shlex.quote(extra) if extra else "/var/log/syslog"
+            return tmpl.format(file=safe)
         return tmpl
 
     # ------------------------------------------------------------------

gtk3/rdp_widget.py

@@ -432,10 +432,10 @@ def _step2():
             return False
 
         def _step3():
-            subprocess.Popen(["xdotool", "windowmove", wid_rdp, "0", "0"],
-                             stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
-            subprocess.Popen(["xdotool", "windowsize", wid_rdp, str(w), str(h)],
-                             stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
+            subprocess.run(["xdotool", "windowmove", wid_rdp, "0", "0"],
+                           timeout=2, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
+            subprocess.run(["xdotool", "windowsize", wid_rdp, str(w), str(h)],
+                           timeout=2, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
             GLib.timeout_add(100, _step4)
             return False
 
@@ -449,8 +449,8 @@ def _step4():
             return False
 
         def _step5():
-            subprocess.Popen(["xdotool", "windowfocus", wid_rdp],
-                             stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
+            subprocess.run(["xdotool", "windowfocus", wid_rdp],
+                           timeout=2, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
             self._reparented = True
             host = self._rdp_host
             self._info.set_text(f"  ●  RDP → {host}")
@@ -467,15 +467,26 @@ def do_size_allocate(self, allocation):
         Gtk.Box.do_size_allocate(self, allocation)
         if not self._reparented or not self._wid_rdp:
             return
-        # Ottieni dimensioni del socket
         if hasattr(self, "_socket"):
             a = self._socket.get_allocation()
             w = max(a.width,  320)
             h = max(a.height, 240)
-            subprocess.Popen(
-                ["xdotool", "windowsize", self._wid_rdp, str(w), str(h)],
-                stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL
-            )
+            if hasattr(self, "_resize_pending") and self._resize_pending:
+                return
+            self._resize_pending = True
+
+            def _do_resize():
+                self._resize_pending = False
+                if self._reparented and self._wid_rdp and hasattr(self, "_socket"):
+                    a = self._socket.get_allocation()
+                    w2 = max(a.width, 320)
+                    h2 = max(a.height, 240)
+                    subprocess.run(
+                        ["xdotool", "windowsize", self._wid_rdp, str(w2), str(h2)],
+                        timeout=2, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL
+                    )
+                return False
+            GLib.timeout_add(150, _do_resize)
 
     # ------------------------------------------------------------------
     # Monitor processo

gtk3/sftp_editor.py

@@ -154,6 +154,7 @@ def __init__(self, sftp, remote_path: str):
         self._ext_editor  = _get_configured_editor()
 
         self._build_ui()
+        self.connect("destroy", lambda w: self._cleanup_tmp())
         threading.Thread(target=self._load, daemon=True).start()
 
     # ------------------------------------------------------------------

gtk3/tunnel_manager.py

@@ -354,9 +354,20 @@ def _init_ui(self):
         self.log_view = Gtk.TextView(buffer=self.log_buffer)
         self.log_view.set_editable(False)
         self.log_view.set_wrap_mode(Gtk.WrapMode.WORD_CHAR)
-        self.log_view.override_background_color(Gtk.StateFlags.NORMAL, Gdk.RGBA(0.1, 0.1, 0.1, 1.0))
-        self.log_view.override_color(Gtk.StateFlags.NORMAL, Gdk.RGBA(0.2, 1.0, 0.2, 1.0))
-        self.log_view.override_font(Pango.FontDescription('Monospace 10'))
+        self.log_view.set_monospace(True)
+
+        css = Gtk.CssProvider()
+        css.load_from_data(b"""
+            textview.log-console {
+                background-color: #1a1a1a;
+                color: #33cc33;
+                font-family: monospace;
+                font-size: 10pt;
+            }
+        """)
+        ctx = self.log_view.get_style_context()
+        ctx.add_provider(css, Gtk.STYLE_PROVIDER_PRIORITY_APPLICATION)
+        ctx.add_class("log-console")
 
         scroll_log = Gtk.ScrolledWindow()
         scroll_log.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)

gtk3/vnc_widget.py

@@ -35,7 +35,7 @@
 
 def _find_vnc_client() -> str | None:
     for c in ["vncviewer", "xtightvncviewer", "xvnc4viewer",
-              "tigervnc", "xtigervncviewer", "krdc", "remmina"]:
+              "tigervncviewer", "xtigervncviewer", "krdc", "remmina"]:
         if shutil.which(c):
             return c
     return None
@@ -235,7 +235,7 @@ def _applica_depth_quality(self):
     def _build_vt_menu(self) -> Gtk.Menu:
         menu = Gtk.Menu()
         for n in range(1, 8):
-            key = getattr(GtkVnc, f'_KEY_F{n}', _KEY_F1 + n - 1) if False else (_KEY_F1 + n - 1)
+            key = _KEY_F1 + n - 1
             mi = Gtk.MenuItem(label=f"Ctrl+Alt+F{n}  (VT{n})")
             mi.connect("activate", lambda _, k=key: self._send_keys([_KEY_CTRL, _KEY_ALT, k]))
             menu.append(mi)

gtk3/winscp_widget.py

@@ -1053,8 +1053,8 @@ def _trasferisci_chunk(self, job: TransferJob, idx: int):
             try:
                 with open(job.dst, "wb") as local_f:
                     tx = 0
+                    last_dl_update = 0.0
                     while True:
-                        # Pausa: aspetta senza consumare CPU
                         while self._coda.is_in_pausa():
                             time.sleep(0.3)
                         if job.annulla:
@@ -1067,7 +1067,10 @@ def _trasferisci_chunk(self, job: TransferJob, idx: int):
                         job.trasferito = tx
                         dt = time.time() - job.t_inizio
                         job.velocita = int(tx / dt) if dt > 0 else 0
-                        GLib.idle_add(self._coda.aggiorna_progress, idx, tx, job.size or tx)
+                        now = time.monotonic()
+                        if now - last_dl_update >= 0.1:
+                            GLib.idle_add(self._coda.aggiorna_progress, idx, tx, job.size or tx)
+                            last_dl_update = now
             finally:
                 remote_f.close()
         else:  # upload
@@ -1078,6 +1081,7 @@ def _trasferisci_chunk(self, job: TransferJob, idx: int):
                 remote_f = self._sftp_transfer.open(job.dst, "wb")
                 try:
                     tx = 0
+                    last_update = 0.0
                     while True:
                         while self._coda.is_in_pausa():
                             time.sleep(0.3)
@@ -1091,7 +1095,10 @@ def _trasferisci_chunk(self, job: TransferJob, idx: int):
                         job.trasferito = tx
                         dt = time.time() - job.t_inizio
                         job.velocita = int(tx / dt) if dt > 0 else 0
-                        GLib.idle_add(self._coda.aggiorna_progress, idx, tx, job.size or tx)
+                        now = time.monotonic()
+                        if now - last_update >= 0.1:
+                            GLib.idle_add(self._coda.aggiorna_progress, idx, tx, job.size or tx)
+                            last_update = now
                 finally:
                     remote_f.close()
 
@@ -1103,9 +1110,19 @@ def chiudi_processo(self):
         if self._sftp:
             try: self._sftp.close()
             except Exception: pass
+            self._sftp = None
         if self._ssh:
             try: self._ssh.close()
             except Exception: pass
+            self._ssh = None
+        if self._sftp_transfer:
+            try: self._sftp_transfer.close()
+            except Exception: pass
+            self._sftp_transfer = None
+        if self._ssh_transfer:
+            try: self._ssh_transfer.close()
+            except Exception: pass
+            self._ssh_transfer = None
 
 
 # ---------------------------------------------------------------------------