fix(rdp): fix broken success-path handling, add cert trust, real home dir, wire up multimon

- RdpEmbedWidget._avvia_rdp: the post-launch bookkeeping (start
  timestamp, PID log, wiring the process stdout to the log view) was
  misplaced inside an except block that only runs on Popen failure,
  followed by a second, unreachable except clause. On every normal
  (successful) internal RDP connection this meant _t_avvio stayed
  None forever, so _monitor_proc() could never tell a fast connection
  failure from a normal session end, and the live xfreerdp output was
  never shown in the log view. Moved the bookkeeping to run after a
  successful launch and merged the two excepts into one.
- xfreerdp/xfreerdp3 command builders (session_command.py preview,
  rdp_widget.py external and embedded paths) now add /cert:tofu.
  Previously no /cert: option was set, so a first connection to a host
  with a self-signed/untrusted certificate (the norm for most RDP
  hosts) could consume the piped stdin meant for the password on the
  certificate prompt instead, breaking auth.
- Drive redirection now shares the real user home (os.path.expanduser)
  instead of the hardcoded "/home" (which exposes every local user's
  home directory on the share, not just the current user's).
- rdp_monitor_mode/rdp_monitor_ids were only honored by the read-only
  command preview shown in the session editor; the two builders that
  actually launch xfreerdp never read them, so multi-monitor selection
  silently did nothing. Both now apply /multimon or /monitors:<ids>.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: buzzqw

gtk3/rdp_widget.py

@@ -180,6 +180,8 @@ def _avvia_rdp(self):
         domain = p.get("rdp_domain", "").strip()
         clips  = p.get("redirect_clipboard", True)
         drives = p.get("redirect_drives", False)
+        mon_mode = p.get("rdp_monitor_mode", "single")
+        mon_ids  = p.get("rdp_monitor_ids", "0").strip()
         self._rdp_host = host
 
         # rdesktop: embedding nativo con -X (no polling)
@@ -205,7 +207,7 @@ def _avvia_rdp(self):
         h_init = max(alloc.height - 30, 768)
 
         args = [client, f"/v:{host}:{port}",
-                f"/w:{w_init}", f"/h:{h_init}"]
+                f"/w:{w_init}", f"/h:{h_init}", "/cert:tofu"]
         if freerdp_ver >= 3:
             args.append("/dynamic-resolution")
         if user:   args.append(f"/u:{user}")
@@ -216,7 +218,11 @@ def _avvia_rdp(self):
             args.append("/auth-pkg-list:ntlm")
         if pwd:    args.append("/from-stdin")
         if clips:  args.append("/clipboard")
-        if drives: args.append("/drive:home,/home")
+        if drives: args.append(f"/drive:home,{os.path.expanduser('~')}")
+        if mon_mode == "all":
+            args.append("/multimon")
+        elif mon_mode == "custom" and mon_ids:
+            args.append(f"/monitors:{mon_ids}")
 
         cmd_display = " ".join(args)
         if pwd:
@@ -254,19 +260,19 @@ def _avvia_rdp(self):
                     _get_log(__name__).debug("Invio password RDP fallito: %s", e)
         except Exception as e:
             _get_log(__name__).debug("Avvio RDP fallito: %s", e)
-            self._t_avvio = datetime.datetime.now()
-            from pcm_logging import get_logger
-            get_logger(__name__).info("Avviato %s PID=%s", client, self._proc.pid)
-            if hasattr(self, "_log_view"):
-                GLib.io_add_watch(
-                    self._proc.stdout.fileno(),
-                    GLib.IO_IN | GLib.IO_HUP | GLib.IO_ERR,
-                    self._on_rdp_output,
-                )
-        except Exception as e:
             self._mostra_errore(str(e))
             return False
 
+        self._t_avvio = datetime.datetime.now()
+        from pcm_logging import get_logger
+        get_logger(__name__).info("Avviato %s PID=%s", client, self._proc.pid)
+        if hasattr(self, "_log_view"):
+            GLib.io_add_watch(
+                self._proc.stdout.fileno(),
+                GLib.IO_IN | GLib.IO_HUP | GLib.IO_ERR,
+                self._on_rdp_output,
+            )
+
         self._poll_attempts = 0
         if self._open_mode == "internal":
             self._poll_source = GLib.timeout_add(500, self._cerca_e_reparenta)
@@ -658,6 +664,8 @@ def _build_freerdp_cmd(profilo: dict) -> list[str]:
     clips  = profilo.get("redirect_clipboard", True)
     drives = profilo.get("redirect_drives", False)
     fs     = profilo.get("fullscreen", False)
+    mon_mode = profilo.get("rdp_monitor_mode", "single")
+    mon_ids  = profilo.get("rdp_monitor_ids", "0").strip()
 
     if client == "rdesktop":
         args = ["rdesktop", "-a16"]
@@ -670,7 +678,7 @@ def _build_freerdp_cmd(profilo: dict) -> list[str]:
 
     # xfreerdp / xfreerdp3
     ver  = _freerdp_major_version(client)
-    args = [client, f"/v:{host}:{port}"]
+    args = [client, f"/v:{host}:{port}", "/cert:tofu"]
     if ver >= 3:
         args.append("/dynamic-resolution")
     if user:   args.append(f"/u:{user}")
@@ -680,5 +688,9 @@ def _build_freerdp_cmd(profilo: dict) -> list[str]:
     if pwd:    args.append("/from-stdin")
     if fs:     args.append("/f")
     if clips:  args.append("/clipboard")
-    if drives: args.append("/drive:home,/home")
+    if drives: args.append(f"/drive:home,{os.path.expanduser('~')}")
+    if mon_mode == "all":
+        args.append("/multimon")
+    elif mon_mode == "custom" and mon_ids:
+        args.append(f"/monitors:{mon_ids}")
     return args

gtk3/session_command.py

@@ -324,13 +324,15 @@ def _build_rdp(p: dict) -> str:
     exe = _get_tool(client)
 
     if client in ("xfreerdp", "xfreerdp3"):
-        args = [f"/v:{_q(f'{host}:{port}')}"]
+        args = [f"/v:{_q(f'{host}:{port}')}", "/cert:tofu"]
         if user: args.append(f"/u:{_q(user)}")
-        if domain: args.append(f"/d:{_q(domain)}")
+        if domain:
+            args.append(f"/d:{_q(domain)}")
+            args.append("/auth-pkg-list:ntlm")
         if pwd: args.append("/from-stdin")
         if p.get("fullscreen"): args.append("/f")
         if p.get("redirect_clipboard"): args.append("/clipboard")
-        if p.get("redirect_drives"): args.append("/drive:home,/home")
+        if p.get("redirect_drives"): args.append(f"/drive:home,{_q(os.path.expanduser('~'))}")
         mon_mode = p.get("rdp_monitor_mode", "single")
         if mon_mode == "all":
             args.append("/multimon")

gtk3/tests/test_session_command.py

@@ -191,3 +191,44 @@ def test_rdesktop_password_is_not_added_to_argv(self, monkeypatch):
             "rdp_client": "rdesktop", "host": "rdp.example", "password": "secret",
         })
         assert not any(arg.startswith("-p") for arg in args)
+
+    def test_xfreerdp_uses_cert_tofu_not_full_ignore(self, monkeypatch):
+        """/cert:tofu valida comunque il certificato dopo il primo collegamento;
+        non deve mai regredire a /cert:ignore (bypass totale)."""
+        import rdp_widget
+        monkeypatch.setattr(rdp_widget, "_freerdp_major_version", lambda c: 3)
+        args = _build_freerdp_cmd({
+            "rdp_client": "xfreerdp3", "host": "rdp.example", "password": "secret",
+        })
+        assert "/cert:tofu" in args
+        assert "/cert:ignore" not in args
+
+    def test_xfreerdp_drive_redirect_uses_real_home(self, monkeypatch):
+        """La condivisione unità deve puntare alla home dell'utente corrente,
+        non alla cartella /home che contiene le home di tutti gli utenti."""
+        import rdp_widget
+        monkeypatch.setattr(rdp_widget, "_freerdp_major_version", lambda c: 3)
+        args = _build_freerdp_cmd({
+            "rdp_client": "xfreerdp3", "host": "rdp.example",
+            "redirect_drives": True,
+        })
+        drive_arg = next(a for a in args if a.startswith("/drive:"))
+        assert drive_arg == f"/drive:home,{os.path.expanduser('~')}"
+        assert drive_arg != "/drive:home,/home"
+
+    def test_xfreerdp_multimon_reaches_real_command(self, monkeypatch):
+        """rdp_monitor_mode deve incidere sul comando davvero eseguito
+        (non solo sull'anteprima mostrata nell'editor sessione)."""
+        import rdp_widget
+        monkeypatch.setattr(rdp_widget, "_freerdp_major_version", lambda c: 3)
+        args = _build_freerdp_cmd({
+            "rdp_client": "xfreerdp3", "host": "rdp.example",
+            "rdp_monitor_mode": "all",
+        })
+        assert "/multimon" in args
+
+        args = _build_freerdp_cmd({
+            "rdp_client": "xfreerdp3", "host": "rdp.example",
+            "rdp_monitor_mode": "custom", "rdp_monitor_ids": "0,1",
+        })
+        assert "/monitors:0,1" in args