Skip to content

PHP Deprecations: Explicitly specify $escape with str_getcsv #140

Description

@CarlosArceLopera

Hi,

PHP 8.4 requires that a value be provided for the $escape parameter to str_getcsv().

See: https://moodle.atlassian.net/browse/MDL-83335

/var/www/site/public/admin/tool/advancedreplace/classes/file_search.php:642
str_getcsv(): the $escape parameter must be provided as its default value will change

Triggered by:

* tool_advancedreplace\file_search_test::test_get_id_from_csv#0
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:213

* tool_advancedreplace\file_search_test::test_get_id_from_csv#1
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:213

* tool_advancedreplace\file_search_test::test_get_id_from_csv#2
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:213

* tool_advancedreplace\file_search_test::test_get_id_from_csv#3
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:213

* tool_advancedreplace\file_search_test::test_resume#1 (2 times)
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:269

* tool_advancedreplace\file_search_test::test_resume#2 (2 times)
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:269

* tool_advancedreplace\file_search_test::test_resume#3 (3 times)
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:269

* tool_advancedreplace\file_search_test::test_resume#4 (3 times)
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:269

* tool_advancedreplace\file_search_test::test_resume#5 (2 times)
  /var/www/site/public/admin/tool/advancedreplace/tests/file_search_test.php:269

Best,
Carlos

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions