fix(cache): set secure 0755 permissions mode when creating directory in FileVarExportHandler

Author: gr8man

system/Cache/FactoriesCache/FileVarExportHandler.php

@@ -23,7 +23,7 @@ public function save(string $key, mixed $val): void
 
         // Two processes may try to create the directory at the same time.
         // is_dir() confirms it exists, so suppressing the warning is safe.
-        if (! is_dir($this->path) && ! @mkdir($this->path, 0777, true) && ! is_dir($this->path)) {
+        if (! is_dir($this->path) && ! @mkdir($this->path, 0755, true) && ! is_dir($this->path)) {
             log_message('error', 'FactoriesCache: cannot create cache directory: ' . $this->path);
 
             return;

tests/system/Cache/FactoriesCacheFileVarExportHandlerTest.php

@@ -27,4 +27,36 @@ protected function createFactoriesCache(): void
         $this->handler = new FileVarExportHandler();
         $this->cache   = new FactoriesCache($this->handler);
     }
+
+    public function testSaveCreatesDirectoryWithCorrectPermissions(): void
+    {
+        $dir      = WRITEPATH . 'cache_test_dir_' . uniqid('', true);
+        $oldUmask = umask(0000);
+
+        try {
+            $handler = new FileVarExportHandler();
+            $this->setPrivateProperty($handler, 'path', $dir);
+
+            $handler->save('test_key', ['data']);
+
+            $this->assertDirectoryExists($dir);
+
+            if (! is_windows()) {
+                $perms = fileperms($dir) & 0777;
+                $this->assertSame(0755, $perms);
+            }
+        } finally {
+            umask($oldUmask);
+
+            if (is_dir($dir)) {
+                $files = glob("{$dir}/*");
+
+                if ($files !== false) {
+                    array_map(unlink(...), $files);
+                }
+
+                rmdir($dir);
+            }
+        }
+    }
 }