Skip to content

Conversation

@mikebonnet
Copy link
Collaborator

@mikebonnet mikebonnet commented Dec 1, 2025

The test_serve_api test was failing when downloading the llama-stack image. Solve the disk space issues by bind-mounting /mnt (with ~65G free) onto ~/.local.

This is the same method used to address disk space issues with other Github Actions workflows.

Summary by Sourcery

CI:

  • Update the GitHub Actions CI job to bind-mount /mnt into the runner's home local directory to increase available disk space for e2e tests.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 1, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CI GitHub Actions workflow to mitigate disk space issues in the e2e llama-stack test by bind-mounting a larger /mnt partition onto the runner's ~/.local directory before installing dependencies.

File-Level Changes

Change Details Files
Ensure the GitHub Actions runner has sufficient disk space for llama-stack image downloads by bind-mounting a larger /mnt partition onto the runner's ~/.local directory before dependency installation.
  • Add diagnostics call to display disk usage via df -h at the start of the job step.
  • Create a world-accessible /mnt/runner directory to serve as the new backing store.
  • Ensure /home/runner/.local exists with permissive other-write permissions for subsequent bind mount usage.
  • Set ownership of /mnt/runner and /home/runner/.local to the runner user and group to avoid permission issues during the workflow.
  • Bind-mount /mnt/runner over /home/runner/.local so that tools using ~/.local (such as image downloads) have access to the more spacious /mnt partition before running apt-get and installing tools.
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

The "test_serve_api" test was failing when downloading the llama-stack
image. Solve the disk space issues by bind-mounting /mnt (with ~65G free)
onto ~/.local.

Signed-off-by: Mike Bonnet <[email protected]>
@mikebonnet mikebonnet changed the title e2e: run llama-stack with --debug e2e: fix llama-stack test failure caused by lack of disk space Dec 2, 2025
@mikebonnet
Copy link
Collaborator Author

@sourcery-ai review

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Bind-mounting the entire /home/runner/.local risks hiding any pre-existing content that GitHub may create there; consider either checking that it’s empty first or bind-mounting a more targeted subdirectory that actually needs the extra space.
  • The permission modes on the newly created directories (-m a=rwx for /mnt/runner and -m o=rwx for /home/runner/.local) are quite permissive and a bit asymmetric; it may be clearer and safer to use a consistent, minimal mode (e.g., 755) and rely on chown runner:runner for ownership.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Bind-mounting the entire `/home/runner/.local` risks hiding any pre-existing content that GitHub may create there; consider either checking that it’s empty first or bind-mounting a more targeted subdirectory that actually needs the extra space.
- The permission modes on the newly created directories (`-m a=rwx` for `/mnt/runner` and `-m o=rwx` for `/home/runner/.local`) are quite permissive and a bit asymmetric; it may be clearer and safer to use a consistent, minimal mode (e.g., `755`) and rely on `chown runner:runner` for ownership.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mikebonnet
Copy link
Collaborator Author

Ignore the Konflux failures, those will be addressed by #2195.

@mikebonnet mikebonnet marked this pull request as ready for review December 2, 2025 01:07
Copy link
Collaborator

@bmahabirbu bmahabirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikebonnet mikebonnet merged commit 6587332 into main Dec 2, 2025
26 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants