-
Notifications
You must be signed in to change notification settings - Fork 285
e2e: fix llama-stack test failure caused by lack of disk space #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CI GitHub Actions workflow to mitigate disk space issues in the e2e llama-stack test by bind-mounting a larger /mnt partition onto the runner's ~/.local directory before installing dependencies. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
42eb752 to
dd377bf
Compare
The "test_serve_api" test was failing when downloading the llama-stack image. Solve the disk space issues by bind-mounting /mnt (with ~65G free) onto ~/.local. Signed-off-by: Mike Bonnet <[email protected]>
dd377bf to
2bf57e0
Compare
|
@sourcery-ai review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Bind-mounting the entire
/home/runner/.localrisks hiding any pre-existing content that GitHub may create there; consider either checking that it’s empty first or bind-mounting a more targeted subdirectory that actually needs the extra space. - The permission modes on the newly created directories (
-m a=rwxfor/mnt/runnerand-m o=rwxfor/home/runner/.local) are quite permissive and a bit asymmetric; it may be clearer and safer to use a consistent, minimal mode (e.g.,755) and rely onchown runner:runnerfor ownership.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Bind-mounting the entire `/home/runner/.local` risks hiding any pre-existing content that GitHub may create there; consider either checking that it’s empty first or bind-mounting a more targeted subdirectory that actually needs the extra space.
- The permission modes on the newly created directories (`-m a=rwx` for `/mnt/runner` and `-m o=rwx` for `/home/runner/.local`) are quite permissive and a bit asymmetric; it may be clearer and safer to use a consistent, minimal mode (e.g., `755`) and rely on `chown runner:runner` for ownership.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Ignore the Konflux failures, those will be addressed by #2195. |
bmahabirbu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The
test_serve_apitest was failing when downloading the llama-stack image. Solve the disk space issues by bind-mounting /mnt (with ~65G free) onto~/.local.This is the same method used to address disk space issues with other Github Actions workflows.
Summary by Sourcery
CI: